pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Mark pageinspect's disk-accessing functions as parallel restrict 2+ messages / 1 participants [nested] [flat]
* pgsql: Mark pageinspect's disk-accessing functions as parallel restrict @ 2022-11-21 20:37 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2022-11-21 20:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Mark pageinspect's disk-accessing functions as parallel restricted. These functions have been marked parallel safe, but the buildfarm's response to commit e2933a6e1 exposed the flaw in that thinking: if you try to use them on a temporary table, and they run inside a parallel worker, they'll fail with "cannot access temporary tables during a parallel operation". Fix that by marking them parallel restricted instead. Maybe someday we'll have a better answer and can reverse this decision. Back-patch to v15. To go back further, we'd have to devise variant versions of pre-1.10 pageinspect versions. Given the lack of field complaints, it doesn't seem worth the trouble. We'll just deem this case unsupported pre-v15. (If anyone does complain, it might be good enough to update the markings manually in their DBs.) Discussion: https://postgr.es/m/E1ox94a-000EHu-VH@gemulon.postgresql.org Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b8988cf1d0a74f2e394278e0d88c2c133ee252fb Modified Files -------------- contrib/pageinspect/Makefile | 3 ++- contrib/pageinspect/pageinspect--1.10--1.11.sql | 28 +++++++++++++++++++++++++ contrib/pageinspect/pageinspect.control | 2 +- 3 files changed, 31 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Mark pageinspect's disk-accessing functions as parallel restrict @ 2022-11-21 20:37 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2022-11-21 20:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Mark pageinspect's disk-accessing functions as parallel restricted. These functions have been marked parallel safe, but the buildfarm's response to commit e2933a6e1 exposed the flaw in that thinking: if you try to use them on a temporary table, and they run inside a parallel worker, they'll fail with "cannot access temporary tables during a parallel operation". Fix that by marking them parallel restricted instead. Maybe someday we'll have a better answer and can reverse this decision. Back-patch to v15. To go back further, we'd have to devise variant versions of pre-1.10 pageinspect versions. Given the lack of field complaints, it doesn't seem worth the trouble. We'll just deem this case unsupported pre-v15. (If anyone does complain, it might be good enough to update the markings manually in their DBs.) Discussion: https://postgr.es/m/E1ox94a-000EHu-VH@gemulon.postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/aeaaf520f409cf314f97c811d2713c99858f035d Modified Files -------------- contrib/pageinspect/Makefile | 3 ++- contrib/pageinspect/meson.build | 1 + contrib/pageinspect/pageinspect--1.10--1.11.sql | 28 +++++++++++++++++++++++++ contrib/pageinspect/pageinspect.control | 2 +- 4 files changed, 32 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-11-21 20:37 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-11-21 20:37 pgsql: Mark pageinspect's disk-accessing functions as parallel restrict Tom Lane <tgl@sss.pgh.pa.us> 2022-11-21 20:37 pgsql: Mark pageinspect's disk-accessing functions as parallel restrict Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox