pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix psql's \sf and \ef for new-style SQL functions.
3+ messages / 1 participants
[nested] [flat]

* pgsql: Fix psql's \sf and \ef for new-style SQL functions.
@ 2022-12-02 19:24 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 3+ messages in thread

From: Tom Lane @ 2022-12-02 19:24 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix psql's \sf and \ef for new-style SQL functions.

Some options of these commands need to be able to identify the start
of the function body within the output of pg_get_functiondef().
It used to be that that always began with "AS", but since the
introduction of new-style SQL functions, it might also start with
"BEGIN" or "RETURN".  Fix that on the psql side, and add some
regression tests.

Noted by me awhile ago, but I didn't do anything about it.
Thanks to David Johnston for a nag.

Discussion: https://postgr.es/m/AM9PR01MB8268D5CDABDF044EE9F42173FE8C9@AM9PR01MB8268.eurprd01.prod.exchangelabs....

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cabfb8241dea84206b90578a769e9cbd813ba477

Modified Files
--------------
src/backend/utils/adt/ruleutils.c  |  4 +--
src/bin/psql/command.c             | 46 ++++++++++++++--------------
src/test/regress/expected/psql.out | 62 ++++++++++++++++++++++++++++++++++++++
src/test/regress/sql/psql.sql      |  8 +++++
4 files changed, 94 insertions(+), 26 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Fix psql's \sf and \ef for new-style SQL functions.
@ 2022-12-02 19:24 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 3+ messages in thread

From: Tom Lane @ 2022-12-02 19:24 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix psql's \sf and \ef for new-style SQL functions.

Some options of these commands need to be able to identify the start
of the function body within the output of pg_get_functiondef().
It used to be that that always began with "AS", but since the
introduction of new-style SQL functions, it might also start with
"BEGIN" or "RETURN".  Fix that on the psql side, and add some
regression tests.

Noted by me awhile ago, but I didn't do anything about it.
Thanks to David Johnston for a nag.

Discussion: https://postgr.es/m/AM9PR01MB8268D5CDABDF044EE9F42173FE8C9@AM9PR01MB8268.eurprd01.prod.exchangelabs....

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/97299cf99df086af847a641161e8b925fdf840b9

Modified Files
--------------
src/backend/utils/adt/ruleutils.c  |  4 +--
src/bin/psql/command.c             | 46 ++++++++++++++--------------
src/test/regress/expected/psql.out | 62 ++++++++++++++++++++++++++++++++++++++
src/test/regress/sql/psql.sql      |  8 +++++
4 files changed, 94 insertions(+), 26 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Fix psql's \sf and \ef for new-style SQL functions.
@ 2022-12-02 19:24 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 3+ messages in thread

From: Tom Lane @ 2022-12-02 19:24 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix psql's \sf and \ef for new-style SQL functions.

Some options of these commands need to be able to identify the start
of the function body within the output of pg_get_functiondef().
It used to be that that always began with "AS", but since the
introduction of new-style SQL functions, it might also start with
"BEGIN" or "RETURN".  Fix that on the psql side, and add some
regression tests.

Noted by me awhile ago, but I didn't do anything about it.
Thanks to David Johnston for a nag.

Discussion: https://postgr.es/m/AM9PR01MB8268D5CDABDF044EE9F42173FE8C9@AM9PR01MB8268.eurprd01.prod.exchangelabs....

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/303b26c1bb14abf20a35a9cddebee65e10f5ebd4

Modified Files
--------------
src/backend/utils/adt/ruleutils.c  |  4 +--
src/bin/psql/command.c             | 46 ++++++++++++++--------------
src/test/regress/expected/psql.out | 62 ++++++++++++++++++++++++++++++++++++++
src/test/regress/sql/psql.sql      |  8 +++++
4 files changed, 94 insertions(+), 26 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2022-12-02 19:24 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-12-02 19:24 pgsql: Fix psql's \sf and \ef for new-style SQL functions. Tom Lane <tgl@sss.pgh.pa.us>
2022-12-02 19:24 pgsql: Fix psql's \sf and \ef for new-style SQL functions. Tom Lane <tgl@sss.pgh.pa.us>
2022-12-02 19:24 pgsql: Fix psql's \sf and \ef for new-style SQL functions. Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox