pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix failure to advance content pointer in sendFileWithContent. 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix failure to advance content pointer in sendFileWithContent. @ 2022-12-12 15:39 Robert Haas <rhaas@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Robert Haas @ 2022-12-12 15:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix failure to advance content pointer in sendFileWithContent. If sendFileWithContent were used to send a file larger than the bbsink buffer size, this would result in corruption. The only files that are sent via sendFileWithContent are the backup label file, the tablespace map file, and .done files for WAL segments included in the backup. Of these, it seems that only the tablespace_map file can become large enough to cause a problem, and then only if you have a lot of tablespaces. If you do have that situation, you might end up with a corrupted tablespace_map file, which would be bad. My commit bef47ff85df18bf4a3a9b13bd2a54820e27f3614 introduced this problem. Report and patch by Antonin Houska. Discussion: http://postgr.es/m/15764.1670528645@antos Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/45f5c81ad2bc2cd4e6a4fa0ba13b34f5c6048d44 Modified Files -------------- src/backend/backup/basebackup.c | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix failure to advance content pointer in sendFileWithContent. @ 2022-12-12 15:39 Robert Haas <rhaas@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Robert Haas @ 2022-12-12 15:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix failure to advance content pointer in sendFileWithContent. If sendFileWithContent were used to send a file larger than the bbsink buffer size, this would result in corruption. The only files that are sent via sendFileWithContent are the backup label file, the tablespace map file, and .done files for WAL segments included in the backup. Of these, it seems that only the tablespace_map file can become large enough to cause a problem, and then only if you have a lot of tablespaces. If you do have that situation, you might end up with a corrupted tablespace_map file, which would be bad. My commit bef47ff85df18bf4a3a9b13bd2a54820e27f3614 introduced this problem. Report and patch by Antonin Houska. Discussion: http://postgr.es/m/15764.1670528645@antos Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8b5ba2f3f40a9c82623a19b551bc5790a84275a2 Modified Files -------------- src/backend/backup/basebackup.c | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-12-12 15:39 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-12-12 15:39 pgsql: Fix failure to advance content pointer in sendFileWithContent. Robert Haas <rhaas@postgresql.org> 2022-12-12 15:39 pgsql: Fix failure to advance content pointer in sendFileWithContent. Robert Haas <rhaas@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox