pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Disable clang 16's -Wcast-function-type-strict. 4+ messages / 2 participants [nested] [flat]
* pgsql: Disable clang 16's -Wcast-function-type-strict. @ 2022-12-12 21:16 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Thomas Munro @ 2022-12-12 21:16 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disable clang 16's -Wcast-function-type-strict. Clang 16 is still in development, but seawasp reveals that it has started warning about many of our casts of function pointers (those introduced by commit 1c27d16e, and some older ones). Disable the new warning for now, since otherwise buildfarm animal seawasp fails, and we have no current plans to change our strategy for these callback function types. May be back-patched with other Clang/LLVM 16 changes around release time. Discussion: https://postgr.es/m/CA%2BhUKGJvX%2BL3aMN84ksT-cGy08VHErRNip3nV-WmTx7f6Pqhyw%40mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/101c37cd342a3ae134bb3e5e0abb14ae46692b56 Modified Files -------------- configure | 44 ++++++++++++++++++++++++++++++++++++++++++++ configure.ac | 6 ++++++ meson.build | 3 +++ 3 files changed, 53 insertions(+) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Disable clang 16's -Wcast-function-type-strict. @ 2024-07-12 00:56 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Thomas Munro @ 2024-07-12 00:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disable clang 16's -Wcast-function-type-strict. This is a back-patch of commit 101c37cd into REL_14_STABLE and REL_15_STABLE. Those branches had commit de8feb1f3, which turned on -Wcast-function-type, but did not disable -Wcast-function-type-strict. This silences warnings about function pointer types without prototypes based on new C23 rules, that we want to suppress for now. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CA%2BhUKGKnBvdrbH2LW%2B7-Lv599t9JFOHjx%3Dxw-VQmdoj%3D9585CQ%40mail.gmail.com Discussion: https://postgr.es/m/CA%2BhUKGJvX%2BL3aMN84ksT-cGy08VHErRNip3nV-WmTx7f6Pqhyw%40mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/27831127d641b3065bd238ed513def452baeea80 Modified Files -------------- configure | 44 ++++++++++++++++++++++++++++++++++++++++++++ configure.ac | 6 ++++++ 2 files changed, 50 insertions(+) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Disable clang 16's -Wcast-function-type-strict. @ 2024-07-12 00:56 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Thomas Munro @ 2024-07-12 00:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disable clang 16's -Wcast-function-type-strict. This is a back-patch of commit 101c37cd into REL_14_STABLE and REL_15_STABLE. Those branches had commit de8feb1f3, which turned on -Wcast-function-type, but did not disable -Wcast-function-type-strict. This silences warnings about function pointer types without prototypes based on new C23 rules, that we want to suppress for now. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CA%2BhUKGKnBvdrbH2LW%2B7-Lv599t9JFOHjx%3Dxw-VQmdoj%3D9585CQ%40mail.gmail.com Discussion: https://postgr.es/m/CA%2BhUKGJvX%2BL3aMN84ksT-cGy08VHErRNip3nV-WmTx7f6Pqhyw%40mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6e2552d180a0a3a694c2f91ec01bec51d9fed671 Modified Files -------------- configure | 44 ++++++++++++++++++++++++++++++++++++++++++++ configure.ac | 6 ++++++ 2 files changed, 50 insertions(+) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Disable clang 16's -Wcast-function-type-strict. @ 2024-11-07 23:19 Andrew Dunstan <andrew@dunslane.net> 0 siblings, 0 replies; 4+ messages in thread From: Andrew Dunstan @ 2024-11-07 23:19 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disable clang 16's -Wcast-function-type-strict. Clang 16 is still in development, but seawasp reveals that it has started warning about many of our casts of function pointers (those introduced by commit 1c27d16e, and some older ones). Disable the new warning for now, since otherwise buildfarm animal seawasp fails, and we have no current plans to change our strategy for these callback function types. May be back-patched with other Clang/LLVM 16 changes around release time. Discussion: https://postgr.es/m/CA%2BhUKGJvX%2BL3aMN84ksT-cGy08VHErRNip3nV-WmTx7f6Pqhyw%40mail.gmail.com (cherry picked from commit 101c37cd342a3ae134bb3e5e0abb14ae46692b56) Author: Thomas Munro <tmunro@postgresql.org> Author: Alexandra Wang <alexandra.wang.oss@gmail.com> Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b4363fc66e642b70f88455004e5bc6d67c65cf71 Author: Thomas Munro <tmunro@postgresql.org> Modified Files -------------- configure | 44 ++++++++++++++++++++++++++++++++++++++++++++ configure.in | 6 ++++++ meson.build | 0 3 files changed, 50 insertions(+) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-11-07 23:19 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-12-12 21:16 pgsql: Disable clang 16's -Wcast-function-type-strict. Thomas Munro <tmunro@postgresql.org> 2024-07-12 00:56 pgsql: Disable clang 16's -Wcast-function-type-strict. Thomas Munro <tmunro@postgresql.org> 2024-07-12 00:56 pgsql: Disable clang 16's -Wcast-function-type-strict. Thomas Munro <tmunro@postgresql.org> 2024-11-07 23:19 pgsql: Disable clang 16's -Wcast-function-type-strict. Andrew Dunstan <andrew@dunslane.net>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox