pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Use appendStringInfoString instead of appendStringInfo where pos
2+ messages / 2 participants
[nested] [flat]

* pgsql: Use appendStringInfoString instead of appendStringInfo where pos
@ 2013-10-31 15:10 Robert Haas <rhaas@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Robert Haas @ 2013-10-31 15:10 UTC (permalink / raw)
  To: pgsql-committers

Use appendStringInfoString instead of appendStringInfo where possible.

This shaves a few cycles, and generally seems like good programming
practice.

David Rowley

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/cacbdd78106526d7c4f11f90b538f96ba8696fb0

Modified Files
--------------
contrib/cube/cube.c                       |    6 +-
contrib/dblink/dblink.c                   |   28 ++--
contrib/pg_trgm/trgm_regexp.c             |   62 ++++-----
contrib/postgres_fdw/deparse.c            |   10 +-
contrib/postgres_fdw/postgres_fdw.c       |    6 +-
contrib/tablefunc/tablefunc.c             |    2 +-
src/backend/access/rmgrdesc/clogdesc.c    |    2 +-
src/backend/access/rmgrdesc/dbasedesc.c   |    2 +-
src/backend/access/rmgrdesc/gindesc.c     |   16 +--
src/backend/access/rmgrdesc/gistdesc.c    |    4 +-
src/backend/access/rmgrdesc/heapdesc.c    |   34 ++---
src/backend/access/rmgrdesc/mxactdesc.c   |    2 +-
src/backend/access/rmgrdesc/nbtdesc.c     |   10 +-
src/backend/access/rmgrdesc/relmapdesc.c  |    2 +-
src/backend/access/rmgrdesc/seqdesc.c     |    4 +-
src/backend/access/rmgrdesc/smgrdesc.c    |    2 +-
src/backend/access/rmgrdesc/spgdesc.c     |    2 +-
src/backend/access/rmgrdesc/standbydesc.c |    8 +-
src/backend/access/rmgrdesc/tblspcdesc.c  |    2 +-
src/backend/access/rmgrdesc/xactdesc.c    |   28 ++--
src/backend/access/rmgrdesc/xlogdesc.c    |    6 +-
src/backend/access/transam/xlog.c         |    4 +-
src/backend/catalog/objectaddress.c       |  123 ++++++++---------
src/backend/commands/explain.c            |    4 +-
src/backend/commands/tsearchcmds.c        |    2 +-
src/backend/nodes/outfuncs.c              |  130 +++++++++---------
src/backend/tcop/postgres.c               |    2 +-
src/backend/utils/adt/regproc.c           |    4 +-
src/backend/utils/adt/ri_triggers.c       |   12 +-
src/backend/utils/adt/ruleutils.c         |  214 ++++++++++++++---------------
src/backend/utils/adt/xml.c               |   66 +++++----
src/backend/utils/fmgr/dfmgr.c            |    2 +-
src/backend/utils/misc/guc.c              |    2 +-
33 files changed, 399 insertions(+), 404 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Use appendStringInfoString instead of appendBinaryStringInfo whe
@ 2022-12-30 10:15 Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Peter Eisentraut @ 2022-12-30 10:15 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Use appendStringInfoString instead of appendBinaryStringInfo where possible

For the jsonpath output, we don't need to squeeze out every bit of
performance, so instead use a more robust coding style.  There are
similar calls in jsonb.c, which we leave alone here since there is
indeed a performance impact for bulk exports.

Discussion: https://www.postgresql.org/message-id/flat/a0086cfc-ff0f-2827-20fe-52b591d2666c%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/33a33f0ba4d70a704e2d6bb8ee85f29fe18cead9

Modified Files
--------------
src/backend/utils/adt/jsonpath.c | 42 ++++++++++++++++++++--------------------
1 file changed, 21 insertions(+), 21 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-12-30 10:15 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2013-10-31 15:10 pgsql: Use appendStringInfoString instead of appendStringInfo where pos Robert Haas <rhaas@postgresql.org>
2022-12-30 10:15 pgsql: Use appendStringInfoString instead of appendBinaryStringInfo whe Peter Eisentraut <peter@eisentraut.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox