pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Create common infrastructure for cross-version upgrade testing. 12+ messages / 1 participants [nested] [flat]
* pgsql: Create common infrastructure for cross-version upgrade testing. @ 2023-01-17 01:37 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2023-01-17 01:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Create common infrastructure for cross-version upgrade testing. To test pg_upgrade across major PG versions, we have to be able to modify or drop any old objects with no-longer-supported properties, and we have to be able to deal with cosmetic changes in pg_dump output. Up to now, the buildfarm and pg_upgrade's own test infrastructure had separate implementations of the former, and we had nothing but very ad-hoc rules for the latter (including an arbitrary threshold on how many lines of unchecked diff were okay!). This patch creates a Perl module that can be shared by both those use-cases, and adds logic that deals with pg_dump output diffs in a much more tightly defined fashion. This largely supersedes previous efforts in commits 0df9641d3, 9814ff550, and 62be9e4cd, which developed a SQL-script-based solution for the task of dropping old objects. There was nothing fundamentally wrong with that work in itself, but it had no basis for solving the output-formatting problem. The most plausible way to deal with formatting is to build a Perl module that can perform editing on the dump files; and once we commit to that, it makes more sense for the same module to also embed the knowledge of what has to be done for dropping old objects. Back-patch versions of the helper module as far as 9.2, to support buildfarm animals that still test that far back. It's also necessary to back-patch PostgreSQL/Version.pm, because the new code depends on that. I fixed up pg_upgrade's 002_pg_upgrade.pl in v15, but did not look into back-patching it further than that. Tom Lane and Andrew Dunstan Discussion: https://postgr.es/m/891521.1673657296@sss.pgh.pa.us Branch ------ REL9_2_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a2091843f69e426676e9f26a99190acd8215267d Modified Files -------------- src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 215 +++++++++++++++++++++++++ src/test/perl/PostgreSQL/Version.pm | 167 +++++++++++++++++++ 2 files changed, 382 insertions(+) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Create common infrastructure for cross-version upgrade testing. @ 2023-01-17 01:37 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2023-01-17 01:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Create common infrastructure for cross-version upgrade testing. To test pg_upgrade across major PG versions, we have to be able to modify or drop any old objects with no-longer-supported properties, and we have to be able to deal with cosmetic changes in pg_dump output. Up to now, the buildfarm and pg_upgrade's own test infrastructure had separate implementations of the former, and we had nothing but very ad-hoc rules for the latter (including an arbitrary threshold on how many lines of unchecked diff were okay!). This patch creates a Perl module that can be shared by both those use-cases, and adds logic that deals with pg_dump output diffs in a much more tightly defined fashion. This largely supersedes previous efforts in commits 0df9641d3, 9814ff550, and 62be9e4cd, which developed a SQL-script-based solution for the task of dropping old objects. There was nothing fundamentally wrong with that work in itself, but it had no basis for solving the output-formatting problem. The most plausible way to deal with formatting is to build a Perl module that can perform editing on the dump files; and once we commit to that, it makes more sense for the same module to also embed the knowledge of what has to be done for dropping old objects. Back-patch versions of the helper module as far as 9.2, to support buildfarm animals that still test that far back. It's also necessary to back-patch PostgreSQL/Version.pm, because the new code depends on that. I fixed up pg_upgrade's 002_pg_upgrade.pl in v15, but did not look into back-patching it further than that. Tom Lane and Andrew Dunstan Discussion: https://postgr.es/m/891521.1673657296@sss.pgh.pa.us Branch ------ REL9_5_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bfa3d27906646f39599901891a237a736191ffc9 Modified Files -------------- src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 345 +++++++++++++++++++++++++ src/test/perl/PostgreSQL/Version.pm | 167 ++++++++++++ 2 files changed, 512 insertions(+) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Create common infrastructure for cross-version upgrade testing. @ 2023-01-17 01:37 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2023-01-17 01:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Create common infrastructure for cross-version upgrade testing. To test pg_upgrade across major PG versions, we have to be able to modify or drop any old objects with no-longer-supported properties, and we have to be able to deal with cosmetic changes in pg_dump output. Up to now, the buildfarm and pg_upgrade's own test infrastructure had separate implementations of the former, and we had nothing but very ad-hoc rules for the latter (including an arbitrary threshold on how many lines of unchecked diff were okay!). This patch creates a Perl module that can be shared by both those use-cases, and adds logic that deals with pg_dump output diffs in a much more tightly defined fashion. This largely supersedes previous efforts in commits 0df9641d3, 9814ff550, and 62be9e4cd, which developed a SQL-script-based solution for the task of dropping old objects. There was nothing fundamentally wrong with that work in itself, but it had no basis for solving the output-formatting problem. The most plausible way to deal with formatting is to build a Perl module that can perform editing on the dump files; and once we commit to that, it makes more sense for the same module to also embed the knowledge of what has to be done for dropping old objects. Back-patch versions of the helper module as far as 9.2, to support buildfarm animals that still test that far back. It's also necessary to back-patch PostgreSQL/Version.pm, because the new code depends on that. I fixed up pg_upgrade's 002_pg_upgrade.pl in v15, but did not look into back-patching it further than that. Tom Lane and Andrew Dunstan Discussion: https://postgr.es/m/891521.1673657296@sss.pgh.pa.us Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0e4d38100acb90d93e68694674050f4cebdd816a Modified Files -------------- src/bin/pg_upgrade/upgrade_adapt.sql | 80 ----- src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 479 +++++++++++++++++++++++++ src/test/perl/PostgreSQL/Version.pm | 167 +++++++++ 3 files changed, 646 insertions(+), 80 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Create common infrastructure for cross-version upgrade testing. @ 2023-01-17 01:37 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2023-01-17 01:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Create common infrastructure for cross-version upgrade testing. To test pg_upgrade across major PG versions, we have to be able to modify or drop any old objects with no-longer-supported properties, and we have to be able to deal with cosmetic changes in pg_dump output. Up to now, the buildfarm and pg_upgrade's own test infrastructure had separate implementations of the former, and we had nothing but very ad-hoc rules for the latter (including an arbitrary threshold on how many lines of unchecked diff were okay!). This patch creates a Perl module that can be shared by both those use-cases, and adds logic that deals with pg_dump output diffs in a much more tightly defined fashion. This largely supersedes previous efforts in commits 0df9641d3, 9814ff550, and 62be9e4cd, which developed a SQL-script-based solution for the task of dropping old objects. There was nothing fundamentally wrong with that work in itself, but it had no basis for solving the output-formatting problem. The most plausible way to deal with formatting is to build a Perl module that can perform editing on the dump files; and once we commit to that, it makes more sense for the same module to also embed the knowledge of what has to be done for dropping old objects. Back-patch versions of the helper module as far as 9.2, to support buildfarm animals that still test that far back. It's also necessary to back-patch PostgreSQL/Version.pm, because the new code depends on that. I fixed up pg_upgrade's 002_pg_upgrade.pl in v15, but did not look into back-patching it further than that. Tom Lane and Andrew Dunstan Discussion: https://postgr.es/m/891521.1673657296@sss.pgh.pa.us Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4ad0896bca92d98c7a419af6d30e59543ec9a398 Modified Files -------------- src/bin/pg_upgrade/TESTING | 46 ++- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 132 +++++-- src/bin/pg_upgrade/upgrade_adapt.sql | 91 ----- src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 500 +++++++++++++++++++++++++ 4 files changed, 622 insertions(+), 147 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Create common infrastructure for cross-version upgrade testing. @ 2023-01-17 01:37 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2023-01-17 01:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Create common infrastructure for cross-version upgrade testing. To test pg_upgrade across major PG versions, we have to be able to modify or drop any old objects with no-longer-supported properties, and we have to be able to deal with cosmetic changes in pg_dump output. Up to now, the buildfarm and pg_upgrade's own test infrastructure had separate implementations of the former, and we had nothing but very ad-hoc rules for the latter (including an arbitrary threshold on how many lines of unchecked diff were okay!). This patch creates a Perl module that can be shared by both those use-cases, and adds logic that deals with pg_dump output diffs in a much more tightly defined fashion. This largely supersedes previous efforts in commits 0df9641d3, 9814ff550, and 62be9e4cd, which developed a SQL-script-based solution for the task of dropping old objects. There was nothing fundamentally wrong with that work in itself, but it had no basis for solving the output-formatting problem. The most plausible way to deal with formatting is to build a Perl module that can perform editing on the dump files; and once we commit to that, it makes more sense for the same module to also embed the knowledge of what has to be done for dropping old objects. Back-patch versions of the helper module as far as 9.2, to support buildfarm animals that still test that far back. It's also necessary to back-patch PostgreSQL/Version.pm, because the new code depends on that. I fixed up pg_upgrade's 002_pg_upgrade.pl in v15, but did not look into back-patching it further than that. Tom Lane and Andrew Dunstan Discussion: https://postgr.es/m/891521.1673657296@sss.pgh.pa.us Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ddd89df26b9779e1b6415cdf3617563072bfa716 Modified Files -------------- src/bin/pg_upgrade/upgrade_adapt.sql | 51 --- src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 414 +++++++++++++++++++++++++ src/test/perl/PostgreSQL/Version.pm | 167 ++++++++++ 3 files changed, 581 insertions(+), 51 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Create common infrastructure for cross-version upgrade testing. @ 2023-01-17 01:37 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2023-01-17 01:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Create common infrastructure for cross-version upgrade testing. To test pg_upgrade across major PG versions, we have to be able to modify or drop any old objects with no-longer-supported properties, and we have to be able to deal with cosmetic changes in pg_dump output. Up to now, the buildfarm and pg_upgrade's own test infrastructure had separate implementations of the former, and we had nothing but very ad-hoc rules for the latter (including an arbitrary threshold on how many lines of unchecked diff were okay!). This patch creates a Perl module that can be shared by both those use-cases, and adds logic that deals with pg_dump output diffs in a much more tightly defined fashion. This largely supersedes previous efforts in commits 0df9641d3, 9814ff550, and 62be9e4cd, which developed a SQL-script-based solution for the task of dropping old objects. There was nothing fundamentally wrong with that work in itself, but it had no basis for solving the output-formatting problem. The most plausible way to deal with formatting is to build a Perl module that can perform editing on the dump files; and once we commit to that, it makes more sense for the same module to also embed the knowledge of what has to be done for dropping old objects. Back-patch versions of the helper module as far as 9.2, to support buildfarm animals that still test that far back. It's also necessary to back-patch PostgreSQL/Version.pm, because the new code depends on that. I fixed up pg_upgrade's 002_pg_upgrade.pl in v15, but did not look into back-patching it further than that. Tom Lane and Andrew Dunstan Discussion: https://postgr.es/m/891521.1673657296@sss.pgh.pa.us Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8e7398dce55b1d2a32a31f11179075086d112b66 Modified Files -------------- src/bin/pg_upgrade/upgrade_adapt.sql | 91 ----- src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 528 +++++++++++++++++++++++++ src/test/perl/PostgreSQL/Version.pm | 167 ++++++++ 3 files changed, 695 insertions(+), 91 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Create common infrastructure for cross-version upgrade testing. @ 2023-01-17 01:37 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2023-01-17 01:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Create common infrastructure for cross-version upgrade testing. To test pg_upgrade across major PG versions, we have to be able to modify or drop any old objects with no-longer-supported properties, and we have to be able to deal with cosmetic changes in pg_dump output. Up to now, the buildfarm and pg_upgrade's own test infrastructure had separate implementations of the former, and we had nothing but very ad-hoc rules for the latter (including an arbitrary threshold on how many lines of unchecked diff were okay!). This patch creates a Perl module that can be shared by both those use-cases, and adds logic that deals with pg_dump output diffs in a much more tightly defined fashion. This largely supersedes previous efforts in commits 0df9641d3, 9814ff550, and 62be9e4cd, which developed a SQL-script-based solution for the task of dropping old objects. There was nothing fundamentally wrong with that work in itself, but it had no basis for solving the output-formatting problem. The most plausible way to deal with formatting is to build a Perl module that can perform editing on the dump files; and once we commit to that, it makes more sense for the same module to also embed the knowledge of what has to be done for dropping old objects. Back-patch versions of the helper module as far as 9.2, to support buildfarm animals that still test that far back. It's also necessary to back-patch PostgreSQL/Version.pm, because the new code depends on that. I fixed up pg_upgrade's 002_pg_upgrade.pl in v15, but did not look into back-patching it further than that. Tom Lane and Andrew Dunstan Discussion: https://postgr.es/m/891521.1673657296@sss.pgh.pa.us Branch ------ REL9_6_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3911fd55f53a930fcca6bc4889209021cc50ec2f Modified Files -------------- src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 407 +++++++++++++++++++++++++ src/test/perl/PostgreSQL/Version.pm | 167 ++++++++++ 2 files changed, 574 insertions(+) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Create common infrastructure for cross-version upgrade testing. @ 2023-01-17 01:37 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2023-01-17 01:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Create common infrastructure for cross-version upgrade testing. To test pg_upgrade across major PG versions, we have to be able to modify or drop any old objects with no-longer-supported properties, and we have to be able to deal with cosmetic changes in pg_dump output. Up to now, the buildfarm and pg_upgrade's own test infrastructure had separate implementations of the former, and we had nothing but very ad-hoc rules for the latter (including an arbitrary threshold on how many lines of unchecked diff were okay!). This patch creates a Perl module that can be shared by both those use-cases, and adds logic that deals with pg_dump output diffs in a much more tightly defined fashion. This largely supersedes previous efforts in commits 0df9641d3, 9814ff550, and 62be9e4cd, which developed a SQL-script-based solution for the task of dropping old objects. There was nothing fundamentally wrong with that work in itself, but it had no basis for solving the output-formatting problem. The most plausible way to deal with formatting is to build a Perl module that can perform editing on the dump files; and once we commit to that, it makes more sense for the same module to also embed the knowledge of what has to be done for dropping old objects. Back-patch versions of the helper module as far as 9.2, to support buildfarm animals that still test that far back. It's also necessary to back-patch PostgreSQL/Version.pm, because the new code depends on that. I fixed up pg_upgrade's 002_pg_upgrade.pl in v15, but did not look into back-patching it further than that. Tom Lane and Andrew Dunstan Discussion: https://postgr.es/m/891521.1673657296@sss.pgh.pa.us Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f02a75222821d1633343c81f5a9183a6e7acee62 Modified Files -------------- src/bin/pg_upgrade/upgrade_adapt.sql | 58 ---- src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 416 +++++++++++++++++++++++++ src/test/perl/PostgreSQL/Version.pm | 167 ++++++++++ 3 files changed, 583 insertions(+), 58 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Create common infrastructure for cross-version upgrade testing. @ 2023-01-17 01:37 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2023-01-17 01:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Create common infrastructure for cross-version upgrade testing. To test pg_upgrade across major PG versions, we have to be able to modify or drop any old objects with no-longer-supported properties, and we have to be able to deal with cosmetic changes in pg_dump output. Up to now, the buildfarm and pg_upgrade's own test infrastructure had separate implementations of the former, and we had nothing but very ad-hoc rules for the latter (including an arbitrary threshold on how many lines of unchecked diff were okay!). This patch creates a Perl module that can be shared by both those use-cases, and adds logic that deals with pg_dump output diffs in a much more tightly defined fashion. This largely supersedes previous efforts in commits 0df9641d3, 9814ff550, and 62be9e4cd, which developed a SQL-script-based solution for the task of dropping old objects. There was nothing fundamentally wrong with that work in itself, but it had no basis for solving the output-formatting problem. The most plausible way to deal with formatting is to build a Perl module that can perform editing on the dump files; and once we commit to that, it makes more sense for the same module to also embed the knowledge of what has to be done for dropping old objects. Back-patch versions of the helper module as far as 9.2, to support buildfarm animals that still test that far back. It's also necessary to back-patch PostgreSQL/Version.pm, because the new code depends on that. I fixed up pg_upgrade's 002_pg_upgrade.pl in v15, but did not look into back-patching it further than that. Tom Lane and Andrew Dunstan Discussion: https://postgr.es/m/891521.1673657296@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/52585f8f072ac187380f7e02183e87dcf6789ff0 Modified Files -------------- src/bin/pg_upgrade/TESTING | 61 ++- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 76 ++-- src/bin/pg_upgrade/upgrade_adapt.sql | 115 ------ src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 524 +++++++++++++++++++++++++ 4 files changed, 586 insertions(+), 190 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Create common infrastructure for cross-version upgrade testing. @ 2023-01-17 01:37 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2023-01-17 01:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Create common infrastructure for cross-version upgrade testing. To test pg_upgrade across major PG versions, we have to be able to modify or drop any old objects with no-longer-supported properties, and we have to be able to deal with cosmetic changes in pg_dump output. Up to now, the buildfarm and pg_upgrade's own test infrastructure had separate implementations of the former, and we had nothing but very ad-hoc rules for the latter (including an arbitrary threshold on how many lines of unchecked diff were okay!). This patch creates a Perl module that can be shared by both those use-cases, and adds logic that deals with pg_dump output diffs in a much more tightly defined fashion. This largely supersedes previous efforts in commits 0df9641d3, 9814ff550, and 62be9e4cd, which developed a SQL-script-based solution for the task of dropping old objects. There was nothing fundamentally wrong with that work in itself, but it had no basis for solving the output-formatting problem. The most plausible way to deal with formatting is to build a Perl module that can perform editing on the dump files; and once we commit to that, it makes more sense for the same module to also embed the knowledge of what has to be done for dropping old objects. Back-patch versions of the helper module as far as 9.2, to support buildfarm animals that still test that far back. It's also necessary to back-patch PostgreSQL/Version.pm, because the new code depends on that. I fixed up pg_upgrade's 002_pg_upgrade.pl in v15, but did not look into back-patching it further than that. Tom Lane and Andrew Dunstan Discussion: https://postgr.es/m/891521.1673657296@sss.pgh.pa.us Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3f0b9df88bb33ec52b0af8b11295d256d2011e29 Modified Files -------------- src/bin/pg_upgrade/upgrade_adapt.sql | 80 ----- src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 479 +++++++++++++++++++++++++ src/test/perl/PostgreSQL/Version.pm | 167 +++++++++ 3 files changed, 646 insertions(+), 80 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Create common infrastructure for cross-version upgrade testing. @ 2023-01-17 01:37 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2023-01-17 01:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Create common infrastructure for cross-version upgrade testing. To test pg_upgrade across major PG versions, we have to be able to modify or drop any old objects with no-longer-supported properties, and we have to be able to deal with cosmetic changes in pg_dump output. Up to now, the buildfarm and pg_upgrade's own test infrastructure had separate implementations of the former, and we had nothing but very ad-hoc rules for the latter (including an arbitrary threshold on how many lines of unchecked diff were okay!). This patch creates a Perl module that can be shared by both those use-cases, and adds logic that deals with pg_dump output diffs in a much more tightly defined fashion. This largely supersedes previous efforts in commits 0df9641d3, 9814ff550, and 62be9e4cd, which developed a SQL-script-based solution for the task of dropping old objects. There was nothing fundamentally wrong with that work in itself, but it had no basis for solving the output-formatting problem. The most plausible way to deal with formatting is to build a Perl module that can perform editing on the dump files; and once we commit to that, it makes more sense for the same module to also embed the knowledge of what has to be done for dropping old objects. Back-patch versions of the helper module as far as 9.2, to support buildfarm animals that still test that far back. It's also necessary to back-patch PostgreSQL/Version.pm, because the new code depends on that. I fixed up pg_upgrade's 002_pg_upgrade.pl in v15, but did not look into back-patching it further than that. Tom Lane and Andrew Dunstan Discussion: https://postgr.es/m/891521.1673657296@sss.pgh.pa.us Branch ------ REL9_4_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4bcf3521290af5317b6ff1f5ae98682e96a3013f Modified Files -------------- src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 293 +++++++++++++++++++++++++ src/test/perl/PostgreSQL/Version.pm | 167 ++++++++++++++ 2 files changed, 460 insertions(+) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: Create common infrastructure for cross-version upgrade testing. @ 2023-01-17 01:37 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 12+ messages in thread From: Tom Lane @ 2023-01-17 01:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Create common infrastructure for cross-version upgrade testing. To test pg_upgrade across major PG versions, we have to be able to modify or drop any old objects with no-longer-supported properties, and we have to be able to deal with cosmetic changes in pg_dump output. Up to now, the buildfarm and pg_upgrade's own test infrastructure had separate implementations of the former, and we had nothing but very ad-hoc rules for the latter (including an arbitrary threshold on how many lines of unchecked diff were okay!). This patch creates a Perl module that can be shared by both those use-cases, and adds logic that deals with pg_dump output diffs in a much more tightly defined fashion. This largely supersedes previous efforts in commits 0df9641d3, 9814ff550, and 62be9e4cd, which developed a SQL-script-based solution for the task of dropping old objects. There was nothing fundamentally wrong with that work in itself, but it had no basis for solving the output-formatting problem. The most plausible way to deal with formatting is to build a Perl module that can perform editing on the dump files; and once we commit to that, it makes more sense for the same module to also embed the knowledge of what has to be done for dropping old objects. Back-patch versions of the helper module as far as 9.2, to support buildfarm animals that still test that far back. It's also necessary to back-patch PostgreSQL/Version.pm, because the new code depends on that. I fixed up pg_upgrade's 002_pg_upgrade.pl in v15, but did not look into back-patching it further than that. Tom Lane and Andrew Dunstan Discussion: https://postgr.es/m/891521.1673657296@sss.pgh.pa.us Branch ------ REL9_3_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2e8bedc3d68c362a723dbbd94a30665cf411e013 Modified Files -------------- src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 293 +++++++++++++++++++++++++ src/test/perl/PostgreSQL/Version.pm | 167 ++++++++++++++ 2 files changed, 460 insertions(+) ^ permalink raw reply [nested|flat] 12+ messages in thread
end of thread, other threads:[~2023-01-17 01:37 UTC | newest] Thread overview: 12+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-01-17 01:37 pgsql: Create common infrastructure for cross-version upgrade testing. Tom Lane <tgl@sss.pgh.pa.us> 2023-01-17 01:37 pgsql: Create common infrastructure for cross-version upgrade testing. Tom Lane <tgl@sss.pgh.pa.us> 2023-01-17 01:37 pgsql: Create common infrastructure for cross-version upgrade testing. Tom Lane <tgl@sss.pgh.pa.us> 2023-01-17 01:37 pgsql: Create common infrastructure for cross-version upgrade testing. Tom Lane <tgl@sss.pgh.pa.us> 2023-01-17 01:37 pgsql: Create common infrastructure for cross-version upgrade testing. Tom Lane <tgl@sss.pgh.pa.us> 2023-01-17 01:37 pgsql: Create common infrastructure for cross-version upgrade testing. Tom Lane <tgl@sss.pgh.pa.us> 2023-01-17 01:37 pgsql: Create common infrastructure for cross-version upgrade testing. Tom Lane <tgl@sss.pgh.pa.us> 2023-01-17 01:37 pgsql: Create common infrastructure for cross-version upgrade testing. Tom Lane <tgl@sss.pgh.pa.us> 2023-01-17 01:37 pgsql: Create common infrastructure for cross-version upgrade testing. Tom Lane <tgl@sss.pgh.pa.us> 2023-01-17 01:37 pgsql: Create common infrastructure for cross-version upgrade testing. Tom Lane <tgl@sss.pgh.pa.us> 2023-01-17 01:37 pgsql: Create common infrastructure for cross-version upgrade testing. Tom Lane <tgl@sss.pgh.pa.us> 2023-01-17 01:37 pgsql: Create common infrastructure for cross-version upgrade testing. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox