pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Reject CancelRequestPacket having unexpected length.
6+ messages / 1 participants
[nested] [flat]

* pgsql: Reject CancelRequestPacket having unexpected length.
@ 2023-01-21 14:12  Noah Misch <noah@leadboat.com>
  0 siblings, 0 replies; 6+ messages in thread

From: Noah Misch @ 2023-01-21 14:12 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject CancelRequestPacket having unexpected length.

When the length was too short, the server read outside the allocation.
That yielded the same log noise as sending the correct length with
(backendPID,cancelAuthCode) matching nothing.  Change to a message about
the unexpected length.  Given the attacker's lack of control over the
memory layout and the general lack of diversity in memory layouts at the
code in question, we doubt a would-be attacker could cause a segfault.
Hence, while the report arrived via security@postgresql.org, this is not
a vulnerability.  Back-patch to v11 (all supported versions).

Andrey Borodin, reviewed by Tom Lane.  Reported by Andrey Borodin.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e52daaabf8f1bf8096b0c105e2f719d9c68be3fa

Modified Files
--------------
src/backend/postmaster/postmaster.c | 7 +++++++
1 file changed, 7 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Reject CancelRequestPacket having unexpected length.
@ 2023-01-21 14:12  Noah Misch <noah@leadboat.com>
  0 siblings, 0 replies; 6+ messages in thread

From: Noah Misch @ 2023-01-21 14:12 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject CancelRequestPacket having unexpected length.

When the length was too short, the server read outside the allocation.
That yielded the same log noise as sending the correct length with
(backendPID,cancelAuthCode) matching nothing.  Change to a message about
the unexpected length.  Given the attacker's lack of control over the
memory layout and the general lack of diversity in memory layouts at the
code in question, we doubt a would-be attacker could cause a segfault.
Hence, while the report arrived via security@postgresql.org, this is not
a vulnerability.  Back-patch to v11 (all supported versions).

Andrey Borodin, reviewed by Tom Lane.  Reported by Andrey Borodin.

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e75b5c85549df2294dfaee988be9c7b2a08f0b85

Modified Files
--------------
src/backend/postmaster/postmaster.c | 7 +++++++
1 file changed, 7 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Reject CancelRequestPacket having unexpected length.
@ 2023-01-21 14:12  Noah Misch <noah@leadboat.com>
  0 siblings, 0 replies; 6+ messages in thread

From: Noah Misch @ 2023-01-21 14:12 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject CancelRequestPacket having unexpected length.

When the length was too short, the server read outside the allocation.
That yielded the same log noise as sending the correct length with
(backendPID,cancelAuthCode) matching nothing.  Change to a message about
the unexpected length.  Given the attacker's lack of control over the
memory layout and the general lack of diversity in memory layouts at the
code in question, we doubt a would-be attacker could cause a segfault.
Hence, while the report arrived via security@postgresql.org, this is not
a vulnerability.  Back-patch to v11 (all supported versions).

Andrey Borodin, reviewed by Tom Lane.  Reported by Andrey Borodin.

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6900aea67e27990b72bc28b0b69096db9d226cba

Modified Files
--------------
src/backend/postmaster/postmaster.c | 7 +++++++
1 file changed, 7 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Reject CancelRequestPacket having unexpected length.
@ 2023-01-21 14:12  Noah Misch <noah@leadboat.com>
  0 siblings, 0 replies; 6+ messages in thread

From: Noah Misch @ 2023-01-21 14:12 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject CancelRequestPacket having unexpected length.

When the length was too short, the server read outside the allocation.
That yielded the same log noise as sending the correct length with
(backendPID,cancelAuthCode) matching nothing.  Change to a message about
the unexpected length.  Given the attacker's lack of control over the
memory layout and the general lack of diversity in memory layouts at the
code in question, we doubt a would-be attacker could cause a segfault.
Hence, while the report arrived via security@postgresql.org, this is not
a vulnerability.  Back-patch to v11 (all supported versions).

Andrey Borodin, reviewed by Tom Lane.  Reported by Andrey Borodin.

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a9bccffe5a39dab64ca597476563f8d965b46428

Modified Files
--------------
src/backend/postmaster/postmaster.c | 7 +++++++
1 file changed, 7 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Reject CancelRequestPacket having unexpected length.
@ 2023-01-21 14:12  Noah Misch <noah@leadboat.com>
  0 siblings, 0 replies; 6+ messages in thread

From: Noah Misch @ 2023-01-21 14:12 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject CancelRequestPacket having unexpected length.

When the length was too short, the server read outside the allocation.
That yielded the same log noise as sending the correct length with
(backendPID,cancelAuthCode) matching nothing.  Change to a message about
the unexpected length.  Given the attacker's lack of control over the
memory layout and the general lack of diversity in memory layouts at the
code in question, we doubt a would-be attacker could cause a segfault.
Hence, while the report arrived via security@postgresql.org, this is not
a vulnerability.  Back-patch to v11 (all supported versions).

Andrey Borodin, reviewed by Tom Lane.  Reported by Andrey Borodin.

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8f70de7e0106dc0df8b31994e2b3ad06691f5836

Modified Files
--------------
src/backend/postmaster/postmaster.c | 7 +++++++
1 file changed, 7 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Reject CancelRequestPacket having unexpected length.
@ 2023-01-21 14:12  Noah Misch <noah@leadboat.com>
  0 siblings, 0 replies; 6+ messages in thread

From: Noah Misch @ 2023-01-21 14:12 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Reject CancelRequestPacket having unexpected length.

When the length was too short, the server read outside the allocation.
That yielded the same log noise as sending the correct length with
(backendPID,cancelAuthCode) matching nothing.  Change to a message about
the unexpected length.  Given the attacker's lack of control over the
memory layout and the general lack of diversity in memory layouts at the
code in question, we doubt a would-be attacker could cause a segfault.
Hence, while the report arrived via security@postgresql.org, this is not
a vulnerability.  Back-patch to v11 (all supported versions).

Andrey Borodin, reviewed by Tom Lane.  Reported by Andrey Borodin.

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b152bb7b2724a7c62c2440c510af4926a996bbbc

Modified Files
--------------
src/backend/postmaster/postmaster.c | 7 +++++++
1 file changed, 7 insertions(+)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2023-01-21 14:12 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-01-21 14:12 pgsql: Reject CancelRequestPacket having unexpected length. Noah Misch <noah@leadboat.com>
2023-01-21 14:12 pgsql: Reject CancelRequestPacket having unexpected length. Noah Misch <noah@leadboat.com>
2023-01-21 14:12 pgsql: Reject CancelRequestPacket having unexpected length. Noah Misch <noah@leadboat.com>
2023-01-21 14:12 pgsql: Reject CancelRequestPacket having unexpected length. Noah Misch <noah@leadboat.com>
2023-01-21 14:12 pgsql: Reject CancelRequestPacket having unexpected length. Noah Misch <noah@leadboat.com>
2023-01-21 14:12 pgsql: Reject CancelRequestPacket having unexpected length. Noah Misch <noah@leadboat.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox