pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Remove special outfuncs/readfuncs handling of RangeVar.catalogna
2+ messages / 2 participants
[nested] [flat]

* pgsql: Remove special outfuncs/readfuncs handling of RangeVar.catalogna
@ 2023-01-23 18:33  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 2+ messages in thread

From: Tom Lane @ 2023-01-23 18:33 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove special outfuncs/readfuncs handling of RangeVar.catalogname.

Historically we skipped writing/reading this field, but that no
longer works under WRITE_READ_PARSE_PLAN_TREES since we expanded
the coverage of that option to include utility commands (787102b56).
Remove the special case and just treat this field normally.

Bump catversion out of an abundance of caution --- I do not think
we currently ever store RangeVar nodes in the catalogs, but
perhaps I'm wrong.

Per report from Pavel Stehule.

Discussion: https://postgr.es/m/CAFj8pRAYvYu-qU7-NieqRRyaQZk-yr3UjtHQ2LR62PS9M1dZMA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3cece34be842178a3c5697a58e03fb4a5d576378

Modified Files
--------------
src/include/catalog/catversion.h | 2 +-
src/include/nodes/primnodes.h    | 7 ++-----
2 files changed, 3 insertions(+), 6 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: pgsql: Remove special outfuncs/readfuncs handling of RangeVar.catalogna
@ 2023-01-23 19:32  Pavel Stehule <pavel.stehule@gmail.com>
  parent: Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 2+ messages in thread

From: Pavel Stehule @ 2023-01-23 19:32 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org

po 23. 1. 2023 v 19:33 odesílatel Tom Lane <tgl@sss.pgh.pa.us> napsal:

> Remove special outfuncs/readfuncs handling of RangeVar.catalogname.
>
> Historically we skipped writing/reading this field, but that no
> longer works under WRITE_READ_PARSE_PLAN_TREES since we expanded
> the coverage of that option to include utility commands (787102b56).
> Remove the special case and just treat this field normally.
>
> Bump catversion out of an abundance of caution --- I do not think
> we currently ever store RangeVar nodes in the catalogs, but
> perhaps I'm wrong.
>
> Per report from Pavel Stehule.
>

It helps

Thank you

Pavel


>
> Discussion:
> https://postgr.es/m/CAFj8pRAYvYu-qU7-NieqRRyaQZk-yr3UjtHQ2LR62PS9M1dZMA@mail.gmail.com
>
> Branch
> ------
> master
>
> Details
> -------
>
> https://git.postgresql.org/pg/commitdiff/3cece34be842178a3c5697a58e03fb4a5d576378
>
> Modified Files
> --------------
> src/include/catalog/catversion.h | 2 +-
> src/include/nodes/primnodes.h    | 7 ++-----
> 2 files changed, 3 insertions(+), 6 deletions(-)
>
>

^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2023-01-23 19:32 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-01-23 18:33 pgsql: Remove special outfuncs/readfuncs handling of RangeVar.catalogna Tom Lane <tgl@sss.pgh.pa.us>
2023-01-23 19:32 ` Pavel Stehule <pavel.stehule@gmail.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox