pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Add helper library for use of libpq inside the server environmen 4+ messages / 2 participants [nested] [flat]
* pgsql: Add helper library for use of libpq inside the server environmen @ 2023-01-24 03:27 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 4+ messages in thread From: Andres Freund @ 2023-01-24 03:27 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add helper library for use of libpq inside the server environment Currently dblink and postgres_fdw don't process interrupts during connection establishment. Besides preventing query cancellations etc, this can lead to undetected deadlocks, as global barriers are not processed. Libpqwalreceiver in contrast, processes interrupts during connection establishment. The required code is not trivial, so duplicating it into additional places does not seem like a good option. These aforementioned undetected deadlocks are the reason for the spate of CI test failures in the FreeBSD 'test_running' step. For now the helper library is just a header, as it needs to be linked into each extension using libpq, and it seems too small to be worth adding a dedicated static library for. The conversion to the helper are done in subsequent commits. Reviewed-by: Thomas Munro <thomas.munro@gmail.com> Discussion: https://postgr.es/m/20220925232237.p6uskba2dw6fnwj2@awork3.anarazel.de Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/28a591711d505f1f64c4f2eff5873ca2de0abede Modified Files -------------- src/include/libpq/libpq-be-fe-helpers.h | 242 ++++++++++++++++++++++++++++++++ 1 file changed, 242 insertions(+) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Add helper library for use of libpq inside the server environmen @ 2025-04-03 16:36 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 4+ messages in thread From: Noah Misch @ 2025-04-03 16:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add helper library for use of libpq inside the server environment Currently dblink and postgres_fdw don't process interrupts during connection establishment. Besides preventing query cancellations etc, this can lead to undetected deadlocks, as global barriers are not processed. Libpqwalreceiver in contrast, processes interrupts during connection establishment. The required code is not trivial, so duplicating it into additional places does not seem like a good option. These aforementioned undetected deadlocks are the reason for the spate of CI test failures in the FreeBSD 'test_running' step. For now the helper library is just a header, as it needs to be linked into each extension using libpq, and it seems too small to be worth adding a dedicated static library for. The conversion to the helper are done in subsequent commits. Reviewed-by: Thomas Munro <thomas.munro@gmail.com> Discussion: https://postgr.es/m/20220925232237.p6uskba2dw6fnwj2@awork3.anarazel.de Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9e129a2243e2c1e5b7107cec06262aad26533f0c Author: Andres Freund <andres@anarazel.de> Modified Files -------------- src/include/libpq/libpq-be-fe-helpers.h | 242 ++++++++++++++++++++++++++++++++ 1 file changed, 242 insertions(+) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Add helper library for use of libpq inside the server environmen @ 2025-04-03 16:36 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 4+ messages in thread From: Noah Misch @ 2025-04-03 16:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add helper library for use of libpq inside the server environment Currently dblink and postgres_fdw don't process interrupts during connection establishment. Besides preventing query cancellations etc, this can lead to undetected deadlocks, as global barriers are not processed. Libpqwalreceiver in contrast, processes interrupts during connection establishment. The required code is not trivial, so duplicating it into additional places does not seem like a good option. These aforementioned undetected deadlocks are the reason for the spate of CI test failures in the FreeBSD 'test_running' step. For now the helper library is just a header, as it needs to be linked into each extension using libpq, and it seems too small to be worth adding a dedicated static library for. The conversion to the helper are done in subsequent commits. Reviewed-by: Thomas Munro <thomas.munro@gmail.com> Discussion: https://postgr.es/m/20220925232237.p6uskba2dw6fnwj2@awork3.anarazel.de Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/aa435d7c42a09f7019805d1cf87eb64545efe1bc Author: Andres Freund <andres@anarazel.de> Modified Files -------------- src/include/libpq/libpq-be-fe-helpers.h | 242 ++++++++++++++++++++++++++++++++ 1 file changed, 242 insertions(+) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Add helper library for use of libpq inside the server environmen @ 2025-04-03 16:36 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 4+ messages in thread From: Noah Misch @ 2025-04-03 16:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add helper library for use of libpq inside the server environment Currently dblink and postgres_fdw don't process interrupts during connection establishment. Besides preventing query cancellations etc, this can lead to undetected deadlocks, as global barriers are not processed. Libpqwalreceiver in contrast, processes interrupts during connection establishment. The required code is not trivial, so duplicating it into additional places does not seem like a good option. These aforementioned undetected deadlocks are the reason for the spate of CI test failures in the FreeBSD 'test_running' step. For now the helper library is just a header, as it needs to be linked into each extension using libpq, and it seems too small to be worth adding a dedicated static library for. The conversion to the helper are done in subsequent commits. Reviewed-by: Thomas Munro <thomas.munro@gmail.com> Discussion: https://postgr.es/m/20220925232237.p6uskba2dw6fnwj2@awork3.anarazel.de Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5a3d5c0838bd9b8f7b71cb40af7ff8659f9f05ef Author: Andres Freund <andres@anarazel.de> Modified Files -------------- src/include/libpq/libpq-be-fe-helpers.h | 242 ++++++++++++++++++++++++++++++++ 1 file changed, 242 insertions(+) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-04-03 16:36 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-01-24 03:27 pgsql: Add helper library for use of libpq inside the server environmen Andres Freund <andres@anarazel.de> 2025-04-03 16:36 pgsql: Add helper library for use of libpq inside the server environmen Noah Misch <noah@leadboat.com> 2025-04-03 16:36 pgsql: Add helper library for use of libpq inside the server environmen Noah Misch <noah@leadboat.com> 2025-04-03 16:36 pgsql: Add helper library for use of libpq inside the server environmen Noah Misch <noah@leadboat.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox