pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Make int64_div_fast_to_numeric() more robust.
3+ messages / 1 participants
[nested] [flat]

* pgsql: Make int64_div_fast_to_numeric() more robust.
@ 2023-02-03 11:15  Dean Rasheed <dean.a.rasheed@gmail.com>
  0 siblings, 0 replies; 3+ messages in thread

From: Dean Rasheed @ 2023-02-03 11:15 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make int64_div_fast_to_numeric() more robust.

The prior coding of int64_div_fast_to_numeric() had a number of bugs
that would cause it to fail under different circumstances, such as
with log10val2 <= 0, or log10val2 a multiple of 4, or in the "slow"
numeric path with log10val2 >= 10.

None of those could be triggered by any of our current code, which
only uses log10val2 = 3 or 6. However, they made it a hazard for any
future code that might use it. Also, since this is exported by
numeric.c, users writing their own C code might choose to use it.

Therefore fix, and back-patch to v14, where it was introduced.

Dean Rasheed, reviewed by Tom Lane.

Discussion: https://postgr.es/m/CAEZATCW8gXgW0tgPxPgHDPhVX71%2BSWFRkhnXy%2BTfGDsKLepu2g%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b2d47928908d7a99b8e39198d0e8e9e0cb2b024b

Modified Files
--------------
src/backend/utils/adt/numeric.c | 73 ++++++++++++++++++++++++++---------------
1 file changed, 46 insertions(+), 27 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Make int64_div_fast_to_numeric() more robust.
@ 2023-02-03 11:15  Dean Rasheed <dean.a.rasheed@gmail.com>
  0 siblings, 0 replies; 3+ messages in thread

From: Dean Rasheed @ 2023-02-03 11:15 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make int64_div_fast_to_numeric() more robust.

The prior coding of int64_div_fast_to_numeric() had a number of bugs
that would cause it to fail under different circumstances, such as
with log10val2 <= 0, or log10val2 a multiple of 4, or in the "slow"
numeric path with log10val2 >= 10.

None of those could be triggered by any of our current code, which
only uses log10val2 = 3 or 6. However, they made it a hazard for any
future code that might use it. Also, since this is exported by
numeric.c, users writing their own C code might choose to use it.

Therefore fix, and back-patch to v14, where it was introduced.

Dean Rasheed, reviewed by Tom Lane.

Discussion: https://postgr.es/m/CAEZATCW8gXgW0tgPxPgHDPhVX71%2BSWFRkhnXy%2BTfGDsKLepu2g%40mail.gmail.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4f74741a5cea38228fdb0fb2967fa2137ea02cbf

Modified Files
--------------
src/backend/utils/adt/numeric.c | 80 +++++++++++++++++++++++++++--------------
1 file changed, 54 insertions(+), 26 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Make int64_div_fast_to_numeric() more robust.
@ 2023-02-03 11:15  Dean Rasheed <dean.a.rasheed@gmail.com>
  0 siblings, 0 replies; 3+ messages in thread

From: Dean Rasheed @ 2023-02-03 11:15 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make int64_div_fast_to_numeric() more robust.

The prior coding of int64_div_fast_to_numeric() had a number of bugs
that would cause it to fail under different circumstances, such as
with log10val2 <= 0, or log10val2 a multiple of 4, or in the "slow"
numeric path with log10val2 >= 10.

None of those could be triggered by any of our current code, which
only uses log10val2 = 3 or 6. However, they made it a hazard for any
future code that might use it. Also, since this is exported by
numeric.c, users writing their own C code might choose to use it.

Therefore fix, and back-patch to v14, where it was introduced.

Dean Rasheed, reviewed by Tom Lane.

Discussion: https://postgr.es/m/CAEZATCW8gXgW0tgPxPgHDPhVX71%2BSWFRkhnXy%2BTfGDsKLepu2g%40mail.gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/86bfbeab4f439ad527318d9edeb3c71ea46c1ab3

Modified Files
--------------
src/backend/utils/adt/numeric.c | 80 +++++++++++++++++++++++++++--------------
1 file changed, 54 insertions(+), 26 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2023-02-03 11:15 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-02-03 11:15 pgsql: Make int64_div_fast_to_numeric() more robust. Dean Rasheed <dean.a.rasheed@gmail.com>
2023-02-03 11:15 pgsql: Make int64_div_fast_to_numeric() more robust. Dean Rasheed <dean.a.rasheed@gmail.com>
2023-02-03 11:15 pgsql: Make int64_div_fast_to_numeric() more robust. Dean Rasheed <dean.a.rasheed@gmail.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox