pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Don't rely on uninitialized value in MERGE / DELETE
2+ messages / 1 participants
[nested] [flat]

* pgsql: Don't rely on uninitialized value in MERGE / DELETE
@ 2023-02-15 19:38  Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Alvaro Herrera @ 2023-02-15 19:38 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Don't rely on uninitialized value in MERGE / DELETE

On MERGE / WHEN MATCHED DELETE it's not possible to get cross-partition
updates, so we don't initialize cpUpdateRetrySlot; however, the code was
not careful to ignore the value in that case.  Make it do so.

Backpatch to 15.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Reviewed-by: Dean Rasheed <dean.a.rasheed@gmail.com>
Discussion: https://postgr.es/m/17792-0f89452029662c36@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fd923b5de94cdd3a7d05dcb843667dc228ea7fa3

Modified Files
--------------
src/backend/executor/nodeModifyTable.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Don't rely on uninitialized value in MERGE / DELETE
@ 2023-02-15 19:38  Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Alvaro Herrera @ 2023-02-15 19:38 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Don't rely on uninitialized value in MERGE / DELETE

On MERGE / WHEN MATCHED DELETE it's not possible to get cross-partition
updates, so we don't initialize cpUpdateRetrySlot; however, the code was
not careful to ignore the value in that case.  Make it do so.

Backpatch to 15.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Reviewed-by: Dean Rasheed <dean.a.rasheed@gmail.com>
Discussion: https://postgr.es/m/17792-0f89452029662c36@postgresql.org

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5d8ec1b9f625be800c8db93408e7c0553356fcd3

Modified Files
--------------
src/backend/executor/nodeModifyTable.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2023-02-15 19:38 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-02-15 19:38 pgsql: Don't rely on uninitialized value in MERGE / DELETE Alvaro Herrera <alvherre@alvh.no-ip.org>
2023-02-15 19:38 pgsql: Don't rely on uninitialized value in MERGE / DELETE Alvaro Herrera <alvherre@alvh.no-ip.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox