pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Print the correct aliases for DML target tables in ruleutils.
6+ messages / 1 participants
[nested] [flat]

* pgsql: Print the correct aliases for DML target tables in ruleutils.
@ 2023-02-17 21:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2023-02-17 21:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Print the correct aliases for DML target tables in ruleutils.

ruleutils.c blindly printed the user-given alias (or nothing if there
hadn't been one) for the target table of INSERT/UPDATE/DELETE queries.
That works a large percentage of the time, but not always: for queries
appearing in WITH, it's possible that we chose a different alias to
avoid conflict with outer-scope names.  Since the chosen alias would
be used in any Var references to the target table, this'd lead to an
inconsistent printout with consequences such as dump/restore failures.

The correct logic for printing (or not) a relation alias was embedded
in get_from_clause_item.  Factor it out to a separate function so that
we don't need a jointree node to use it.  (Only a limited part of that
function can be reached from these new call sites, but this seems like
the cleanest non-duplicative factorization.)

In passing, I got rid of a redundant "\d+ rules_src" step in rules.sql.

Initial report from Jonathan Katz; thanks to Vignesh C for analysis.
This has been broken for a long time, so back-patch to all supported
branches.

Discussion: https://postgr.es/m/e947fa21-24b2-f922-375a-d4f763ef3e4b@postgresql.org
Discussion: https://postgr.es/m/CALDaNm1MMntjmT_NJGp-Z=xbF02qHGAyuSHfYHias3TqQbPF2w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/393430f57544dfd550135e0191cc91139926b682

Modified Files
--------------
src/backend/utils/adt/ruleutils.c   | 154 ++++++++++++++++++++----------------
src/test/regress/expected/rules.out |  47 +++++++----
src/test/regress/sql/rules.sql      |  13 ++-
3 files changed, 130 insertions(+), 84 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Print the correct aliases for DML target tables in ruleutils.
@ 2023-02-17 21:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2023-02-17 21:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Print the correct aliases for DML target tables in ruleutils.

ruleutils.c blindly printed the user-given alias (or nothing if there
hadn't been one) for the target table of INSERT/UPDATE/DELETE queries.
That works a large percentage of the time, but not always: for queries
appearing in WITH, it's possible that we chose a different alias to
avoid conflict with outer-scope names.  Since the chosen alias would
be used in any Var references to the target table, this'd lead to an
inconsistent printout with consequences such as dump/restore failures.

The correct logic for printing (or not) a relation alias was embedded
in get_from_clause_item.  Factor it out to a separate function so that
we don't need a jointree node to use it.  (Only a limited part of that
function can be reached from these new call sites, but this seems like
the cleanest non-duplicative factorization.)

In passing, I got rid of a redundant "\d+ rules_src" step in rules.sql.

Initial report from Jonathan Katz; thanks to Vignesh C for analysis.
This has been broken for a long time, so back-patch to all supported
branches.

Discussion: https://postgr.es/m/e947fa21-24b2-f922-375a-d4f763ef3e4b@postgresql.org
Discussion: https://postgr.es/m/CALDaNm1MMntjmT_NJGp-Z=xbF02qHGAyuSHfYHias3TqQbPF2w@mail.gmail.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c8a5f1685fb75fd7641793cd1455fc74c576ed84

Modified Files
--------------
src/backend/utils/adt/ruleutils.c   | 146 +++++++++++++++++++++---------------
src/test/regress/expected/rules.out |  47 +++++++-----
src/test/regress/sql/rules.sql      |  13 +++-
3 files changed, 126 insertions(+), 80 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Print the correct aliases for DML target tables in ruleutils.
@ 2023-02-17 21:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2023-02-17 21:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Print the correct aliases for DML target tables in ruleutils.

ruleutils.c blindly printed the user-given alias (or nothing if there
hadn't been one) for the target table of INSERT/UPDATE/DELETE queries.
That works a large percentage of the time, but not always: for queries
appearing in WITH, it's possible that we chose a different alias to
avoid conflict with outer-scope names.  Since the chosen alias would
be used in any Var references to the target table, this'd lead to an
inconsistent printout with consequences such as dump/restore failures.

The correct logic for printing (or not) a relation alias was embedded
in get_from_clause_item.  Factor it out to a separate function so that
we don't need a jointree node to use it.  (Only a limited part of that
function can be reached from these new call sites, but this seems like
the cleanest non-duplicative factorization.)

In passing, I got rid of a redundant "\d+ rules_src" step in rules.sql.

Initial report from Jonathan Katz; thanks to Vignesh C for analysis.
This has been broken for a long time, so back-patch to all supported
branches.

Discussion: https://postgr.es/m/e947fa21-24b2-f922-375a-d4f763ef3e4b@postgresql.org
Discussion: https://postgr.es/m/CALDaNm1MMntjmT_NJGp-Z=xbF02qHGAyuSHfYHias3TqQbPF2w@mail.gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/14345f3c6a7bc967b168bb1ed40de369a8998941

Modified Files
--------------
src/backend/utils/adt/ruleutils.c   | 145 +++++++++++++++++++++---------------
src/test/regress/expected/rules.out |  47 +++++++-----
src/test/regress/sql/rules.sql      |  13 +++-
3 files changed, 126 insertions(+), 79 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Print the correct aliases for DML target tables in ruleutils.
@ 2023-02-17 21:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2023-02-17 21:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Print the correct aliases for DML target tables in ruleutils.

ruleutils.c blindly printed the user-given alias (or nothing if there
hadn't been one) for the target table of INSERT/UPDATE/DELETE queries.
That works a large percentage of the time, but not always: for queries
appearing in WITH, it's possible that we chose a different alias to
avoid conflict with outer-scope names.  Since the chosen alias would
be used in any Var references to the target table, this'd lead to an
inconsistent printout with consequences such as dump/restore failures.

The correct logic for printing (or not) a relation alias was embedded
in get_from_clause_item.  Factor it out to a separate function so that
we don't need a jointree node to use it.  (Only a limited part of that
function can be reached from these new call sites, but this seems like
the cleanest non-duplicative factorization.)

In passing, I got rid of a redundant "\d+ rules_src" step in rules.sql.

Initial report from Jonathan Katz; thanks to Vignesh C for analysis.
This has been broken for a long time, so back-patch to all supported
branches.

Discussion: https://postgr.es/m/e947fa21-24b2-f922-375a-d4f763ef3e4b@postgresql.org
Discussion: https://postgr.es/m/CALDaNm1MMntjmT_NJGp-Z=xbF02qHGAyuSHfYHias3TqQbPF2w@mail.gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4efb4f0d48787fbdf42c0b760f19c997664f0d56

Modified Files
--------------
src/backend/utils/adt/ruleutils.c   | 145 +++++++++++++++++++++---------------
src/test/regress/expected/rules.out |  47 +++++++-----
src/test/regress/sql/rules.sql      |  13 +++-
3 files changed, 126 insertions(+), 79 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Print the correct aliases for DML target tables in ruleutils.
@ 2023-02-17 21:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2023-02-17 21:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Print the correct aliases for DML target tables in ruleutils.

ruleutils.c blindly printed the user-given alias (or nothing if there
hadn't been one) for the target table of INSERT/UPDATE/DELETE queries.
That works a large percentage of the time, but not always: for queries
appearing in WITH, it's possible that we chose a different alias to
avoid conflict with outer-scope names.  Since the chosen alias would
be used in any Var references to the target table, this'd lead to an
inconsistent printout with consequences such as dump/restore failures.

The correct logic for printing (or not) a relation alias was embedded
in get_from_clause_item.  Factor it out to a separate function so that
we don't need a jointree node to use it.  (Only a limited part of that
function can be reached from these new call sites, but this seems like
the cleanest non-duplicative factorization.)

In passing, I got rid of a redundant "\d+ rules_src" step in rules.sql.

Initial report from Jonathan Katz; thanks to Vignesh C for analysis.
This has been broken for a long time, so back-patch to all supported
branches.

Discussion: https://postgr.es/m/e947fa21-24b2-f922-375a-d4f763ef3e4b@postgresql.org
Discussion: https://postgr.es/m/CALDaNm1MMntjmT_NJGp-Z=xbF02qHGAyuSHfYHias3TqQbPF2w@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3dd287c14facd5ee17e386175752a75ce16a1daa

Modified Files
--------------
src/backend/utils/adt/ruleutils.c   | 145 +++++++++++++++++++++---------------
src/test/regress/expected/rules.out |  47 +++++++-----
src/test/regress/sql/rules.sql      |  13 +++-
3 files changed, 126 insertions(+), 79 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Print the correct aliases for DML target tables in ruleutils.
@ 2023-02-17 21:41 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2023-02-17 21:41 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Print the correct aliases for DML target tables in ruleutils.

ruleutils.c blindly printed the user-given alias (or nothing if there
hadn't been one) for the target table of INSERT/UPDATE/DELETE queries.
That works a large percentage of the time, but not always: for queries
appearing in WITH, it's possible that we chose a different alias to
avoid conflict with outer-scope names.  Since the chosen alias would
be used in any Var references to the target table, this'd lead to an
inconsistent printout with consequences such as dump/restore failures.

The correct logic for printing (or not) a relation alias was embedded
in get_from_clause_item.  Factor it out to a separate function so that
we don't need a jointree node to use it.  (Only a limited part of that
function can be reached from these new call sites, but this seems like
the cleanest non-duplicative factorization.)

In passing, I got rid of a redundant "\d+ rules_src" step in rules.sql.

Initial report from Jonathan Katz; thanks to Vignesh C for analysis.
This has been broken for a long time, so back-patch to all supported
branches.

Discussion: https://postgr.es/m/e947fa21-24b2-f922-375a-d4f763ef3e4b@postgresql.org
Discussion: https://postgr.es/m/CALDaNm1MMntjmT_NJGp-Z=xbF02qHGAyuSHfYHias3TqQbPF2w@mail.gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/df931e9ab35bae8902035eac60e0edcbd8db8b3d

Modified Files
--------------
src/backend/utils/adt/ruleutils.c   | 145 +++++++++++++++++++++---------------
src/test/regress/expected/rules.out |  47 +++++++-----
src/test/regress/sql/rules.sql      |  13 +++-
3 files changed, 126 insertions(+), 79 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2023-02-17 21:41 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-02-17 21:41 pgsql: Print the correct aliases for DML target tables in ruleutils. Tom Lane <tgl@sss.pgh.pa.us>
2023-02-17 21:41 pgsql: Print the correct aliases for DML target tables in ruleutils. Tom Lane <tgl@sss.pgh.pa.us>
2023-02-17 21:41 pgsql: Print the correct aliases for DML target tables in ruleutils. Tom Lane <tgl@sss.pgh.pa.us>
2023-02-17 21:41 pgsql: Print the correct aliases for DML target tables in ruleutils. Tom Lane <tgl@sss.pgh.pa.us>
2023-02-17 21:41 pgsql: Print the correct aliases for DML target tables in ruleutils. Tom Lane <tgl@sss.pgh.pa.us>
2023-02-17 21:41 pgsql: Print the correct aliases for DML target tables in ruleutils. Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox