pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Limit memory usage of pg_walinspect functions. 2+ messages / 1 participants [nested] [flat]
* pgsql: Limit memory usage of pg_walinspect functions. @ 2023-02-20 19:29 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2023-02-20 19:29 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Limit memory usage of pg_walinspect functions. GetWALRecordsInfo() and pg_get_wal_fpi_info() can leak memory across WAL record iterations. Fix this by using a temporary memory context that's reset for each WAL record iteraion. Also a use temporary context for loops in GetXLogSummaryStats(). The number of iterations is a small constant, so the previous behavior was not a leak, but fix for clarity (but no need to backport). Backport GetWALRecordsInfo() change to version 15. pg_get_wal_fpi_info() didn't exist in version 15. Reported-by: Peter Geoghegan Author: Bharath Rupireddy Discussion: https://www.postgresql.org/message-id/CAH2-WznLEJjn7ghmKOABOEZYuJvkTk%3DGKU3m0%2B-XBAH%2BerPiJQ%40ma... Backpatch-through: 15 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/69e8c7cf1dfa08ae099c33d0d371ad69d405903d Modified Files -------------- contrib/pg_walinspect/pg_walinspect.c | 58 ++++++++++++++++++++++++++++++++--- 1 file changed, 53 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Limit memory usage of pg_walinspect functions. @ 2023-02-20 19:29 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2023-02-20 19:29 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Limit memory usage of pg_walinspect functions. GetWALRecordsInfo() and pg_get_wal_fpi_info() can leak memory across WAL record iterations. Fix this by using a temporary memory context that's reset for each WAL record iteraion. Also use a temporary context for loops in GetXLogSummaryStats(). The number of iterations is a small constant, so the previous behavior was not a leak, but fix for clarity (but no need to backport). Backport GetWALRecordsInfo() change to version 15. pg_get_wal_fpi_info() didn't exist in version 15. Reported-by: Peter Geoghegan Author: Bharath Rupireddy Discussion: https://www.postgresql.org/message-id/CAH2-WznLEJjn7ghmKOABOEZYuJvkTk%3DGKU3m0%2B-XBAH%2BerPiJQ%40ma... Backpatch-through: 15 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/da32a99df1f519622eee0d5c3ea61226468272a7 Modified Files -------------- contrib/pg_walinspect/pg_walinspect.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2023-02-20 19:29 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-02-20 19:29 pgsql: Limit memory usage of pg_walinspect functions. Jeff Davis <jdavis@postgresql.org> 2023-02-20 19:29 pgsql: Limit memory usage of pg_walinspect functions. Jeff Davis <jdavis@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox