pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Avoid failure when altering state of partitioned foreign-key tri 2+ messages / 1 participants [nested] [flat]
* pgsql: Avoid failure when altering state of partitioned foreign-key tri @ 2023-03-04 18:32 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2023-03-04 18:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid failure when altering state of partitioned foreign-key triggers. Beginning in v15, if you apply ALTER TABLE ENABLE/DISABLE TRIGGER to a partitioned table, it also affects the partitions' cloned versions of the affected trigger(s). The initial implementation of this located the clones by name, but that fails on foreign-key triggers which have names incorporating their own OIDs. We can fix that, and also make the behavior more bulletproof in the face of user-initiated trigger renames, by identifying the cloned triggers by tgparentid. Following the lead of earlier commits in this area, I took care not to break ABI in the v15 branch, even though I rather doubt there are any external callers of EnableDisableTrigger. While here, update the documentation, which was not touched when the semantics were changed. Per bug #17817 from Alan Hodgson. Back-patch to v15; older versions do not have this behavior. Discussion: https://postgr.es/m/17817-31dfb7c2100d9f3d@postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/6949b921d545809a83f8a6bad4948f9012a76fb6 Modified Files -------------- doc/src/sgml/ref/alter_table.sgml | 23 ++++++++++++++++------- src/backend/commands/tablecmds.c | 3 ++- src/backend/commands/trigger.c | 11 ++++++++--- src/include/commands/trigger.h | 2 +- src/test/regress/expected/triggers.out | 34 ++++++++++++++++++++++++++++++++++ src/test/regress/sql/triggers.sql | 15 +++++++++++++++ 6 files changed, 76 insertions(+), 12 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Avoid failure when altering state of partitioned foreign-key tri @ 2023-03-04 18:32 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2023-03-04 18:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid failure when altering state of partitioned foreign-key triggers. Beginning in v15, if you apply ALTER TABLE ENABLE/DISABLE TRIGGER to a partitioned table, it also affects the partitions' cloned versions of the affected trigger(s). The initial implementation of this located the clones by name, but that fails on foreign-key triggers which have names incorporating their own OIDs. We can fix that, and also make the behavior more bulletproof in the face of user-initiated trigger renames, by identifying the cloned triggers by tgparentid. Following the lead of earlier commits in this area, I took care not to break ABI in the v15 branch, even though I rather doubt there are any external callers of EnableDisableTrigger. While here, update the documentation, which was not touched when the semantics were changed. Per bug #17817 from Alan Hodgson. Back-patch to v15; older versions do not have this behavior. Discussion: https://postgr.es/m/17817-31dfb7c2100d9f3d@postgresql.org Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f61e60102f08305f3cb9e55a7958b8036a02fe39 Modified Files -------------- doc/src/sgml/ref/alter_table.sgml | 23 +++++++++++++------- src/backend/commands/tablecmds.c | 5 +++-- src/backend/commands/trigger.c | 38 ++++++++++++++++++++++++---------- src/include/commands/trigger.h | 3 +++ src/test/regress/expected/triggers.out | 34 ++++++++++++++++++++++++++++++ src/test/regress/sql/triggers.sql | 15 ++++++++++++++ 6 files changed, 98 insertions(+), 20 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2023-03-04 18:32 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-03-04 18:32 pgsql: Avoid failure when altering state of partitioned foreign-key tri Tom Lane <tgl@sss.pgh.pa.us> 2023-03-04 18:32 pgsql: Avoid failure when altering state of partitioned foreign-key tri Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox