pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix t_isspace(), etc., when datlocprovider=i and datctype=C. 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix t_isspace(), etc., when datlocprovider=i and datctype=C. @ 2023-03-17 19:11 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2023-03-17 19:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix t_isspace(), etc., when datlocprovider=i and datctype=C. Check whether the datctype is C to determine whether t_isspace() and related functions use isspace() or iswspace(). Previously, t_isspace() checked whether the database default collation was C; which is incorrect when the default collation uses the ICU provider. Discussion: https://postgr.es/m/79e4354d9eccfdb00483146a6b9f6295202e7890.camel@j-davis.com Reviewed-by: Peter Eisentraut Backpatch-through: 15 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/f413941f41d370a7893caa3e6ed384b89a0577fd Modified Files -------------- contrib/unaccent/expected/unaccent.out | 9 --------- contrib/unaccent/expected/unaccent_1.out | 8 -------- contrib/unaccent/sql/unaccent.sql | 11 ----------- src/backend/tsearch/ts_locale.c | 18 ++++++------------ src/backend/tsearch/wparser_def.c | 3 +-- src/backend/utils/adt/pg_locale.c | 3 +++ src/backend/utils/init/postinit.c | 4 ++++ src/include/utils/pg_locale.h | 2 ++ 8 files changed, 16 insertions(+), 42 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix t_isspace(), etc., when datlocprovider=i and datctype=C. @ 2023-03-17 19:15 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2023-03-17 19:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix t_isspace(), etc., when datlocprovider=i and datctype=C. Check whether the datctype is C to determine whether t_isspace() and related functions use isspace() or iswspace(). Previously, t_isspace() checked whether the database default collation was C; which is incorrect when the default collation uses the ICU provider. Discussion: https://postgr.es/m/79e4354d9eccfdb00483146a6b9f6295202e7890.camel@j-davis.com Reviewed-by: Peter Eisentraut Backpatch-through: 15 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8b87e92919cd0e8e8ffbae543d996063149c3ccc Modified Files -------------- src/backend/tsearch/ts_locale.c | 15 +++++---------- src/backend/tsearch/wparser_def.c | 3 +-- src/backend/utils/adt/pg_locale.c | 3 +++ src/backend/utils/init/postinit.c | 4 ++++ src/include/utils/pg_locale.h | 2 ++ 5 files changed, 15 insertions(+), 12 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2023-03-17 19:15 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-03-17 19:11 pgsql: Fix t_isspace(), etc., when datlocprovider=i and datctype=C. Jeff Davis <jdavis@postgresql.org> 2023-03-17 19:15 pgsql: Fix t_isspace(), etc., when datlocprovider=i and datctype=C. Jeff Davis <jdavis@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox