pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Ensure acquire_inherited_sample_rows sets its output parameters. 6+ messages / 1 participants [nested] [flat]
* pgsql: Ensure acquire_inherited_sample_rows sets its output parameters. @ 2023-03-31 14:08 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2023-03-31 14:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Ensure acquire_inherited_sample_rows sets its output parameters. The totalrows/totaldeadrows outputs were left uninitialized in cases where we find no analyzable child tables of a partitioned table. This could lead to setting the partitioned table's pg_class.reltuples value to garbage. It's not clear that that would have any very bad effects in practice, but fix it anyway because it's making valgrind unhappy. Reported and diagnosed by Alexander Lakhin (bug #17880). Discussion: https://postgr.es/m/17880-9282037c923d856e@postgresql.org Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e46a309bd8b257642ebe406188e79cce22db43f7 Modified Files -------------- src/backend/commands/analyze.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Ensure acquire_inherited_sample_rows sets its output parameters. @ 2023-03-31 14:08 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2023-03-31 14:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Ensure acquire_inherited_sample_rows sets its output parameters. The totalrows/totaldeadrows outputs were left uninitialized in cases where we find no analyzable child tables of a partitioned table. This could lead to setting the partitioned table's pg_class.reltuples value to garbage. It's not clear that that would have any very bad effects in practice, but fix it anyway because it's making valgrind unhappy. Reported and diagnosed by Alexander Lakhin (bug #17880). Discussion: https://postgr.es/m/17880-9282037c923d856e@postgresql.org Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d0d92fe3d49934042f64539ccf2bb33c5f82158a Modified Files -------------- src/backend/commands/analyze.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Ensure acquire_inherited_sample_rows sets its output parameters. @ 2023-03-31 14:08 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2023-03-31 14:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Ensure acquire_inherited_sample_rows sets its output parameters. The totalrows/totaldeadrows outputs were left uninitialized in cases where we find no analyzable child tables of a partitioned table. This could lead to setting the partitioned table's pg_class.reltuples value to garbage. It's not clear that that would have any very bad effects in practice, but fix it anyway because it's making valgrind unhappy. Reported and diagnosed by Alexander Lakhin (bug #17880). Discussion: https://postgr.es/m/17880-9282037c923d856e@postgresql.org Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6f7ca625b9d3f6298a3e1ecd0187d123c25316a4 Modified Files -------------- src/backend/commands/analyze.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Ensure acquire_inherited_sample_rows sets its output parameters. @ 2023-03-31 14:08 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2023-03-31 14:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Ensure acquire_inherited_sample_rows sets its output parameters. The totalrows/totaldeadrows outputs were left uninitialized in cases where we find no analyzable child tables of a partitioned table. This could lead to setting the partitioned table's pg_class.reltuples value to garbage. It's not clear that that would have any very bad effects in practice, but fix it anyway because it's making valgrind unhappy. Reported and diagnosed by Alexander Lakhin (bug #17880). Discussion: https://postgr.es/m/17880-9282037c923d856e@postgresql.org Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2dcd92e97dfa8c5808bcb6ee0f21327a052eac96 Modified Files -------------- src/backend/commands/analyze.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Ensure acquire_inherited_sample_rows sets its output parameters. @ 2023-03-31 14:08 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2023-03-31 14:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Ensure acquire_inherited_sample_rows sets its output parameters. The totalrows/totaldeadrows outputs were left uninitialized in cases where we find no analyzable child tables of a partitioned table. This could lead to setting the partitioned table's pg_class.reltuples value to garbage. It's not clear that that would have any very bad effects in practice, but fix it anyway because it's making valgrind unhappy. Reported and diagnosed by Alexander Lakhin (bug #17880). Discussion: https://postgr.es/m/17880-9282037c923d856e@postgresql.org Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/65266d90f85cb819711d91172c4600feeb3f19f5 Modified Files -------------- src/backend/commands/analyze.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Ensure acquire_inherited_sample_rows sets its output parameters. @ 2023-03-31 14:08 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2023-03-31 14:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Ensure acquire_inherited_sample_rows sets its output parameters. The totalrows/totaldeadrows outputs were left uninitialized in cases where we find no analyzable child tables of a partitioned table. This could lead to setting the partitioned table's pg_class.reltuples value to garbage. It's not clear that that would have any very bad effects in practice, but fix it anyway because it's making valgrind unhappy. Reported and diagnosed by Alexander Lakhin (bug #17880). Discussion: https://postgr.es/m/17880-9282037c923d856e@postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/c2d7d679c1220af77023413b031902afe4d2fdd1 Modified Files -------------- src/backend/commands/analyze.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2023-03-31 14:08 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-03-31 14:08 pgsql: Ensure acquire_inherited_sample_rows sets its output parameters. Tom Lane <tgl@sss.pgh.pa.us> 2023-03-31 14:08 pgsql: Ensure acquire_inherited_sample_rows sets its output parameters. Tom Lane <tgl@sss.pgh.pa.us> 2023-03-31 14:08 pgsql: Ensure acquire_inherited_sample_rows sets its output parameters. Tom Lane <tgl@sss.pgh.pa.us> 2023-03-31 14:08 pgsql: Ensure acquire_inherited_sample_rows sets its output parameters. Tom Lane <tgl@sss.pgh.pa.us> 2023-03-31 14:08 pgsql: Ensure acquire_inherited_sample_rows sets its output parameters. Tom Lane <tgl@sss.pgh.pa.us> 2023-03-31 14:08 pgsql: Ensure acquire_inherited_sample_rows sets its output parameters. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox