pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Move return statements out of PG_TRY blocks.
6+ messages / 1 participants
[nested] [flat]

* pgsql: Move return statements out of PG_TRY blocks.
@ 2023-05-04 23:27 Nathan Bossart <nathan@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Nathan Bossart @ 2023-05-04 23:27 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Move return statements out of PG_TRY blocks.

If we exit a PG_TRY block early via "continue", "break", "goto", or
"return", we'll skip unwinding its exception stack.  This change
moves a couple of such "return" statements in PL/Python out of
PG_TRY blocks.  This was introduced in d0aa965c0a and affects all
supported versions.

We might also be able to add compile-time checks to prevent
recurrence, but that is left as a future exercise.

Reported-by: Mikhail Gribkov, Xing Guo
Author: Xing Guo
Reviewed-by: Michael Paquier, Andres Freund, Tom Lane
Discussion: https://postgr.es/m/CAMEv5_v5Y%2B-D%3DCO1%2Bqoe16sAmgC4sbbQjz%2BUtcHmB6zcgS%2B5Ew%40mail.gmail.com
Discussion: https://postgr.es/m/CACpMh%2BCMsGMRKFzFMm3bYTzQmMU5nfEEoEDU2apJcc4hid36AQ%40mail.gmail.com
Backpatch-through: 11 (all supported versions)

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/57d0051706b897048063acc14c2c3454200c488f

Modified Files
--------------
src/pl/plpython/plpy_exec.c | 54 ++++++++++++++++++++++++++++++---------------
1 file changed, 36 insertions(+), 18 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Move return statements out of PG_TRY blocks.
@ 2023-05-04 23:27 Nathan Bossart <nathan@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Nathan Bossart @ 2023-05-04 23:27 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Move return statements out of PG_TRY blocks.

If we exit a PG_TRY block early via "continue", "break", "goto", or
"return", we'll skip unwinding its exception stack.  This change
moves a couple of such "return" statements in PL/Python out of
PG_TRY blocks.  This was introduced in d0aa965c0a and affects all
supported versions.

We might also be able to add compile-time checks to prevent
recurrence, but that is left as a future exercise.

Reported-by: Mikhail Gribkov, Xing Guo
Author: Xing Guo
Reviewed-by: Michael Paquier, Andres Freund, Tom Lane
Discussion: https://postgr.es/m/CAMEv5_v5Y%2B-D%3DCO1%2Bqoe16sAmgC4sbbQjz%2BUtcHmB6zcgS%2B5Ew%40mail.gmail.com
Discussion: https://postgr.es/m/CACpMh%2BCMsGMRKFzFMm3bYTzQmMU5nfEEoEDU2apJcc4hid36AQ%40mail.gmail.com
Backpatch-through: 11 (all supported versions)

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/825ebc9848fdf9f229ba05a9aec3f58d13b17fd4

Modified Files
--------------
src/pl/plpython/plpy_exec.c | 54 ++++++++++++++++++++++++++++++---------------
1 file changed, 36 insertions(+), 18 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Move return statements out of PG_TRY blocks.
@ 2023-05-04 23:27 Nathan Bossart <nathan@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Nathan Bossart @ 2023-05-04 23:27 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Move return statements out of PG_TRY blocks.

If we exit a PG_TRY block early via "continue", "break", "goto", or
"return", we'll skip unwinding its exception stack.  This change
moves a couple of such "return" statements in PL/Python out of
PG_TRY blocks.  This was introduced in d0aa965c0a and affects all
supported versions.

We might also be able to add compile-time checks to prevent
recurrence, but that is left as a future exercise.

Reported-by: Mikhail Gribkov, Xing Guo
Author: Xing Guo
Reviewed-by: Michael Paquier, Andres Freund, Tom Lane
Discussion: https://postgr.es/m/CAMEv5_v5Y%2B-D%3DCO1%2Bqoe16sAmgC4sbbQjz%2BUtcHmB6zcgS%2B5Ew%40mail.gmail.com
Discussion: https://postgr.es/m/CACpMh%2BCMsGMRKFzFMm3bYTzQmMU5nfEEoEDU2apJcc4hid36AQ%40mail.gmail.com
Backpatch-through: 11 (all supported versions)

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/52c9cf3239b85f272d928db178d44947c9173d76

Modified Files
--------------
src/pl/plpython/plpy_exec.c | 54 ++++++++++++++++++++++++++++++---------------
1 file changed, 36 insertions(+), 18 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Move return statements out of PG_TRY blocks.
@ 2023-05-04 23:27 Nathan Bossart <nathan@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Nathan Bossart @ 2023-05-04 23:27 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Move return statements out of PG_TRY blocks.

If we exit a PG_TRY block early via "continue", "break", "goto", or
"return", we'll skip unwinding its exception stack.  This change
moves a couple of such "return" statements in PL/Python out of
PG_TRY blocks.  This was introduced in d0aa965c0a and affects all
supported versions.

We might also be able to add compile-time checks to prevent
recurrence, but that is left as a future exercise.

Reported-by: Mikhail Gribkov, Xing Guo
Author: Xing Guo
Reviewed-by: Michael Paquier, Andres Freund, Tom Lane
Discussion: https://postgr.es/m/CAMEv5_v5Y%2B-D%3DCO1%2Bqoe16sAmgC4sbbQjz%2BUtcHmB6zcgS%2B5Ew%40mail.gmail.com
Discussion: https://postgr.es/m/CACpMh%2BCMsGMRKFzFMm3bYTzQmMU5nfEEoEDU2apJcc4hid36AQ%40mail.gmail.com
Backpatch-through: 11 (all supported versions)

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/800531846ef7da5f4a234fbb6fd65a91c7ecb33f

Modified Files
--------------
src/pl/plpython/plpy_exec.c | 54 ++++++++++++++++++++++++++++++---------------
1 file changed, 36 insertions(+), 18 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Move return statements out of PG_TRY blocks.
@ 2023-05-04 23:27 Nathan Bossart <nathan@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Nathan Bossart @ 2023-05-04 23:27 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Move return statements out of PG_TRY blocks.

If we exit a PG_TRY block early via "continue", "break", "goto", or
"return", we'll skip unwinding its exception stack.  This change
moves a couple of such "return" statements in PL/Python out of
PG_TRY blocks.  This was introduced in d0aa965c0a and affects all
supported versions.

We might also be able to add compile-time checks to prevent
recurrence, but that is left as a future exercise.

Reported-by: Mikhail Gribkov, Xing Guo
Author: Xing Guo
Reviewed-by: Michael Paquier, Andres Freund, Tom Lane
Discussion: https://postgr.es/m/CAMEv5_v5Y%2B-D%3DCO1%2Bqoe16sAmgC4sbbQjz%2BUtcHmB6zcgS%2B5Ew%40mail.gmail.com
Discussion: https://postgr.es/m/CACpMh%2BCMsGMRKFzFMm3bYTzQmMU5nfEEoEDU2apJcc4hid36AQ%40mail.gmail.com
Backpatch-through: 11 (all supported versions)

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/24964394a972d0e7b030bf02a600bceea0be72d3

Modified Files
--------------
src/pl/plpython/plpy_exec.c | 54 ++++++++++++++++++++++++++++++---------------
1 file changed, 36 insertions(+), 18 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Move return statements out of PG_TRY blocks.
@ 2023-05-04 23:27 Nathan Bossart <nathan@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: Nathan Bossart @ 2023-05-04 23:27 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Move return statements out of PG_TRY blocks.

If we exit a PG_TRY block early via "continue", "break", "goto", or
"return", we'll skip unwinding its exception stack.  This change
moves a couple of such "return" statements in PL/Python out of
PG_TRY blocks.  This was introduced in d0aa965c0a and affects all
supported versions.

We might also be able to add compile-time checks to prevent
recurrence, but that is left as a future exercise.

Reported-by: Mikhail Gribkov, Xing Guo
Author: Xing Guo
Reviewed-by: Michael Paquier, Andres Freund, Tom Lane
Discussion: https://postgr.es/m/CAMEv5_v5Y%2B-D%3DCO1%2Bqoe16sAmgC4sbbQjz%2BUtcHmB6zcgS%2B5Ew%40mail.gmail.com
Discussion: https://postgr.es/m/CACpMh%2BCMsGMRKFzFMm3bYTzQmMU5nfEEoEDU2apJcc4hid36AQ%40mail.gmail.com
Backpatch-through: 11 (all supported versions)

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0af386b0f4b81393aa7b1fe2118bd31ef06ef64c

Modified Files
--------------
src/pl/plpython/plpy_exec.c | 54 ++++++++++++++++++++++++++++++---------------
1 file changed, 36 insertions(+), 18 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2023-05-04 23:27 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-05-04 23:27 pgsql: Move return statements out of PG_TRY blocks. Nathan Bossart <nathan@postgresql.org>
2023-05-04 23:27 pgsql: Move return statements out of PG_TRY blocks. Nathan Bossart <nathan@postgresql.org>
2023-05-04 23:27 pgsql: Move return statements out of PG_TRY blocks. Nathan Bossart <nathan@postgresql.org>
2023-05-04 23:27 pgsql: Move return statements out of PG_TRY blocks. Nathan Bossart <nathan@postgresql.org>
2023-05-04 23:27 pgsql: Move return statements out of PG_TRY blocks. Nathan Bossart <nathan@postgresql.org>
2023-05-04 23:27 pgsql: Move return statements out of PG_TRY blocks. Nathan Bossart <nathan@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox