pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Replace last PushOverrideSearchPath() call with set_config_optio
6+ messages / 1 participants
[nested] [flat]

* pgsql: Replace last PushOverrideSearchPath() call with set_config_optio
@ 2023-05-08 13:17 Noah Misch <noah@leadboat.com>
  0 siblings, 0 replies; 6+ messages in thread

From: Noah Misch @ 2023-05-08 13:17 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Replace last PushOverrideSearchPath() call with set_config_option().

The two methods don't cooperate, so set_config_option("search_path",
...) has been ineffective under non-empty overrideStack.  This defect
enabled an attacker having database-level CREATE privilege to execute
arbitrary code as the bootstrap superuser.  While that particular attack
requires v13+ for the trusted extension attribute, other attacks are
feasible in all supported versions.

Standardize on the combination of NewGUCNestLevel() and
set_config_option("search_path", ...).  It is newer than
PushOverrideSearchPath(), more-prevalent, and has no known
disadvantages.  The "override" mechanism remains for now, for
compatibility with out-of-tree code.  Users should update such code,
which likely suffers from the same sort of vulnerability closed here.
Back-patch to v11 (all supported versions).

Alexander Lakhin.  Reported by Alexander Lakhin.

Security: CVE-2023-2454

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/681d9e4621aac0a9c71364b6f54f00f6d8c4337f

Modified Files
--------------
contrib/seg/Makefile                    |  2 +-
contrib/seg/expected/security.out       | 32 +++++++++++++++++++++++
contrib/seg/sql/security.sql            | 32 +++++++++++++++++++++++
src/backend/catalog/namespace.c         |  4 +++
src/backend/commands/schemacmds.c       | 37 +++++++++++++++++++--------
src/test/regress/expected/namespace.out | 45 +++++++++++++++++++++++++++++++++
src/test/regress/sql/namespace.sql      | 24 ++++++++++++++++++
7 files changed, 165 insertions(+), 11 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Replace last PushOverrideSearchPath() call with set_config_optio
@ 2023-05-08 13:17 Noah Misch <noah@leadboat.com>
  0 siblings, 0 replies; 6+ messages in thread

From: Noah Misch @ 2023-05-08 13:17 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Replace last PushOverrideSearchPath() call with set_config_option().

The two methods don't cooperate, so set_config_option("search_path",
...) has been ineffective under non-empty overrideStack.  This defect
enabled an attacker having database-level CREATE privilege to execute
arbitrary code as the bootstrap superuser.  While that particular attack
requires v13+ for the trusted extension attribute, other attacks are
feasible in all supported versions.

Standardize on the combination of NewGUCNestLevel() and
set_config_option("search_path", ...).  It is newer than
PushOverrideSearchPath(), more-prevalent, and has no known
disadvantages.  The "override" mechanism remains for now, for
compatibility with out-of-tree code.  Users should update such code,
which likely suffers from the same sort of vulnerability closed here.
Back-patch to v11 (all supported versions).

Alexander Lakhin.  Reported by Alexander Lakhin.

Security: CVE-2023-2454

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/dbd5795e7539ec9e15c0d4ed2d05b1b18d2a3b09

Modified Files
--------------
contrib/seg/Makefile                    |  2 +-
contrib/seg/expected/security.out       | 32 +++++++++++++++++++++++
contrib/seg/sql/security.sql            | 32 +++++++++++++++++++++++
src/backend/catalog/namespace.c         |  4 +++
src/backend/commands/schemacmds.c       | 37 +++++++++++++++++++--------
src/test/regress/expected/namespace.out | 45 +++++++++++++++++++++++++++++++++
src/test/regress/sql/namespace.sql      | 24 ++++++++++++++++++
7 files changed, 165 insertions(+), 11 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Replace last PushOverrideSearchPath() call with set_config_optio
@ 2023-05-08 13:17 Noah Misch <noah@leadboat.com>
  0 siblings, 0 replies; 6+ messages in thread

From: Noah Misch @ 2023-05-08 13:17 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Replace last PushOverrideSearchPath() call with set_config_option().

The two methods don't cooperate, so set_config_option("search_path",
...) has been ineffective under non-empty overrideStack.  This defect
enabled an attacker having database-level CREATE privilege to execute
arbitrary code as the bootstrap superuser.  While that particular attack
requires v13+ for the trusted extension attribute, other attacks are
feasible in all supported versions.

Standardize on the combination of NewGUCNestLevel() and
set_config_option("search_path", ...).  It is newer than
PushOverrideSearchPath(), more-prevalent, and has no known
disadvantages.  The "override" mechanism remains for now, for
compatibility with out-of-tree code.  Users should update such code,
which likely suffers from the same sort of vulnerability closed here.
Back-patch to v11 (all supported versions).

Alexander Lakhin.  Reported by Alexander Lakhin.

Security: CVE-2023-2454

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/01e8182c73b24ec45849e369ad8b3ecd4ed1ba2b

Modified Files
--------------
contrib/seg/Makefile                    |  2 +-
contrib/seg/expected/security.out       | 32 +++++++++++++++++++++++
contrib/seg/sql/security.sql            | 32 +++++++++++++++++++++++
src/backend/catalog/namespace.c         |  4 +++
src/backend/commands/schemacmds.c       | 37 +++++++++++++++++++--------
src/test/regress/expected/namespace.out | 45 +++++++++++++++++++++++++++++++++
src/test/regress/sql/namespace.sql      | 24 ++++++++++++++++++
7 files changed, 165 insertions(+), 11 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Replace last PushOverrideSearchPath() call with set_config_optio
@ 2023-05-08 13:17 Noah Misch <noah@leadboat.com>
  0 siblings, 0 replies; 6+ messages in thread

From: Noah Misch @ 2023-05-08 13:17 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Replace last PushOverrideSearchPath() call with set_config_option().

The two methods don't cooperate, so set_config_option("search_path",
...) has been ineffective under non-empty overrideStack.  This defect
enabled an attacker having database-level CREATE privilege to execute
arbitrary code as the bootstrap superuser.  While that particular attack
requires v13+ for the trusted extension attribute, other attacks are
feasible in all supported versions.

Standardize on the combination of NewGUCNestLevel() and
set_config_option("search_path", ...).  It is newer than
PushOverrideSearchPath(), more-prevalent, and has no known
disadvantages.  The "override" mechanism remains for now, for
compatibility with out-of-tree code.  Users should update such code,
which likely suffers from the same sort of vulnerability closed here.
Back-patch to v11 (all supported versions).

Alexander Lakhin.  Reported by Alexander Lakhin.

Security: CVE-2023-2454

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2212f7db80e9397825dea5f4947397665a7f60b8

Modified Files
--------------
contrib/seg/Makefile                    |  2 +-
contrib/seg/expected/security.out       | 32 +++++++++++++++++++++++
contrib/seg/sql/security.sql            | 32 +++++++++++++++++++++++
src/backend/catalog/namespace.c         |  4 +++
src/backend/commands/schemacmds.c       | 37 +++++++++++++++++++--------
src/test/regress/expected/namespace.out | 45 +++++++++++++++++++++++++++++++++
src/test/regress/sql/namespace.sql      | 24 ++++++++++++++++++
7 files changed, 165 insertions(+), 11 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Replace last PushOverrideSearchPath() call with set_config_optio
@ 2023-05-08 13:17 Noah Misch <noah@leadboat.com>
  0 siblings, 0 replies; 6+ messages in thread

From: Noah Misch @ 2023-05-08 13:17 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Replace last PushOverrideSearchPath() call with set_config_option().

The two methods don't cooperate, so set_config_option("search_path",
...) has been ineffective under non-empty overrideStack.  This defect
enabled an attacker having database-level CREATE privilege to execute
arbitrary code as the bootstrap superuser.  While that particular attack
requires v13+ for the trusted extension attribute, other attacks are
feasible in all supported versions.

Standardize on the combination of NewGUCNestLevel() and
set_config_option("search_path", ...).  It is newer than
PushOverrideSearchPath(), more-prevalent, and has no known
disadvantages.  The "override" mechanism remains for now, for
compatibility with out-of-tree code.  Users should update such code,
which likely suffers from the same sort of vulnerability closed here.
Back-patch to v11 (all supported versions).

Alexander Lakhin.  Reported by Alexander Lakhin.

Security: CVE-2023-2454

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/78119a0bf98edb13e7f79c6402378376cc6b6ca4

Modified Files
--------------
src/backend/catalog/namespace.c         |  4 +++
src/backend/commands/schemacmds.c       | 37 +++++++++++++++++++--------
src/test/regress/expected/namespace.out | 45 +++++++++++++++++++++++++++++++++
src/test/regress/sql/namespace.sql      | 24 ++++++++++++++++++
4 files changed, 100 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Replace last PushOverrideSearchPath() call with set_config_optio
@ 2023-05-08 13:17 Noah Misch <noah@leadboat.com>
  0 siblings, 0 replies; 6+ messages in thread

From: Noah Misch @ 2023-05-08 13:17 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Replace last PushOverrideSearchPath() call with set_config_option().

The two methods don't cooperate, so set_config_option("search_path",
...) has been ineffective under non-empty overrideStack.  This defect
enabled an attacker having database-level CREATE privilege to execute
arbitrary code as the bootstrap superuser.  While that particular attack
requires v13+ for the trusted extension attribute, other attacks are
feasible in all supported versions.

Standardize on the combination of NewGUCNestLevel() and
set_config_option("search_path", ...).  It is newer than
PushOverrideSearchPath(), more-prevalent, and has no known
disadvantages.  The "override" mechanism remains for now, for
compatibility with out-of-tree code.  Users should update such code,
which likely suffers from the same sort of vulnerability closed here.
Back-patch to v11 (all supported versions).

Alexander Lakhin.  Reported by Alexander Lakhin.

Security: CVE-2023-2454

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/23cb8eaeb97df350273cb8902e55842a955339c8

Modified Files
--------------
src/backend/catalog/namespace.c         |  4 +++
src/backend/commands/schemacmds.c       | 37 +++++++++++++++++++--------
src/test/regress/expected/namespace.out | 45 +++++++++++++++++++++++++++++++++
src/test/regress/sql/namespace.sql      | 24 ++++++++++++++++++
4 files changed, 100 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2023-05-08 13:17 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-05-08 13:17 pgsql: Replace last PushOverrideSearchPath() call with set_config_optio Noah Misch <noah@leadboat.com>
2023-05-08 13:17 pgsql: Replace last PushOverrideSearchPath() call with set_config_optio Noah Misch <noah@leadboat.com>
2023-05-08 13:17 pgsql: Replace last PushOverrideSearchPath() call with set_config_optio Noah Misch <noah@leadboat.com>
2023-05-08 13:17 pgsql: Replace last PushOverrideSearchPath() call with set_config_optio Noah Misch <noah@leadboat.com>
2023-05-08 13:17 pgsql: Replace last PushOverrideSearchPath() call with set_config_optio Noah Misch <noah@leadboat.com>
2023-05-08 13:17 pgsql: Replace last PushOverrideSearchPath() call with set_config_optio Noah Misch <noah@leadboat.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox