pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Refactor log check logic for connect_ok/fails in PostgreSQL::Tes 3+ messages / 1 participants [nested] [flat]
* pgsql: Refactor log check logic for connect_ok/fails in PostgreSQL::Tes @ 2023-06-09 00:38 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2023-06-09 00:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Refactor log check logic for connect_ok/fails in PostgreSQL::Test::Cluster This commit refactors a bit the code in charge of checking for log patterns when connections fail or succeed, by moving the log pattern checks into their own routine, for clarity. This has come up as something to improve while discussing the refactoring of find_in_log(). Backpatch down to 14 where these routines are used, to ease the introduction of new tests that could rely on them. Author: Vignesh C, Michael Paquier Discussion: https://postgr.es/m/CALDaNm0YSiLpjCmajwLfidQrFOrLNKPQir7s__PeVvh9U3uoTQ@mail.gmail.com Backpatch-through: 14 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7fa7911c7675a4a9d5b36c50cb486b0fd6ca3bfb Modified Files -------------- src/test/perl/PostgreSQL/Test/Cluster.pm | 122 +++++++++++++++++-------------- 1 file changed, 66 insertions(+), 56 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Refactor log check logic for connect_ok/fails in PostgreSQL::Tes @ 2023-06-09 00:38 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2023-06-09 00:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Refactor log check logic for connect_ok/fails in PostgreSQL::Test::Cluster This commit refactors a bit the code in charge of checking for log patterns when connections fail or succeed, by moving the log pattern checks into their own routine, for clarity. This has come up as something to improve while discussing the refactoring of find_in_log(). Backpatch down to 14 where these routines are used, to ease the introduction of new tests that could rely on them. Author: Vignesh C, Michael Paquier Discussion: https://postgr.es/m/CALDaNm0YSiLpjCmajwLfidQrFOrLNKPQir7s__PeVvh9U3uoTQ@mail.gmail.com Backpatch-through: 14 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/30469a6ed4248b4543e165355a7793329ac041df Modified Files -------------- src/test/perl/PostgresNode.pm | 119 +++++++++++++++++++++++------------------- 1 file changed, 65 insertions(+), 54 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Refactor log check logic for connect_ok/fails in PostgreSQL::Tes @ 2023-06-09 00:38 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2023-06-09 00:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Refactor log check logic for connect_ok/fails in PostgreSQL::Test::Cluster This commit refactors a bit the code in charge of checking for log patterns when connections fail or succeed, by moving the log pattern checks into their own routine, for clarity. This has come up as something to improve while discussing the refactoring of find_in_log(). Backpatch down to 14 where these routines are used, to ease the introduction of new tests that could rely on them. Author: Vignesh C, Michael Paquier Discussion: https://postgr.es/m/CALDaNm0YSiLpjCmajwLfidQrFOrLNKPQir7s__PeVvh9U3uoTQ@mail.gmail.com Backpatch-through: 14 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/26eaf82e7138890022d5d06b77eb745524542fb7 Modified Files -------------- src/test/perl/PostgreSQL/Test/Cluster.pm | 121 +++++++++++++++++-------------- 1 file changed, 65 insertions(+), 56 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2023-06-09 00:38 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-06-09 00:38 pgsql: Refactor log check logic for connect_ok/fails in PostgreSQL::Tes Michael Paquier <michael@paquier.xyz> 2023-06-09 00:38 pgsql: Refactor log check logic for connect_ok/fails in PostgreSQL::Tes Michael Paquier <michael@paquier.xyz> 2023-06-09 00:38 pgsql: Refactor log check logic for connect_ok/fails in PostgreSQL::Tes Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox