pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Don't use partial unique indexes for unique proofs in the planne 6+ messages / 1 participants [nested] [flat]
* pgsql: Don't use partial unique indexes for unique proofs in the planne @ 2023-06-19 01:01 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: David Rowley @ 2023-06-19 01:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't use partial unique indexes for unique proofs in the planner Here we adjust relation_has_unique_index_for() so that it no longer makes use of partial unique indexes as uniqueness proofs. It is incorrect to use these as the predicates used by check_index_predicates() to set predOK makes use of not only baserestrictinfo quals as proofs, but also qual from join conditions. For relation_has_unique_index_for()'s case, we need to know the relation is unique for a given set of columns before any joins are evaluated, so if predOK was only set to true due to some join qual, then it's unsafe to use such indexes in relation_has_unique_index_for(). The final plan may not even make use of that index, which could result in reading tuples that are not as unique as the planner previously expected them to be. Bug: #17975 Reported-by: Tor Erik Linnerud Backpatch-through: 11, all supported versions Discussion: https://postgr.es/m/17975-98a90c156f25c952%40postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/7fcd7ef2a9c372b789f95b40043edffdc611c566 Modified Files -------------- src/backend/optimizer/path/indxpath.c | 9 ++++++--- src/backend/optimizer/plan/analyzejoins.c | 9 ++++----- src/test/regress/expected/join.out | 17 +++++++++++++++++ src/test/regress/sql/join.sql | 9 +++++++++ 4 files changed, 36 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't use partial unique indexes for unique proofs in the planne @ 2023-06-19 01:01 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: David Rowley @ 2023-06-19 01:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't use partial unique indexes for unique proofs in the planner Here we adjust relation_has_unique_index_for() so that it no longer makes use of partial unique indexes as uniqueness proofs. It is incorrect to use these as the predicates used by check_index_predicates() to set predOK makes use of not only baserestrictinfo quals as proofs, but also qual from join conditions. For relation_has_unique_index_for()'s case, we need to know the relation is unique for a given set of columns before any joins are evaluated, so if predOK was only set to true due to some join qual, then it's unsafe to use such indexes in relation_has_unique_index_for(). The final plan may not even make use of that index, which could result in reading tuples that are not as unique as the planner previously expected them to be. Bug: #17975 Reported-by: Tor Erik Linnerud Backpatch-through: 11, all supported versions Discussion: https://postgr.es/m/17975-98a90c156f25c952%40postgresql.org Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8f2ec8cc7e3de918988a49302dddc64deca16c02 Modified Files -------------- src/backend/optimizer/path/indxpath.c | 9 ++++++--- src/backend/optimizer/plan/analyzejoins.c | 9 ++++----- src/test/regress/expected/join.out | 17 +++++++++++++++++ src/test/regress/sql/join.sql | 9 +++++++++ 4 files changed, 36 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't use partial unique indexes for unique proofs in the planne @ 2023-06-19 01:02 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: David Rowley @ 2023-06-19 01:02 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't use partial unique indexes for unique proofs in the planner Here we adjust relation_has_unique_index_for() so that it no longer makes use of partial unique indexes as uniqueness proofs. It is incorrect to use these as the predicates used by check_index_predicates() to set predOK makes use of not only baserestrictinfo quals as proofs, but also qual from join conditions. For relation_has_unique_index_for()'s case, we need to know the relation is unique for a given set of columns before any joins are evaluated, so if predOK was only set to true due to some join qual, then it's unsafe to use such indexes in relation_has_unique_index_for(). The final plan may not even make use of that index, which could result in reading tuples that are not as unique as the planner previously expected them to be. Bug: #17975 Reported-by: Tor Erik Linnerud Backpatch-through: 11, all supported versions Discussion: https://postgr.es/m/17975-98a90c156f25c952%40postgresql.org Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/73f1c17fc31b3582ad8ab8fed33e9c9c1067045b Modified Files -------------- src/backend/optimizer/path/indxpath.c | 9 ++++++--- src/backend/optimizer/plan/analyzejoins.c | 9 ++++----- src/test/regress/expected/join.out | 17 +++++++++++++++++ src/test/regress/sql/join.sql | 9 +++++++++ 4 files changed, 36 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't use partial unique indexes for unique proofs in the planne @ 2023-06-19 01:02 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: David Rowley @ 2023-06-19 01:02 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't use partial unique indexes for unique proofs in the planner Here we adjust relation_has_unique_index_for() so that it no longer makes use of partial unique indexes as uniqueness proofs. It is incorrect to use these as the predicates used by check_index_predicates() to set predOK makes use of not only baserestrictinfo quals as proofs, but also qual from join conditions. For relation_has_unique_index_for()'s case, we need to know the relation is unique for a given set of columns before any joins are evaluated, so if predOK was only set to true due to some join qual, then it's unsafe to use such indexes in relation_has_unique_index_for(). The final plan may not even make use of that index, which could result in reading tuples that are not as unique as the planner previously expected them to be. Bug: #17975 Reported-by: Tor Erik Linnerud Backpatch-through: 11, all supported versions Discussion: https://postgr.es/m/17975-98a90c156f25c952%40postgresql.org Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/06286f8a2f0e7980a93f02a876b34be196001daa Modified Files -------------- src/backend/optimizer/path/indxpath.c | 9 ++++++--- src/backend/optimizer/plan/analyzejoins.c | 9 ++++----- src/test/regress/expected/join.out | 17 +++++++++++++++++ src/test/regress/sql/join.sql | 9 +++++++++ 4 files changed, 36 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't use partial unique indexes for unique proofs in the planne @ 2023-06-19 01:03 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: David Rowley @ 2023-06-19 01:03 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't use partial unique indexes for unique proofs in the planner Here we adjust relation_has_unique_index_for() so that it no longer makes use of partial unique indexes as uniqueness proofs. It is incorrect to use these as the predicates used by check_index_predicates() to set predOK makes use of not only baserestrictinfo quals as proofs, but also qual from join conditions. For relation_has_unique_index_for()'s case, we need to know the relation is unique for a given set of columns before any joins are evaluated, so if predOK was only set to true due to some join qual, then it's unsafe to use such indexes in relation_has_unique_index_for(). The final plan may not even make use of that index, which could result in reading tuples that are not as unique as the planner previously expected them to be. Bug: #17975 Reported-by: Tor Erik Linnerud Backpatch-through: 11, all supported versions Discussion: https://postgr.es/m/17975-98a90c156f25c952%40postgresql.org Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/dcef5b052e09917c42c5100843152950616ff1f9 Modified Files -------------- src/backend/optimizer/path/indxpath.c | 9 ++++++--- src/backend/optimizer/plan/analyzejoins.c | 9 ++++----- src/test/regress/expected/join.out | 17 +++++++++++++++++ src/test/regress/sql/join.sql | 9 +++++++++ 4 files changed, 36 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't use partial unique indexes for unique proofs in the planne @ 2023-06-19 01:03 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: David Rowley @ 2023-06-19 01:03 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't use partial unique indexes for unique proofs in the planner Here we adjust relation_has_unique_index_for() so that it no longer makes use of partial unique indexes as uniqueness proofs. It is incorrect to use these as the predicates used by check_index_predicates() to set predOK makes use of not only baserestrictinfo quals as proofs, but also qual from join conditions. For relation_has_unique_index_for()'s case, we need to know the relation is unique for a given set of columns before any joins are evaluated, so if predOK was only set to true due to some join qual, then it's unsafe to use such indexes in relation_has_unique_index_for(). The final plan may not even make use of that index, which could result in reading tuples that are not as unique as the planner previously expected them to be. Bug: #17975 Reported-by: Tor Erik Linnerud Backpatch-through: 11, all supported versions Discussion: https://postgr.es/m/17975-98a90c156f25c952%40postgresql.org Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f6345f03f358887877942b266d6992ed8be60153 Modified Files -------------- src/backend/optimizer/path/indxpath.c | 9 ++++++--- src/backend/optimizer/plan/analyzejoins.c | 9 ++++----- src/test/regress/expected/join.out | 17 +++++++++++++++++ src/test/regress/sql/join.sql | 9 +++++++++ 4 files changed, 36 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2023-06-19 01:03 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-06-19 01:01 pgsql: Don't use partial unique indexes for unique proofs in the planne David Rowley <drowley@postgresql.org> 2023-06-19 01:01 pgsql: Don't use partial unique indexes for unique proofs in the planne David Rowley <drowley@postgresql.org> 2023-06-19 01:02 pgsql: Don't use partial unique indexes for unique proofs in the planne David Rowley <drowley@postgresql.org> 2023-06-19 01:02 pgsql: Don't use partial unique indexes for unique proofs in the planne David Rowley <drowley@postgresql.org> 2023-06-19 01:03 pgsql: Don't use partial unique indexes for unique proofs in the planne David Rowley <drowley@postgresql.org> 2023-06-19 01:03 pgsql: Don't use partial unique indexes for unique proofs in the planne David Rowley <drowley@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox