pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: nbtree VACUUM: cope with topparent inconsistencies.
6+ messages / 1 participants
[nested] [flat]

* pgsql: nbtree VACUUM: cope with topparent inconsistencies.
@ 2023-06-22 00:42 Peter Geoghegan <pg@bowt.ie>
  0 siblings, 0 replies; 6+ messages in thread

From: Peter Geoghegan @ 2023-06-22 00:42 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

nbtree VACUUM: cope with topparent inconsistencies.

Avoid "right sibling %u of block %u is not next child" errors when
vacuuming a corrupt nbtree index.  Just LOG the issue and press on.
That way VACUUM will have a decent chance of finishing off all required
processing for the index (and for the table as a whole).

This is similar to recent work from commit 5abff197, as well as work
from commit 5b861baa (later backpatched as commit 43e409ce), which
taught nbtree VACUUM to keep going when its "re-find" check fails.  The
hardening added by this commit takes place directly after the "re-find"
check, right before the critical section for the first stage of page
deletion.

Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAH2-Wz=dayg0vjs4+er84TS9ami=csdzjpuiCGbEw=idhwqhzQ@mail.gmail.com
Backpatch: 11- (all supported versions).

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5f0762f14754597724c24cf6517fe4fe6412a6f9

Modified Files
--------------
src/backend/access/nbtree/nbtpage.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: nbtree VACUUM: cope with topparent inconsistencies.
@ 2023-06-22 00:42 Peter Geoghegan <pg@bowt.ie>
  0 siblings, 0 replies; 6+ messages in thread

From: Peter Geoghegan @ 2023-06-22 00:42 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

nbtree VACUUM: cope with topparent inconsistencies.

Avoid "right sibling %u of block %u is not next child" errors when
vacuuming a corrupt nbtree index.  Just LOG the issue and press on.
That way VACUUM will have a decent chance of finishing off all required
processing for the index (and for the table as a whole).

This is similar to recent work from commit 5abff197, as well as work
from commit 5b861baa (later backpatched as commit 43e409ce), which
taught nbtree VACUUM to keep going when its "re-find" check fails.  The
hardening added by this commit takes place directly after the "re-find"
check, right before the critical section for the first stage of page
deletion.

Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAH2-Wz=dayg0vjs4+er84TS9ami=csdzjpuiCGbEw=idhwqhzQ@mail.gmail.com
Backpatch: 11- (all supported versions).

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/642bec1f8dd2e05b769a4ed3b42ef0fe57804647

Modified Files
--------------
src/backend/access/nbtree/nbtpage.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: nbtree VACUUM: cope with topparent inconsistencies.
@ 2023-06-22 00:42 Peter Geoghegan <pg@bowt.ie>
  0 siblings, 0 replies; 6+ messages in thread

From: Peter Geoghegan @ 2023-06-22 00:42 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

nbtree VACUUM: cope with topparent inconsistencies.

Avoid "right sibling %u of block %u is not next child" errors when
vacuuming a corrupt nbtree index.  Just LOG the issue and press on.
That way VACUUM will have a decent chance of finishing off all required
processing for the index (and for the table as a whole).

This is similar to recent work from commit 5abff197, as well as work
from commit 5b861baa (later backpatched as commit 43e409ce), which
taught nbtree VACUUM to keep going when its "re-find" check fails.  The
hardening added by this commit takes place directly after the "re-find"
check, right before the critical section for the first stage of page
deletion.

Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAH2-Wz=dayg0vjs4+er84TS9ami=csdzjpuiCGbEw=idhwqhzQ@mail.gmail.com
Backpatch: 11- (all supported versions).

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/63fa0deb31c4b18a6dbf15fc8ff64ac010ea77b2

Modified Files
--------------
src/backend/access/nbtree/nbtpage.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: nbtree VACUUM: cope with topparent inconsistencies.
@ 2023-06-22 00:42 Peter Geoghegan <pg@bowt.ie>
  0 siblings, 0 replies; 6+ messages in thread

From: Peter Geoghegan @ 2023-06-22 00:42 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

nbtree VACUUM: cope with topparent inconsistencies.

Avoid "right sibling %u of block %u is not next child" errors when
vacuuming a corrupt nbtree index.  Just LOG the issue and press on.
That way VACUUM will have a decent chance of finishing off all required
processing for the index (and for the table as a whole).

This is similar to recent work from commit 5abff197, as well as work
from commit 5b861baa (later backpatched as commit 43e409ce), which
taught nbtree VACUUM to keep going when its "re-find" check fails.  The
hardening added by this commit takes place directly after the "re-find"
check, right before the critical section for the first stage of page
deletion.

Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAH2-Wz=dayg0vjs4+er84TS9ami=csdzjpuiCGbEw=idhwqhzQ@mail.gmail.com
Backpatch: 11- (all supported versions).

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b6311824f011d3ba03a6c5c1c0bbd7f31e27dbc6

Modified Files
--------------
src/backend/access/nbtree/nbtpage.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: nbtree VACUUM: cope with topparent inconsistencies.
@ 2023-06-22 00:42 Peter Geoghegan <pg@bowt.ie>
  0 siblings, 0 replies; 6+ messages in thread

From: Peter Geoghegan @ 2023-06-22 00:42 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

nbtree VACUUM: cope with topparent inconsistencies.

Avoid "right sibling %u of block %u is not next child" errors when
vacuuming a corrupt nbtree index.  Just LOG the issue and press on.
That way VACUUM will have a decent chance of finishing off all required
processing for the index (and for the table as a whole).

This is similar to recent work from commit 5abff197, as well as work
from commit 5b861baa (later backpatched as commit 43e409ce), which
taught nbtree VACUUM to keep going when its "re-find" check fails.  The
hardening added by this commit takes place directly after the "re-find"
check, right before the critical section for the first stage of page
deletion.

Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAH2-Wz=dayg0vjs4+er84TS9ami=csdzjpuiCGbEw=idhwqhzQ@mail.gmail.com
Backpatch: 11- (all supported versions).

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/355917c07c633ab00e41c91eef262b3e438a63e4

Modified Files
--------------
src/backend/access/nbtree/nbtpage.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: nbtree VACUUM: cope with topparent inconsistencies.
@ 2023-06-22 00:42 Peter Geoghegan <pg@bowt.ie>
  0 siblings, 0 replies; 6+ messages in thread

From: Peter Geoghegan @ 2023-06-22 00:42 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

nbtree VACUUM: cope with topparent inconsistencies.

Avoid "right sibling %u of block %u is not next child" errors when
vacuuming a corrupt nbtree index.  Just LOG the issue and press on.
That way VACUUM will have a decent chance of finishing off all required
processing for the index (and for the table as a whole).

This is similar to recent work from commit 5abff197, as well as work
from commit 5b861baa (later backpatched as commit 43e409ce), which
taught nbtree VACUUM to keep going when its "re-find" check fails.  The
hardening added by this commit takes place directly after the "re-find"
check, right before the critical section for the first stage of page
deletion.

Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/CAH2-Wz=dayg0vjs4+er84TS9ami=csdzjpuiCGbEw=idhwqhzQ@mail.gmail.com
Backpatch: 11- (all supported versions).

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7ddba19eb7114fd34f54986d83a1ad50b1db9537

Modified Files
--------------
src/backend/access/nbtree/nbtpage.c | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2023-06-22 00:42 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-06-22 00:42 pgsql: nbtree VACUUM: cope with topparent inconsistencies. Peter Geoghegan <pg@bowt.ie>
2023-06-22 00:42 pgsql: nbtree VACUUM: cope with topparent inconsistencies. Peter Geoghegan <pg@bowt.ie>
2023-06-22 00:42 pgsql: nbtree VACUUM: cope with topparent inconsistencies. Peter Geoghegan <pg@bowt.ie>
2023-06-22 00:42 pgsql: nbtree VACUUM: cope with topparent inconsistencies. Peter Geoghegan <pg@bowt.ie>
2023-06-22 00:42 pgsql: nbtree VACUUM: cope with topparent inconsistencies. Peter Geoghegan <pg@bowt.ie>
2023-06-22 00:42 pgsql: nbtree VACUUM: cope with topparent inconsistencies. Peter Geoghegan <pg@bowt.ie>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox