pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Add a test case for a316a3bc 2+ messages / 1 participants [nested] [flat]
* pgsql: Add a test case for a316a3bc @ 2023-06-30 06:52 Amit Langote <amitlan@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Amit Langote @ 2023-06-30 06:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add a test case for a316a3bc a316a3bc fixed the code in build_simpl_rel() that propagates RelOptInfo.userid from parent to child rels so that it works correctly for the child rels of a UNION ALL subquery rel, though no tests were added in that commit. So do so here. As noted in the discussion, coming up with a test case in the core regression suite for this fix has turned out to be tricky, so the test case is added to the postgres_fdw's suite instead. postgresGetForeignRelSize()'s use of user mapping for the user specified in RelOptInfo.userid makes it relatively easier to craft a test case around. Discussion: https://postgr.es/m/CA%2BHiwqH91GaFNXcXbLAM9L%3DzBwUmSyv699Mtv3i1_xtk9Xec_A%40mail.gmail.com Backpatch-through: 16 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/054ff3b33a85d62b4d486dabb5e5718399822a18 Modified Files -------------- contrib/postgres_fdw/expected/postgres_fdw.out | 42 ++++++++++++++++++++++++++ contrib/postgres_fdw/sql/postgres_fdw.sql | 23 ++++++++++++++ 2 files changed, 65 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Add a test case for a316a3bc @ 2023-06-30 06:53 Amit Langote <amitlan@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Amit Langote @ 2023-06-30 06:53 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add a test case for a316a3bc a316a3bc fixed the code in build_simpl_rel() that propagates RelOptInfo.userid from parent to child rels so that it works correctly for the child rels of a UNION ALL subquery rel, though no tests were added in that commit. So do so here. As noted in the discussion, coming up with a test case in the core regression suite for this fix has turned out to be tricky, so the test case is added to the postgres_fdw's suite instead. postgresGetForeignRelSize()'s use of user mapping for the user specified in RelOptInfo.userid makes it relatively easier to craft a test case around. Discussion: https://postgr.es/m/CA%2BHiwqH91GaFNXcXbLAM9L%3DzBwUmSyv699Mtv3i1_xtk9Xec_A%40mail.gmail.com Backpatch-through: 16 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0a14bca662a44310305ad3fcc1079ef75d4a6316 Modified Files -------------- contrib/postgres_fdw/expected/postgres_fdw.out | 42 ++++++++++++++++++++++++++ contrib/postgres_fdw/sql/postgres_fdw.sql | 23 ++++++++++++++ 2 files changed, 65 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2023-06-30 06:53 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-06-30 06:52 pgsql: Add a test case for a316a3bc Amit Langote <amitlan@postgresql.org> 2023-06-30 06:53 pgsql: Add a test case for a316a3bc Amit Langote <amitlan@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox