pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix race in SSI interaction with gin fast path. 7+ messages / 1 participants [nested] [flat]
* pgsql: Fix race in SSI interaction with gin fast path. @ 2023-07-03 21:58 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Thomas Munro @ 2023-07-03 21:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix race in SSI interaction with gin fast path. The ginfast.c code previously checked for conflicts in before locking the relevant buffer, leaving a window where a RW conflict could be missed. Re-order. There was also a place where buffer ID and block number were confused while trying to predicate-lock a page, noted by visual inspection. Back-patch to all supported releases. Fixes one more problem discovered with the reproducer from bug #17949, in this case when Dmitry tried other index types. Reported-by: Artem Anisimov <artem.anisimov.255@gmail.com> Reported-by: Dmitry Dolgov <9erthalion6@gmail.com> Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Discussion: https://postgr.es/m/17949-a0f17035294a55e2%40postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/126552c85c1cfb6ce6445159b8024cfa5631f33e Modified Files -------------- src/backend/access/gin/ginfast.c | 9 +++++++-- src/backend/access/gin/ginget.c | 4 +++- 2 files changed, 10 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix race in SSI interaction with gin fast path. @ 2023-07-03 21:58 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Thomas Munro @ 2023-07-03 21:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix race in SSI interaction with gin fast path. The ginfast.c code previously checked for conflicts in before locking the relevant buffer, leaving a window where a RW conflict could be missed. Re-order. There was also a place where buffer ID and block number were confused while trying to predicate-lock a page, noted by visual inspection. Back-patch to all supported releases. Fixes one more problem discovered with the reproducer from bug #17949, in this case when Dmitry tried other index types. Reported-by: Artem Anisimov <artem.anisimov.255@gmail.com> Reported-by: Dmitry Dolgov <9erthalion6@gmail.com> Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Discussion: https://postgr.es/m/17949-a0f17035294a55e2%40postgresql.org Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/12529028a4e55eb0500477d2589eec625466facf Modified Files -------------- src/backend/access/gin/ginfast.c | 9 +++++++-- src/backend/access/gin/ginget.c | 4 +++- 2 files changed, 10 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix race in SSI interaction with gin fast path. @ 2023-07-03 21:58 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Thomas Munro @ 2023-07-03 21:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix race in SSI interaction with gin fast path. The ginfast.c code previously checked for conflicts in before locking the relevant buffer, leaving a window where a RW conflict could be missed. Re-order. There was also a place where buffer ID and block number were confused while trying to predicate-lock a page, noted by visual inspection. Back-patch to all supported releases. Fixes one more problem discovered with the reproducer from bug #17949, in this case when Dmitry tried other index types. Reported-by: Artem Anisimov <artem.anisimov.255@gmail.com> Reported-by: Dmitry Dolgov <9erthalion6@gmail.com> Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Discussion: https://postgr.es/m/17949-a0f17035294a55e2%40postgresql.org Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d34aa0a2f4f36e25d49d43cd1836e20f9c96899e Modified Files -------------- src/backend/access/gin/ginfast.c | 9 +++++++-- src/backend/access/gin/ginget.c | 4 +++- 2 files changed, 10 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix race in SSI interaction with gin fast path. @ 2023-07-03 21:59 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Thomas Munro @ 2023-07-03 21:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix race in SSI interaction with gin fast path. The ginfast.c code previously checked for conflicts in before locking the relevant buffer, leaving a window where a RW conflict could be missed. Re-order. There was also a place where buffer ID and block number were confused while trying to predicate-lock a page, noted by visual inspection. Back-patch to all supported releases. Fixes one more problem discovered with the reproducer from bug #17949, in this case when Dmitry tried other index types. Reported-by: Artem Anisimov <artem.anisimov.255@gmail.com> Reported-by: Dmitry Dolgov <9erthalion6@gmail.com> Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Discussion: https://postgr.es/m/17949-a0f17035294a55e2%40postgresql.org Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/fb663f38790eb5f7aa994f617c6edda81f4e774c Modified Files -------------- src/backend/access/gin/ginfast.c | 9 +++++++-- src/backend/access/gin/ginget.c | 4 +++- 2 files changed, 10 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix race in SSI interaction with gin fast path. @ 2023-07-03 21:59 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Thomas Munro @ 2023-07-03 21:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix race in SSI interaction with gin fast path. The ginfast.c code previously checked for conflicts in before locking the relevant buffer, leaving a window where a RW conflict could be missed. Re-order. There was also a place where buffer ID and block number were confused while trying to predicate-lock a page, noted by visual inspection. Back-patch to all supported releases. Fixes one more problem discovered with the reproducer from bug #17949, in this case when Dmitry tried other index types. Reported-by: Artem Anisimov <artem.anisimov.255@gmail.com> Reported-by: Dmitry Dolgov <9erthalion6@gmail.com> Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Discussion: https://postgr.es/m/17949-a0f17035294a55e2%40postgresql.org Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/fc15473840bcccecb10030ae9a900171d2371027 Modified Files -------------- src/backend/access/gin/ginfast.c | 9 +++++++-- src/backend/access/gin/ginget.c | 4 +++- 2 files changed, 10 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix race in SSI interaction with gin fast path. @ 2023-07-03 21:59 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Thomas Munro @ 2023-07-03 21:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix race in SSI interaction with gin fast path. The ginfast.c code previously checked for conflicts in before locking the relevant buffer, leaving a window where a RW conflict could be missed. Re-order. There was also a place where buffer ID and block number were confused while trying to predicate-lock a page, noted by visual inspection. Back-patch to all supported releases. Fixes one more problem discovered with the reproducer from bug #17949, in this case when Dmitry tried other index types. Reported-by: Artem Anisimov <artem.anisimov.255@gmail.com> Reported-by: Dmitry Dolgov <9erthalion6@gmail.com> Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Discussion: https://postgr.es/m/17949-a0f17035294a55e2%40postgresql.org Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/255a925d333be9a3d6314e2fe698063eb8e753a6 Modified Files -------------- src/backend/access/gin/ginfast.c | 9 +++++++-- src/backend/access/gin/ginget.c | 4 +++- 2 files changed, 10 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix race in SSI interaction with gin fast path. @ 2023-07-03 21:59 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Thomas Munro @ 2023-07-03 21:59 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix race in SSI interaction with gin fast path. The ginfast.c code previously checked for conflicts in before locking the relevant buffer, leaving a window where a RW conflict could be missed. Re-order. There was also a place where buffer ID and block number were confused while trying to predicate-lock a page, noted by visual inspection. Back-patch to all supported releases. Fixes one more problem discovered with the reproducer from bug #17949, in this case when Dmitry tried other index types. Reported-by: Artem Anisimov <artem.anisimov.255@gmail.com> Reported-by: Dmitry Dolgov <9erthalion6@gmail.com> Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Discussion: https://postgr.es/m/17949-a0f17035294a55e2%40postgresql.org Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/13f127800fed839cf665c0cd8020061a1f79c41a Modified Files -------------- src/backend/access/gin/ginfast.c | 9 +++++++-- src/backend/access/gin/ginget.c | 4 +++- 2 files changed, 10 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2023-07-03 21:59 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-07-03 21:58 pgsql: Fix race in SSI interaction with gin fast path. Thomas Munro <tmunro@postgresql.org> 2023-07-03 21:58 pgsql: Fix race in SSI interaction with gin fast path. Thomas Munro <tmunro@postgresql.org> 2023-07-03 21:58 pgsql: Fix race in SSI interaction with gin fast path. Thomas Munro <tmunro@postgresql.org> 2023-07-03 21:59 pgsql: Fix race in SSI interaction with gin fast path. Thomas Munro <tmunro@postgresql.org> 2023-07-03 21:59 pgsql: Fix race in SSI interaction with gin fast path. Thomas Munro <tmunro@postgresql.org> 2023-07-03 21:59 pgsql: Fix race in SSI interaction with gin fast path. Thomas Munro <tmunro@postgresql.org> 2023-07-03 21:59 pgsql: Fix race in SSI interaction with gin fast path. Thomas Munro <tmunro@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox