pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: pgstat: fix subscription stats entry leak.
3+ messages / 1 participants
[nested] [flat]

* pgsql: pgstat: fix subscription stats entry leak.
@ 2023-07-05 05:54  Masahiko Sawada <msawada@postgresql.org>
  0 siblings, 0 replies; 3+ messages in thread

From: Masahiko Sawada @ 2023-07-05 05:54 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pgstat: fix subscription stats entry leak.

Commit 7b64e4b3 taught DropSubscription() to drop stats entry of
subscription that is not associated with a replication slot for apply
worker at DROP SUBSCRIPTION but missed covering the case where the
subscription is not associated with replication slots for both apply
worker and tablesync worker.

Also add a test to verify that the stats for slot-less subscription is
removed at DROP SUBSCRIPTION time.

Backpatch down to 15.

Author: Masahiko Sawada
Reviewed-by: Nathan Bossart, Hayato Kuroda, Melih Mutlu, Amit Kapila
Discussion: https://postgr.es/m/CAD21AoB71zkP7uPT7JDPsZcvp0749ExEQnOJxeNKPDFisHar+w@mail.gmail.com
Backpatch-through: 15

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/66f8a139731957a7d516ade70cd3aa43d12d3c4f

Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 12 ++++++------
src/test/subscription/t/026_stats.pl    | 20 ++++++++++++++++++++
2 files changed, 26 insertions(+), 6 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: pgstat: fix subscription stats entry leak.
@ 2023-07-05 05:54  Masahiko Sawada <msawada@postgresql.org>
  0 siblings, 0 replies; 3+ messages in thread

From: Masahiko Sawada @ 2023-07-05 05:54 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pgstat: fix subscription stats entry leak.

Commit 7b64e4b3 taught DropSubscription() to drop stats entry of
subscription that is not associated with a replication slot for apply
worker at DROP SUBSCRIPTION but missed covering the case where the
subscription is not associated with replication slots for both apply
worker and tablesync worker.

Also add a test to verify that the stats for slot-less subscription is
removed at DROP SUBSCRIPTION time.

Backpatch down to 15.

Author: Masahiko Sawada
Reviewed-by: Nathan Bossart, Hayato Kuroda, Melih Mutlu, Amit Kapila
Discussion: https://postgr.es/m/CAD21AoB71zkP7uPT7JDPsZcvp0749ExEQnOJxeNKPDFisHar+w@mail.gmail.com
Backpatch-through: 15

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/be8cae7e2f03f35a049e2b1f1113860fea6d0212

Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 12 ++++++------
src/test/subscription/t/026_stats.pl    | 20 ++++++++++++++++++++
2 files changed, 26 insertions(+), 6 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: pgstat: fix subscription stats entry leak.
@ 2023-07-05 05:54  Masahiko Sawada <msawada@postgresql.org>
  0 siblings, 0 replies; 3+ messages in thread

From: Masahiko Sawada @ 2023-07-05 05:54 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

pgstat: fix subscription stats entry leak.

Commit 7b64e4b3 taught DropSubscription() to drop stats entry of
subscription that is not associated with a replication slot for apply
worker at DROP SUBSCRIPTION but missed covering the case where the
subscription is not associated with replication slots for both apply
worker and tablesync worker.

Also add a test to verify that the stats for slot-less subscription is
removed at DROP SUBSCRIPTION time.

Backpatch down to 15.

Author: Masahiko Sawada
Reviewed-by: Nathan Bossart, Hayato Kuroda, Melih Mutlu, Amit Kapila
Discussion: https://postgr.es/m/CAD21AoB71zkP7uPT7JDPsZcvp0749ExEQnOJxeNKPDFisHar+w@mail.gmail.com
Backpatch-through: 15

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/68a59f9e99831cf05a746928a955781503232bbb

Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 12 ++++++------
src/test/subscription/t/026_stats.pl    | 20 ++++++++++++++++++++
2 files changed, 26 insertions(+), 6 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2023-07-05 05:54 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-07-05 05:54 pgsql: pgstat: fix subscription stats entry leak. Masahiko Sawada <msawada@postgresql.org>
2023-07-05 05:54 pgsql: pgstat: fix subscription stats entry leak. Masahiko Sawada <msawada@postgresql.org>
2023-07-05 05:54 pgsql: pgstat: fix subscription stats entry leak. Masahiko Sawada <msawada@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox