pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Add indisreplident to fields refreshed by RelationReloadIndexInf 7+ messages / 1 participants [nested] [flat]
* pgsql: Add indisreplident to fields refreshed by RelationReloadIndexInf @ 2023-07-14 02:16 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2023-07-14 02:16 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add indisreplident to fields refreshed by RelationReloadIndexInfo() RelationReloadIndexInfo() is a fast-path used for index reloads in the relation cache, and it has always forgotten about updating indisreplident, which is something that would happen after an index is selected for a replica identity. This can lead to incorrect cache information provided when executing a command in a transaction context that updates indisreplident. None of the code paths currently on HEAD that need to check upon pg_index.indisreplident fetch its value from the relation cache, always relying on a fresh copy on the syscache. Unfortunately, this may not be the case of out-of-core code, that could see out-of-date value. Author: Shruthi Gowda Reviewed-by: Robert Haas, Dilip Kumar, Michael Paquier Discussion: https://postgr.es/m/CAASxf_PBcxax0wW-3gErUyftZ0XrCs3Lrpuhq4-Z3Fak1DoW7Q@mail.gmail.com Backpatch-through: 11 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/a5ea825f958c2de9fadb825cbf16bf9b1360f0df Modified Files -------------- src/backend/utils/cache/relcache.c | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Add indisreplident to fields refreshed by RelationReloadIndexInf @ 2023-07-14 02:16 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2023-07-14 02:16 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add indisreplident to fields refreshed by RelationReloadIndexInfo() RelationReloadIndexInfo() is a fast-path used for index reloads in the relation cache, and it has always forgotten about updating indisreplident, which is something that would happen after an index is selected for a replica identity. This can lead to incorrect cache information provided when executing a command in a transaction context that updates indisreplident. None of the code paths currently on HEAD that need to check upon pg_index.indisreplident fetch its value from the relation cache, always relying on a fresh copy on the syscache. Unfortunately, this may not be the case of out-of-core code, that could see out-of-date value. Author: Shruthi Gowda Reviewed-by: Robert Haas, Dilip Kumar, Michael Paquier Discussion: https://postgr.es/m/CAASxf_PBcxax0wW-3gErUyftZ0XrCs3Lrpuhq4-Z3Fak1DoW7Q@mail.gmail.com Backpatch-through: 11 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/27da47122075971aeacd4e2284d7907dde8a7204 Modified Files -------------- src/backend/utils/cache/relcache.c | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Add indisreplident to fields refreshed by RelationReloadIndexInf @ 2023-07-14 02:16 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2023-07-14 02:16 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add indisreplident to fields refreshed by RelationReloadIndexInfo() RelationReloadIndexInfo() is a fast-path used for index reloads in the relation cache, and it has always forgotten about updating indisreplident, which is something that would happen after an index is selected for a replica identity. This can lead to incorrect cache information provided when executing a command in a transaction context that updates indisreplident. None of the code paths currently on HEAD that need to check upon pg_index.indisreplident fetch its value from the relation cache, always relying on a fresh copy on the syscache. Unfortunately, this may not be the case of out-of-core code, that could see out-of-date value. Author: Shruthi Gowda Reviewed-by: Robert Haas, Dilip Kumar, Michael Paquier Discussion: https://postgr.es/m/CAASxf_PBcxax0wW-3gErUyftZ0XrCs3Lrpuhq4-Z3Fak1DoW7Q@mail.gmail.com Backpatch-through: 11 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/eb3abec4b67d2b51406c23030dd87643fa2024c2 Modified Files -------------- src/backend/utils/cache/relcache.c | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Add indisreplident to fields refreshed by RelationReloadIndexInf @ 2023-07-14 02:16 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2023-07-14 02:16 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add indisreplident to fields refreshed by RelationReloadIndexInfo() RelationReloadIndexInfo() is a fast-path used for index reloads in the relation cache, and it has always forgotten about updating indisreplident, which is something that would happen after an index is selected for a replica identity. This can lead to incorrect cache information provided when executing a command in a transaction context that updates indisreplident. None of the code paths currently on HEAD that need to check upon pg_index.indisreplident fetch its value from the relation cache, always relying on a fresh copy on the syscache. Unfortunately, this may not be the case of out-of-core code, that could see out-of-date value. Author: Shruthi Gowda Reviewed-by: Robert Haas, Dilip Kumar, Michael Paquier Discussion: https://postgr.es/m/CAASxf_PBcxax0wW-3gErUyftZ0XrCs3Lrpuhq4-Z3Fak1DoW7Q@mail.gmail.com Backpatch-through: 11 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7af65523ab8b63d2e27b898a995388179a802c71 Modified Files -------------- src/backend/utils/cache/relcache.c | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Add indisreplident to fields refreshed by RelationReloadIndexInf @ 2023-07-14 02:16 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2023-07-14 02:16 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add indisreplident to fields refreshed by RelationReloadIndexInfo() RelationReloadIndexInfo() is a fast-path used for index reloads in the relation cache, and it has always forgotten about updating indisreplident, which is something that would happen after an index is selected for a replica identity. This can lead to incorrect cache information provided when executing a command in a transaction context that updates indisreplident. None of the code paths currently on HEAD that need to check upon pg_index.indisreplident fetch its value from the relation cache, always relying on a fresh copy on the syscache. Unfortunately, this may not be the case of out-of-core code, that could see out-of-date value. Author: Shruthi Gowda Reviewed-by: Robert Haas, Dilip Kumar, Michael Paquier Discussion: https://postgr.es/m/CAASxf_PBcxax0wW-3gErUyftZ0XrCs3Lrpuhq4-Z3Fak1DoW7Q@mail.gmail.com Backpatch-through: 11 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bdaaf1bf1d90d8c510f18f81edbe90e54262c9df Modified Files -------------- src/backend/utils/cache/relcache.c | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Add indisreplident to fields refreshed by RelationReloadIndexInf @ 2023-07-14 02:16 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2023-07-14 02:16 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add indisreplident to fields refreshed by RelationReloadIndexInfo() RelationReloadIndexInfo() is a fast-path used for index reloads in the relation cache, and it has always forgotten about updating indisreplident, which is something that would happen after an index is selected for a replica identity. This can lead to incorrect cache information provided when executing a command in a transaction context that updates indisreplident. None of the code paths currently on HEAD that need to check upon pg_index.indisreplident fetch its value from the relation cache, always relying on a fresh copy on the syscache. Unfortunately, this may not be the case of out-of-core code, that could see out-of-date value. Author: Shruthi Gowda Reviewed-by: Robert Haas, Dilip Kumar, Michael Paquier Discussion: https://postgr.es/m/CAASxf_PBcxax0wW-3gErUyftZ0XrCs3Lrpuhq4-Z3Fak1DoW7Q@mail.gmail.com Backpatch-through: 11 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7d27493b74c5893fb50b82266d019964493318d9 Modified Files -------------- src/backend/utils/cache/relcache.c | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Add indisreplident to fields refreshed by RelationReloadIndexInf @ 2023-07-14 02:16 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2023-07-14 02:16 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add indisreplident to fields refreshed by RelationReloadIndexInfo() RelationReloadIndexInfo() is a fast-path used for index reloads in the relation cache, and it has always forgotten about updating indisreplident, which is something that would happen after an index is selected for a replica identity. This can lead to incorrect cache information provided when executing a command in a transaction context that updates indisreplident. None of the code paths currently on HEAD that need to check upon pg_index.indisreplident fetch its value from the relation cache, always relying on a fresh copy on the syscache. Unfortunately, this may not be the case of out-of-core code, that could see out-of-date value. Author: Shruthi Gowda Reviewed-by: Robert Haas, Dilip Kumar, Michael Paquier Discussion: https://postgr.es/m/CAASxf_PBcxax0wW-3gErUyftZ0XrCs3Lrpuhq4-Z3Fak1DoW7Q@mail.gmail.com Backpatch-through: 11 Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/db9813819fe80c7ba670c03025428e85fe85c70f Modified Files -------------- src/backend/utils/cache/relcache.c | 1 + 1 file changed, 1 insertion(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2023-07-14 02:16 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-07-14 02:16 pgsql: Add indisreplident to fields refreshed by RelationReloadIndexInf Michael Paquier <michael@paquier.xyz> 2023-07-14 02:16 pgsql: Add indisreplident to fields refreshed by RelationReloadIndexInf Michael Paquier <michael@paquier.xyz> 2023-07-14 02:16 pgsql: Add indisreplident to fields refreshed by RelationReloadIndexInf Michael Paquier <michael@paquier.xyz> 2023-07-14 02:16 pgsql: Add indisreplident to fields refreshed by RelationReloadIndexInf Michael Paquier <michael@paquier.xyz> 2023-07-14 02:16 pgsql: Add indisreplident to fields refreshed by RelationReloadIndexInf Michael Paquier <michael@paquier.xyz> 2023-07-14 02:16 pgsql: Add indisreplident to fields refreshed by RelationReloadIndexInf Michael Paquier <michael@paquier.xyz> 2023-07-14 02:16 pgsql: Add indisreplident to fields refreshed by RelationReloadIndexInf Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox