pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Avoid compiler warning in non-assert builds.
4+ messages / 2 participants
[nested] [flat]

* pgsql: Avoid compiler warning in non-assert builds.
@ 2023-07-22 14:33  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 4+ messages in thread

From: Tom Lane @ 2023-07-22 14:33 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Avoid compiler warning in non-assert builds.

After 3c90dcd03, try_partitionwise_join's child_joinrelids
variable is read only in an Assert, provoking a compiler
warning in non-assert builds.  Rearrange code to avoid the
warning and eliminate unnecessary work in the non-assert case.

Per CI testing (via Jeff Davis and Bharath Rupireddy)

Discussion: https://postgr.es/m/ef0de9713e605451f1b60b30648c5ee900b2394c.camel@j-davis.com

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/11237e5a46ca2221aca5c74bf43bb58eff8dcc3b

Modified Files
--------------
src/backend/optimizer/path/joinrels.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Avoid compiler warning in non-assert builds.
@ 2023-07-22 14:33  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 4+ messages in thread

From: Tom Lane @ 2023-07-22 14:33 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Avoid compiler warning in non-assert builds.

After 3c90dcd03, try_partitionwise_join's child_joinrelids
variable is read only in an Assert, provoking a compiler
warning in non-assert builds.  Rearrange code to avoid the
warning and eliminate unnecessary work in the non-assert case.

Per CI testing (via Jeff Davis and Bharath Rupireddy)

Discussion: https://postgr.es/m/ef0de9713e605451f1b60b30648c5ee900b2394c.camel@j-davis.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bda97e47afaeaab6236f37993ce45bb369add3e5

Modified Files
--------------
src/backend/optimizer/path/joinrels.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Avoid compiler warning in non-assert builds
@ 2023-10-26 08:33  Amit Langote <amitlan@postgresql.org>
  0 siblings, 0 replies; 4+ messages in thread

From: Amit Langote @ 2023-10-26 08:33 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Avoid compiler warning in non-assert builds

After 01575ad788e3, expand_single_inheritance_child()'s parentOID
variable is read only in an Assert, provoking a compiler warning in
non-assert builds.  Fix that by marking the variable with
PG_USED_FOR_ASSERTS_ONLY.

Per report and suggestion from David Rowley

Discussion: https://postgr.es/m/CAApHDvpjA_8Wxu4DCTRVAvPxC9atwMe6N%2ByvrcGsgb7mrfdpJA%40mail.gmail.com

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2bf99b48ded8288fa1c5f53a0c3581059a112d0c

Modified Files
--------------
src/backend/optimizer/util/inherit.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Avoid compiler warning in non-assert builds
@ 2023-10-26 08:33  Amit Langote <amitlan@postgresql.org>
  0 siblings, 0 replies; 4+ messages in thread

From: Amit Langote @ 2023-10-26 08:33 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Avoid compiler warning in non-assert builds

After 01575ad788e3, expand_single_inheritance_child()'s parentOID
variable is read only in an Assert, provoking a compiler warning in
non-assert builds.  Fix that by marking the variable with
PG_USED_FOR_ASSERTS_ONLY.

Per report and suggestion from David Rowley

Discussion: https://postgr.es/m/CAApHDvpjA_8Wxu4DCTRVAvPxC9atwMe6N%2ByvrcGsgb7mrfdpJA%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1f06b7fc6e2bc505bea046ca54a4555ca835d7c9

Modified Files
--------------
src/backend/optimizer/util/inherit.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2023-10-26 08:33 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-07-22 14:33 pgsql: Avoid compiler warning in non-assert builds. Tom Lane <tgl@sss.pgh.pa.us>
2023-07-22 14:33 pgsql: Avoid compiler warning in non-assert builds. Tom Lane <tgl@sss.pgh.pa.us>
2023-10-26 08:33 pgsql: Avoid compiler warning in non-assert builds Amit Langote <amitlan@postgresql.org>
2023-10-26 08:33 pgsql: Avoid compiler warning in non-assert builds Amit Langote <amitlan@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox