pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix RLS policy usage in MERGE.
3+ messages / 1 participants
[nested] [flat]

* pgsql: Fix RLS policy usage in MERGE.
@ 2023-08-07 08:32  Dean Rasheed <dean.a.rasheed@gmail.com>
  0 siblings, 0 replies; 3+ messages in thread

From: Dean Rasheed @ 2023-08-07 08:32 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix RLS policy usage in MERGE.

If MERGE executes an UPDATE action on a table with row-level security,
the code incorrectly applied the WITH CHECK clauses from the target
table's INSERT policies to new rows, instead of the clauses from the
table's UPDATE policies. In addition, it failed to check new rows
against the target table's SELECT policies, if SELECT permissions were
required (likely to always be the case).

In addition, if MERGE executes a DO NOTHING action for matched rows,
the code incorrectly applied the USING clauses from the target table's
DELETE policies to existing target tuples. These policies were applied
as checks that would throw an error, if they did not pass.

Fix this, so that a MERGE UPDATE action applies the same RLS policies
as a plain UPDATE query with a WHERE clause, and a DO NOTHING action
does not apply any RLS checks (other than adding clauses from SELECT
policies to the join).

Back-patch to v15, where MERGE was introduced.

Dean Rasheed, reviewed by Stephen Frost.

Security: CVE-2023-39418

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cb2ae5741f2458a474ed3c31458d242e678ff229

Modified Files
--------------
src/backend/executor/nodeModifyTable.c    |  7 +--
src/backend/rewrite/rowsecurity.c         | 85 ++++++++++++++++++++++---------
src/test/regress/expected/rowsecurity.out | 58 ++++++++++++++++-----
src/test/regress/sql/rowsecurity.sql      | 52 +++++++++++++++----
4 files changed, 152 insertions(+), 50 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Fix RLS policy usage in MERGE.
@ 2023-08-07 08:32  Dean Rasheed <dean.a.rasheed@gmail.com>
  0 siblings, 0 replies; 3+ messages in thread

From: Dean Rasheed @ 2023-08-07 08:32 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix RLS policy usage in MERGE.

If MERGE executes an UPDATE action on a table with row-level security,
the code incorrectly applied the WITH CHECK clauses from the target
table's INSERT policies to new rows, instead of the clauses from the
table's UPDATE policies. In addition, it failed to check new rows
against the target table's SELECT policies, if SELECT permissions were
required (likely to always be the case).

In addition, if MERGE executes a DO NOTHING action for matched rows,
the code incorrectly applied the USING clauses from the target table's
DELETE policies to existing target tuples. These policies were applied
as checks that would throw an error, if they did not pass.

Fix this, so that a MERGE UPDATE action applies the same RLS policies
as a plain UPDATE query with a WHERE clause, and a DO NOTHING action
does not apply any RLS checks (other than adding clauses from SELECT
policies to the join).

Back-patch to v15, where MERGE was introduced.

Dean Rasheed, reviewed by Stephen Frost.

Security: CVE-2023-39418

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/67a007dc0cdb8578726c2000a7abc513109cb4a2

Modified Files
--------------
src/backend/executor/nodeModifyTable.c    |  7 +--
src/backend/rewrite/rowsecurity.c         | 85 ++++++++++++++++++++++---------
src/test/regress/expected/rowsecurity.out | 58 ++++++++++++++++-----
src/test/regress/sql/rowsecurity.sql      | 52 +++++++++++++++----
4 files changed, 152 insertions(+), 50 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Fix RLS policy usage in MERGE.
@ 2023-08-07 08:32  Dean Rasheed <dean.a.rasheed@gmail.com>
  0 siblings, 0 replies; 3+ messages in thread

From: Dean Rasheed @ 2023-08-07 08:32 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix RLS policy usage in MERGE.

If MERGE executes an UPDATE action on a table with row-level security,
the code incorrectly applied the WITH CHECK clauses from the target
table's INSERT policies to new rows, instead of the clauses from the
table's UPDATE policies. In addition, it failed to check new rows
against the target table's SELECT policies, if SELECT permissions were
required (likely to always be the case).

In addition, if MERGE executes a DO NOTHING action for matched rows,
the code incorrectly applied the USING clauses from the target table's
DELETE policies to existing target tuples. These policies were applied
as checks that would throw an error, if they did not pass.

Fix this, so that a MERGE UPDATE action applies the same RLS policies
as a plain UPDATE query with a WHERE clause, and a DO NOTHING action
does not apply any RLS checks (other than adding clauses from SELECT
policies to the join).

Back-patch to v15, where MERGE was introduced.

Dean Rasheed, reviewed by Stephen Frost.

Security: CVE-2023-39418

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c2e08b04c9e71ac6aabdc7d9b3f8e785e164d770

Modified Files
--------------
src/backend/executor/nodeModifyTable.c    |  7 +--
src/backend/rewrite/rowsecurity.c         | 85 ++++++++++++++++++++++---------
src/test/regress/expected/rowsecurity.out | 58 ++++++++++++++++-----
src/test/regress/sql/rowsecurity.sql      | 52 +++++++++++++++----
4 files changed, 152 insertions(+), 50 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2023-08-07 08:32 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-08-07 08:32 pgsql: Fix RLS policy usage in MERGE. Dean Rasheed <dean.a.rasheed@gmail.com>
2023-08-07 08:32 pgsql: Fix RLS policy usage in MERGE. Dean Rasheed <dean.a.rasheed@gmail.com>
2023-08-07 08:32 pgsql: Fix RLS policy usage in MERGE. Dean Rasheed <dean.a.rasheed@gmail.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox