pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix last remaining uninitialized memory warnings
2+ messages / 2 participants
[nested] [flat]

* pgsql: Fix last remaining uninitialized memory warnings
@ 2023-08-09 08:05 Peter Eisentraut <peter@eisentraut.org>
  2023-08-10 00:30 ` Re: pgsql: Fix last remaining uninitialized memory warnings Peter Smith <smithpb2250@gmail.com>
  0 siblings, 1 reply; 2+ messages in thread

From: Peter Eisentraut @ 2023-08-09 08:05 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix last remaining uninitialized memory warnings

gcc (version 13) fails to properly analyze the code due to the loop
stop condition including `l != NULL`. Let's just help it out.

Author: Tristan Partin <tristan@neon.tech>
Discussion: https://www.postgresql.org/message-id/flat/CT6HJ3U8068R.3A8SJMV02D9BC@gonk

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4a8fef0d733965c1a1836022f8a42ab1e83a721f

Modified Files
--------------
src/bin/pgbench/pgbench.c | 2 +-
src/bin/pgbench/pgbench.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: pgsql: Fix last remaining uninitialized memory warnings
  2023-08-09 08:05 pgsql: Fix last remaining uninitialized memory warnings Peter Eisentraut <peter@eisentraut.org>
@ 2023-08-10 00:30 ` Peter Smith <smithpb2250@gmail.com>
  0 siblings, 0 replies; 2+ messages in thread

From: Peter Smith @ 2023-08-10 00:30 UTC (permalink / raw)
  To: Peter Eisentraut <peter@eisentraut.org>; +Cc: pgsql-committers@lists.postgresql.org

FYI - When building the latest HEAD I noticed some compiler warnings
that seem related to this change

pgbench.c: In function ‘evalStandardFunc’:
pgbench.c:2242:2: warning: missing braces around initializer [-Wmissing-braces]
  PgBenchValue vargs[MAX_FARGS] = { 0 };
  ^
pgbench.c:2242:2: warning: (near initialization for ‘vargs[0]’)
[-Wmissing-braces]

------
Kind Regards,
Peter Smith.
Fujitsu Australia

On Wed, Aug 9, 2023 at 6:05 PM Peter Eisentraut <peter@eisentraut.org> wrote:
>
> Fix last remaining uninitialized memory warnings
>
> gcc (version 13) fails to properly analyze the code due to the loop
> stop condition including `l != NULL`. Let's just help it out.
>
> Author: Tristan Partin <tristan@neon.tech>
> Discussion: https://www.postgresql.org/message-id/flat/CT6HJ3U8068R.3A8SJMV02D9BC@gonk
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/4a8fef0d733965c1a1836022f8a42ab1e83a721f
>
> Modified Files
> --------------
> src/bin/pgbench/pgbench.c | 2 +-
> src/bin/pgbench/pgbench.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>





^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2023-08-10 00:30 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-08-09 08:05 pgsql: Fix last remaining uninitialized memory warnings Peter Eisentraut <peter@eisentraut.org>
2023-08-10 00:30 ` Peter Smith <smithpb2250@gmail.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox