pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: ci: macos: Remove use of -DRANDOMIZE_ALLOCATED_MEMORY
2+ messages / 1 participants
[nested] [flat]

* pgsql: ci: macos: Remove use of -DRANDOMIZE_ALLOCATED_MEMORY
@ 2023-08-12 22:12  Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 2+ messages in thread

From: Andres Freund @ 2023-08-12 22:12 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

ci: macos: Remove use of -DRANDOMIZE_ALLOCATED_MEMORY

RANDOMIZE_ALLOCATED_MEMORY causes a measurable slowdown. Macos is, by far, the
most expensive platform for CI, therefore it doesn't make sense to run such a
test there.

Ubsan and asan on linux should detect most of the the cases of uninitialized
memory, so it doesn't really seem worth using -DRANDOMIZE_ALLOCATED_MEMORY in
another instance type.

Author: Andres Freund <andres@anarazel.de>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://postgr.es/m/20230808021541.7lbzdefvma7qmn3w@awork3.anarazel.de
Backpatch: 16-, where 89d16b635 added the use of -DRANDOMIZE_ALLOCATED_MEMORY

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4bec616f26f5f39a6819804f2b7992495a1a7a6f

Modified Files
--------------
.cirrus.yml | 1 -
1 file changed, 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: ci: macos: Remove use of -DRANDOMIZE_ALLOCATED_MEMORY
@ 2023-08-12 22:12  Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 2+ messages in thread

From: Andres Freund @ 2023-08-12 22:12 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

ci: macos: Remove use of -DRANDOMIZE_ALLOCATED_MEMORY

RANDOMIZE_ALLOCATED_MEMORY causes a measurable slowdown. Macos is, by far, the
most expensive platform for CI, therefore it doesn't make sense to run such a
test there.

Ubsan and asan on linux should detect most of the the cases of uninitialized
memory, so it doesn't really seem worth using -DRANDOMIZE_ALLOCATED_MEMORY in
another instance type.

Author: Andres Freund <andres@anarazel.de>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://postgr.es/m/20230808021541.7lbzdefvma7qmn3w@awork3.anarazel.de
Backpatch: 16-, where 89d16b635 added the use of -DRANDOMIZE_ALLOCATED_MEMORY

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/17ebbdf7de192c340762cb852ce615aefa191c95

Modified Files
--------------
.cirrus.yml | 1 -
1 file changed, 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2023-08-12 22:12 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-08-12 22:12 pgsql: ci: macos: Remove use of -DRANDOMIZE_ALLOCATED_MEMORY Andres Freund <andres@anarazel.de>
2023-08-12 22:12 pgsql: ci: macos: Remove use of -DRANDOMIZE_ALLOCATED_MEMORY Andres Freund <andres@anarazel.de>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox