pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Meson: check for pg_config_paths.h left over from make 2+ messages / 1 participants [nested] [flat]
* pgsql: Meson: check for pg_config_paths.h left over from make @ 2023-08-23 22:34 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: David Rowley @ 2023-08-23 22:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Meson: check for pg_config_paths.h left over from make The meson build scripts attempt to find files left over from configure and fail, mentioning that "make maintainer-clean" should be run to remove these. This seems to have been done for files generated from configure. pg_config_paths.h is generated during the actual make build, so seems to have been missed. This would result in compilation using the wrong pg_config_paths.h file. Here we just add this file to generated_sources_ac so that meson errors out if pg_config_paths.h exists. Likely this wasn't noticed before because make maintainer-clean will remove pg_config_paths.h, however, people using the MSVC build scripts are more likely to run into issues and they have to manually remove these files and pg_config_paths.h wasn't listed as a conflicting file to remove in the meson log. Backpatch-through: 16, where meson support was added Discussion: https://postgr.es/m/CAApHDvqjYOxZfmLKAOWKFEE7LOr9_E6UA6YNmx9r8nxStcS3gg@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/6ff385f20c4ed2af707d523ceb2bea694668c123 Modified Files -------------- src/port/meson.build | 3 +++ 1 file changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Meson: check for pg_config_paths.h left over from make @ 2023-08-23 22:34 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: David Rowley @ 2023-08-23 22:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Meson: check for pg_config_paths.h left over from make The meson build scripts attempt to find files left over from configure and fail, mentioning that "make maintainer-clean" should be run to remove these. This seems to have been done for files generated from configure. pg_config_paths.h is generated during the actual make build, so seems to have been missed. This would result in compilation using the wrong pg_config_paths.h file. Here we just add this file to generated_sources_ac so that meson errors out if pg_config_paths.h exists. Likely this wasn't noticed before because make maintainer-clean will remove pg_config_paths.h, however, people using the MSVC build scripts are more likely to run into issues and they have to manually remove these files and pg_config_paths.h wasn't listed as a conflicting file to remove in the meson log. Backpatch-through: 16, where meson support was added Discussion: https://postgr.es/m/CAApHDvqjYOxZfmLKAOWKFEE7LOr9_E6UA6YNmx9r8nxStcS3gg@mail.gmail.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5a16984ff1f3556f4bd29723e11d3594f41db90b Modified Files -------------- src/port/meson.build | 3 +++ 1 file changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2023-08-23 22:34 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-08-23 22:34 pgsql: Meson: check for pg_config_paths.h left over from make David Rowley <drowley@postgresql.org> 2023-08-23 22:34 pgsql: Meson: check for pg_config_paths.h left over from make David Rowley <drowley@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox