pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Remove useless if condition
2+ messages / 1 participants
[nested] [flat]

* pgsql: Remove useless if condition
@ 2023-08-29 07:02  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Peter Eisentraut @ 2023-08-29 07:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove useless if condition

We can call GetAttributeCompression() with a NULL argument.  It
handles that internally already.  This change makes all the callers of
GetAttributeCompression() uniform.

Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e4da@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6844d3275ac6b3c35d824f49362d3fe59b30f26b

Modified Files
--------------
src/backend/commands/tablecmds.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Remove useless if condition
@ 2023-08-29 07:02  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Peter Eisentraut @ 2023-08-29 07:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove useless if condition

This is useless because these fields are not set anywhere before, so
we can assign them unconditionally.  This also makes this more
consistent with ATExecAddColumn().

Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e4da@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/689c66a84bb75e08462c05ffc18514895b19d48e

Modified Files
--------------
src/backend/commands/tablecmds.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2023-08-29 07:02 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-08-29 07:02 pgsql: Remove useless if condition Peter Eisentraut <peter@eisentraut.org>
2023-08-29 07:02 pgsql: Remove useless if condition Peter Eisentraut <peter@eisentraut.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox