pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Use actual backend IDs in pg_stat_get_backend_idset() and friend
3+ messages / 2 participants
[nested] [flat]

* pgsql: Use actual backend IDs in pg_stat_get_backend_idset() and friend
@ 2022-09-29 16:14  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 3+ messages in thread

From: Tom Lane @ 2022-09-29 16:14 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Use actual backend IDs in pg_stat_get_backend_idset() and friends.

Up to now, the ID values returned by pg_stat_get_backend_idset() and
used by pg_stat_get_backend_activity() and allied functions were just
indexes into a local array of sessions seen by the last stats refresh.
This is problematic for a few reasons.  The "ID" of a session can vary
over its existence, which is surprising.  Also, while these numbers
often match the "backend ID" used for purposes like temp schema
assignment, that isn't reliably true.  We can fairly cheaply switch
things around to make these numbers actually be the sessions' backend
IDs.  The added test case illustrates that with this definition, the
temp schema used by a given session can be obtained given its PID.

While here, delete some dead code that guarded against getting
a NULL return from pgstat_fetch_stat_local_beentry().  That can't
happen as long as the caller is careful to pass an in-range array
index, as all the callers are.  (This code may not have been dead
when written, but it surely is now.)

Nathan Bossart

Discussion: https://postgr.es/m/20220815205811.GA250990@nathanxps13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d7e39d72ca1c6f188b400d7d58813ff5b5b79064

Modified Files
--------------
doc/src/sgml/monitoring.sgml                | 20 ++++++-----
src/backend/utils/activity/backend_status.c | 55 +++++++++++++++++++++++++----
src/backend/utils/adt/pgstatfuncs.c         | 48 +++++++++----------------
src/include/utils/backend_status.h          | 10 +++++-
src/test/regress/expected/stats.out         | 15 ++++++--
src/test/regress/sql/stats.sql              | 10 ++++--
6 files changed, 107 insertions(+), 51 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Use actual backend IDs in pg_stat_get_backend_subxact().
@ 2023-08-30 21:48  Nathan Bossart <nathan@postgresql.org>
  0 siblings, 0 replies; 3+ messages in thread

From: Nathan Bossart @ 2023-08-30 21:48 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Use actual backend IDs in pg_stat_get_backend_subxact().

Unlike the other pg_stat_get_backend* functions,
pg_stat_get_backend_subxact() looks up the backend entry by using
its integer argument as a 1-based index in an internal array.  The
other functions look for the entry with the matching session
backend ID.  These numbers often match, but that isn't reliably
true.

This commit resolves this discrepancy by introducing
pgstat_get_local_beentry_by_backend_id() and using it in
pg_stat_get_backend_subxact().  We cannot use
pgstat_get_beentry_by_backend_id() because it returns a
PgBackendStatus, which lacks the locally computed additions
available in LocalPgBackendStatus that are required by
pg_stat_get_backend_subxact().

Author: Ian Barwick
Reviewed-by: Sami Imseih, Michael Paquier, Robert Haas
Discussion: https://postgr.es/m/CAB8KJ%3Dj-ACb3H4L9a_b3ZG3iCYDW5aEu3WsPAzkm2S7JzS1Few%40mail.gmail.com
Backpatch-through: 16

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d0fe3046eec3913829ccd5010849b25acd25fce4

Modified Files
--------------
src/backend/utils/activity/backend_status.c | 36 +++++++++++++++++++++--------
src/backend/utils/adt/pgstatfuncs.c         |  2 +-
src/include/utils/backend_status.h          |  1 +
3 files changed, 29 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Use actual backend IDs in pg_stat_get_backend_subxact().
@ 2023-08-30 21:48  Nathan Bossart <nathan@postgresql.org>
  0 siblings, 0 replies; 3+ messages in thread

From: Nathan Bossart @ 2023-08-30 21:48 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Use actual backend IDs in pg_stat_get_backend_subxact().

Unlike the other pg_stat_get_backend* functions,
pg_stat_get_backend_subxact() looks up the backend entry by using
its integer argument as a 1-based index in an internal array.  The
other functions look for the entry with the matching session
backend ID.  These numbers often match, but that isn't reliably
true.

This commit resolves this discrepancy by introducing
pgstat_get_local_beentry_by_backend_id() and using it in
pg_stat_get_backend_subxact().  We cannot use
pgstat_get_beentry_by_backend_id() because it returns a
PgBackendStatus, which lacks the locally computed additions
available in LocalPgBackendStatus that are required by
pg_stat_get_backend_subxact().

Author: Ian Barwick
Reviewed-by: Sami Imseih, Michael Paquier, Robert Haas
Discussion: https://postgr.es/m/CAB8KJ%3Dj-ACb3H4L9a_b3ZG3iCYDW5aEu3WsPAzkm2S7JzS1Few%40mail.gmail.com
Backpatch-through: 16

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/133654a05b4367e3e70f7cfe496a4b9386674fcf

Modified Files
--------------
src/backend/utils/activity/backend_status.c | 36 +++++++++++++++++++++--------
src/backend/utils/adt/pgstatfuncs.c         |  2 +-
src/include/utils/backend_status.h          |  1 +
3 files changed, 29 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2023-08-30 21:48 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-09-29 16:14 pgsql: Use actual backend IDs in pg_stat_get_backend_idset() and friend Tom Lane <tgl@sss.pgh.pa.us>
2023-08-30 21:48 pgsql: Use actual backend IDs in pg_stat_get_backend_subxact(). Nathan Bossart <nathan@postgresql.org>
2023-08-30 21:48 pgsql: Use actual backend IDs in pg_stat_get_backend_subxact(). Nathan Bossart <nathan@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox