pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Rename some support functions for pgstat* views. 2+ messages / 1 participants [nested] [flat]
* pgsql: Rename some support functions for pgstat* views. @ 2023-08-30 21:48 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Nathan Bossart @ 2023-08-30 21:48 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rename some support functions for pgstat* views. Presently, pgstat_fetch_stat_beentry() accepts a session's backend ID as its argument, and pgstat_fetch_stat_local_beentry() accepts a 1-based index in an internal array as its argument. The former is typically used wherever a user must provide a backend ID, and the latter is usually used internally when looping over all entries in the array. This difference was first introduced by d7e39d72ca. Before that commit, both functions accepted a 1-based index to the internal array. This commit renames these two functions to make it clear whether they use the backend ID or the 1-based index to look up the entry. This is preparatory work for a follow-up change that will introduce a function for looking up a LocalPgBackendStatus using a backend ID. Reviewed-by: Ian Barwick, Sami Imseih, Michael Paquier, Robert Haas Discussion: https://postgr.es/m/CAB8KJ%3Dj-ACb3H4L9a_b3ZG3iCYDW5aEu3WsPAzkm2S7JzS1Few%40mail.gmail.com Backpatch-through: 16 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/3d51cb5197ea7eabc65f5e0184aae60b8f7f9528 Modified Files -------------- src/backend/utils/activity/backend_status.c | 28 +++++++++++----------- src/backend/utils/adt/pgstatfuncs.c | 36 ++++++++++++++--------------- src/include/utils/backend_status.h | 4 ++-- 3 files changed, 34 insertions(+), 34 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Rename some support functions for pgstat* views. @ 2023-08-30 21:48 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Nathan Bossart @ 2023-08-30 21:48 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rename some support functions for pgstat* views. Presently, pgstat_fetch_stat_beentry() accepts a session's backend ID as its argument, and pgstat_fetch_stat_local_beentry() accepts a 1-based index in an internal array as its argument. The former is typically used wherever a user must provide a backend ID, and the latter is usually used internally when looping over all entries in the array. This difference was first introduced by d7e39d72ca. Before that commit, both functions accepted a 1-based index to the internal array. This commit renames these two functions to make it clear whether they use the backend ID or the 1-based index to look up the entry. This is preparatory work for a follow-up change that will introduce a function for looking up a LocalPgBackendStatus using a backend ID. Reviewed-by: Ian Barwick, Sami Imseih, Michael Paquier, Robert Haas Discussion: https://postgr.es/m/CAB8KJ%3Dj-ACb3H4L9a_b3ZG3iCYDW5aEu3WsPAzkm2S7JzS1Few%40mail.gmail.com Backpatch-through: 16 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8dfa37b797843a83a5756ea3309055e8953e1a86 Modified Files -------------- src/backend/utils/activity/backend_status.c | 28 +++++++++++----------- src/backend/utils/adt/pgstatfuncs.c | 36 ++++++++++++++--------------- src/include/utils/backend_status.h | 4 ++-- 3 files changed, 34 insertions(+), 34 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2023-08-30 21:48 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-08-30 21:48 pgsql: Rename some support functions for pgstat* views. Nathan Bossart <nathan@postgresql.org> 2023-08-30 21:48 pgsql: Rename some support functions for pgstat* views. Nathan Bossart <nathan@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox