pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Track nesting depth correctly when drilling down into RECORD Var
7+ messages / 1 participants
[nested] [flat]

* pgsql: Track nesting depth correctly when drilling down into RECORD Var
@ 2023-09-15 21:02 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2023-09-15 21:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Track nesting depth correctly when drilling down into RECORD Vars.

expandRecordVariable() failed to adjust the parse nesting structure
correctly when recursing to inspect an outer-level Var.  This could
result in assertion failures or core dumps in corner cases.

Likewise, get_name_for_var_field() failed to adjust the deparse
namespace stack correctly when recursing to inspect an outer-level
Var.  In this case the likely result was a "bogus varno" error
while deparsing a view.

Per bug #18077 from Jingzhou Fu.  Back-patch to all supported
branches.

Richard Guo, with some adjustments by me

Discussion: https://postgr.es/m/18077-b9db97c6e0ab45d8@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e0e492e5a928e9c9eda01eeebadcfc36f9f8e7b7

Modified Files
--------------
src/backend/parser/parse_target.c      | 17 +++++++---
src/backend/utils/adt/ruleutils.c      | 37 ++++++++++++---------
src/test/regress/expected/rowtypes.out | 60 ++++++++++++++++++++++++++++++++++
src/test/regress/sql/rowtypes.sql      | 25 ++++++++++++++
4 files changed, 119 insertions(+), 20 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Track nesting depth correctly when drilling down into RECORD Var
@ 2023-09-15 21:02 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2023-09-15 21:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Track nesting depth correctly when drilling down into RECORD Vars.

expandRecordVariable() failed to adjust the parse nesting structure
correctly when recursing to inspect an outer-level Var.  This could
result in assertion failures or core dumps in corner cases.

Likewise, get_name_for_var_field() failed to adjust the deparse
namespace stack correctly when recursing to inspect an outer-level
Var.  In this case the likely result was a "bogus varno" error
while deparsing a view.

Per bug #18077 from Jingzhou Fu.  Back-patch to all supported
branches.

Richard Guo, with some adjustments by me

Discussion: https://postgr.es/m/18077-b9db97c6e0ab45d8@postgresql.org

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/53630f12d39b9c5d98abb7bae4818715306422ed

Modified Files
--------------
src/backend/parser/parse_target.c      | 17 +++++++---
src/backend/utils/adt/ruleutils.c      | 37 ++++++++++++---------
src/test/regress/expected/rowtypes.out | 60 ++++++++++++++++++++++++++++++++++
src/test/regress/sql/rowtypes.sql      | 25 ++++++++++++++
4 files changed, 119 insertions(+), 20 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Track nesting depth correctly when drilling down into RECORD Var
@ 2023-09-15 21:02 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2023-09-15 21:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Track nesting depth correctly when drilling down into RECORD Vars.

expandRecordVariable() failed to adjust the parse nesting structure
correctly when recursing to inspect an outer-level Var.  This could
result in assertion failures or core dumps in corner cases.

Likewise, get_name_for_var_field() failed to adjust the deparse
namespace stack correctly when recursing to inspect an outer-level
Var.  In this case the likely result was a "bogus varno" error
while deparsing a view.

Per bug #18077 from Jingzhou Fu.  Back-patch to all supported
branches.

Richard Guo, with some adjustments by me

Discussion: https://postgr.es/m/18077-b9db97c6e0ab45d8@postgresql.org

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2679a107a152de3f88602a41f8651ec82e4d6205

Modified Files
--------------
src/backend/parser/parse_target.c      | 20 ++++++++----
src/backend/utils/adt/ruleutils.c      | 37 ++++++++++++---------
src/test/regress/expected/rowtypes.out | 60 ++++++++++++++++++++++++++++++++++
src/test/regress/sql/rowtypes.sql      | 25 ++++++++++++++
4 files changed, 120 insertions(+), 22 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Track nesting depth correctly when drilling down into RECORD Var
@ 2023-09-15 21:02 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2023-09-15 21:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Track nesting depth correctly when drilling down into RECORD Vars.

expandRecordVariable() failed to adjust the parse nesting structure
correctly when recursing to inspect an outer-level Var.  This could
result in assertion failures or core dumps in corner cases.

Likewise, get_name_for_var_field() failed to adjust the deparse
namespace stack correctly when recursing to inspect an outer-level
Var.  In this case the likely result was a "bogus varno" error
while deparsing a view.

Per bug #18077 from Jingzhou Fu.  Back-patch to all supported
branches.

Richard Guo, with some adjustments by me

Discussion: https://postgr.es/m/18077-b9db97c6e0ab45d8@postgresql.org

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ae13f8166dc372a94e596f423790a67abd7bf68c

Modified Files
--------------
src/backend/parser/parse_target.c      | 20 ++++++++----
src/backend/utils/adt/ruleutils.c      | 37 ++++++++++++---------
src/test/regress/expected/rowtypes.out | 60 ++++++++++++++++++++++++++++++++++
src/test/regress/sql/rowtypes.sql      | 25 ++++++++++++++
4 files changed, 120 insertions(+), 22 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Track nesting depth correctly when drilling down into RECORD Var
@ 2023-09-15 21:02 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2023-09-15 21:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Track nesting depth correctly when drilling down into RECORD Vars.

expandRecordVariable() failed to adjust the parse nesting structure
correctly when recursing to inspect an outer-level Var.  This could
result in assertion failures or core dumps in corner cases.

Likewise, get_name_for_var_field() failed to adjust the deparse
namespace stack correctly when recursing to inspect an outer-level
Var.  In this case the likely result was a "bogus varno" error
while deparsing a view.

Per bug #18077 from Jingzhou Fu.  Back-patch to all supported
branches.

Richard Guo, with some adjustments by me

Discussion: https://postgr.es/m/18077-b9db97c6e0ab45d8@postgresql.org

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c5b7f791dab95ca14122f7bc09cc729fcaf7e25c

Modified Files
--------------
src/backend/parser/parse_target.c      | 20 ++++++++----
src/backend/utils/adt/ruleutils.c      | 37 ++++++++++++---------
src/test/regress/expected/rowtypes.out | 60 ++++++++++++++++++++++++++++++++++
src/test/regress/sql/rowtypes.sql      | 25 ++++++++++++++
4 files changed, 120 insertions(+), 22 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Track nesting depth correctly when drilling down into RECORD Var
@ 2023-09-15 21:02 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2023-09-15 21:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Track nesting depth correctly when drilling down into RECORD Vars.

expandRecordVariable() failed to adjust the parse nesting structure
correctly when recursing to inspect an outer-level Var.  This could
result in assertion failures or core dumps in corner cases.

Likewise, get_name_for_var_field() failed to adjust the deparse
namespace stack correctly when recursing to inspect an outer-level
Var.  In this case the likely result was a "bogus varno" error
while deparsing a view.

Per bug #18077 from Jingzhou Fu.  Back-patch to all supported
branches.

Richard Guo, with some adjustments by me

Discussion: https://postgr.es/m/18077-b9db97c6e0ab45d8@postgresql.org

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d29812c0c6cd58794cb1c0eb1603a17a1ceb0d0b

Modified Files
--------------
src/backend/parser/parse_target.c      | 20 ++++++++----
src/backend/utils/adt/ruleutils.c      | 37 ++++++++++++---------
src/test/regress/expected/rowtypes.out | 60 ++++++++++++++++++++++++++++++++++
src/test/regress/sql/rowtypes.sql      | 25 ++++++++++++++
4 files changed, 120 insertions(+), 22 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Track nesting depth correctly when drilling down into RECORD Var
@ 2023-09-15 21:02 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2023-09-15 21:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Track nesting depth correctly when drilling down into RECORD Vars.

expandRecordVariable() failed to adjust the parse nesting structure
correctly when recursing to inspect an outer-level Var.  This could
result in assertion failures or core dumps in corner cases.

Likewise, get_name_for_var_field() failed to adjust the deparse
namespace stack correctly when recursing to inspect an outer-level
Var.  In this case the likely result was a "bogus varno" error
while deparsing a view.

Per bug #18077 from Jingzhou Fu.  Back-patch to all supported
branches.

Richard Guo, with some adjustments by me

Discussion: https://postgr.es/m/18077-b9db97c6e0ab45d8@postgresql.org

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a374f6c61681fe072526fc5580df191347bea061

Modified Files
--------------
src/backend/parser/parse_target.c      | 20 +++++++----
src/backend/utils/adt/ruleutils.c      | 37 ++++++++++++--------
src/test/regress/expected/rowtypes.out | 63 ++++++++++++++++++++++++++++++++++
src/test/regress/sql/rowtypes.sql      | 25 ++++++++++++++
4 files changed, 123 insertions(+), 22 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread


end of thread, other threads:[~2023-09-15 21:02 UTC | newest]

Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-09-15 21:02 pgsql: Track nesting depth correctly when drilling down into RECORD Var Tom Lane <tgl@sss.pgh.pa.us>
2023-09-15 21:02 pgsql: Track nesting depth correctly when drilling down into RECORD Var Tom Lane <tgl@sss.pgh.pa.us>
2023-09-15 21:02 pgsql: Track nesting depth correctly when drilling down into RECORD Var Tom Lane <tgl@sss.pgh.pa.us>
2023-09-15 21:02 pgsql: Track nesting depth correctly when drilling down into RECORD Var Tom Lane <tgl@sss.pgh.pa.us>
2023-09-15 21:02 pgsql: Track nesting depth correctly when drilling down into RECORD Var Tom Lane <tgl@sss.pgh.pa.us>
2023-09-15 21:02 pgsql: Track nesting depth correctly when drilling down into RECORD Var Tom Lane <tgl@sss.pgh.pa.us>
2023-09-15 21:02 pgsql: Track nesting depth correctly when drilling down into RECORD Var Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox