pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix assertion failure with PL/Python exceptions
7+ messages / 1 participants
[nested] [flat]

* pgsql: Fix assertion failure with PL/Python exceptions
@ 2023-09-18 23:32 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 7+ messages in thread

From: Michael Paquier @ 2023-09-18 23:32 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix assertion failure with PL/Python exceptions

PLy_elog() was not able to handle correctly cases where a SPI called
failed, which would fill in a DETAIL string able to trigger an
assertion.  We may want to improve this infrastructure so as it is able
to provide any extra detail information provided by an error stack, but
this is left as a future improvement as it could impact existing error
stacks and any applications that depend on them.  For now, the assertion
is removed and a regression test is added to cover the case of a failure
with a detail string.

This problem exists since 2bd78eb8d51c, so backpatch all the way down
with tweaks to the regression tests output added where required.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/18070-ab9c171cbf4ebb0f@postgresql.org
Backpatch-through: 11

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/af5b3c3d1eae94e9584ad1955a20b5a7cd0083c1

Modified Files
--------------
src/pl/plpython/expected/plpython_error.out   | 13 +++++++++++++
src/pl/plpython/expected/plpython_error_5.out | 13 +++++++++++++
src/pl/plpython/plpy_elog.c                   |  3 ---
src/pl/plpython/sql/plpython_error.sql        | 11 +++++++++++
4 files changed, 37 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Fix assertion failure with PL/Python exceptions
@ 2023-09-18 23:32 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 7+ messages in thread

From: Michael Paquier @ 2023-09-18 23:32 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix assertion failure with PL/Python exceptions

PLy_elog() was not able to handle correctly cases where a SPI called
failed, which would fill in a DETAIL string able to trigger an
assertion.  We may want to improve this infrastructure so as it is able
to provide any extra detail information provided by an error stack, but
this is left as a future improvement as it could impact existing error
stacks and any applications that depend on them.  For now, the assertion
is removed and a regression test is added to cover the case of a failure
with a detail string.

This problem exists since 2bd78eb8d51c, so backpatch all the way down
with tweaks to the regression tests output added where required.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/18070-ab9c171cbf4ebb0f@postgresql.org
Backpatch-through: 11

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f171430f089a349cb5694fb43a64579d6a9c2a2b

Modified Files
--------------
src/pl/plpython/expected/plpython_error.out   | 13 +++++++++++++
src/pl/plpython/expected/plpython_error_5.out | 13 +++++++++++++
src/pl/plpython/plpy_elog.c                   |  3 ---
src/pl/plpython/sql/plpython_error.sql        | 11 +++++++++++
4 files changed, 37 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Fix assertion failure with PL/Python exceptions
@ 2023-09-18 23:32 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 7+ messages in thread

From: Michael Paquier @ 2023-09-18 23:32 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix assertion failure with PL/Python exceptions

PLy_elog() was not able to handle correctly cases where a SPI called
failed, which would fill in a DETAIL string able to trigger an
assertion.  We may want to improve this infrastructure so as it is able
to provide any extra detail information provided by an error stack, but
this is left as a future improvement as it could impact existing error
stacks and any applications that depend on them.  For now, the assertion
is removed and a regression test is added to cover the case of a failure
with a detail string.

This problem exists since 2bd78eb8d51c, so backpatch all the way down
with tweaks to the regression tests output added where required.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/18070-ab9c171cbf4ebb0f@postgresql.org
Backpatch-through: 11

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9e0ce80f3d0c217c33034984fce022a329d8961f

Modified Files
--------------
src/pl/plpython/expected/plpython_error.out   | 13 +++++++++++++
src/pl/plpython/expected/plpython_error_5.out | 13 +++++++++++++
src/pl/plpython/plpy_elog.c                   |  3 ---
src/pl/plpython/sql/plpython_error.sql        | 11 +++++++++++
4 files changed, 37 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Fix assertion failure with PL/Python exceptions
@ 2023-09-18 23:32 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 7+ messages in thread

From: Michael Paquier @ 2023-09-18 23:32 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix assertion failure with PL/Python exceptions

PLy_elog() was not able to handle correctly cases where a SPI called
failed, which would fill in a DETAIL string able to trigger an
assertion.  We may want to improve this infrastructure so as it is able
to provide any extra detail information provided by an error stack, but
this is left as a future improvement as it could impact existing error
stacks and any applications that depend on them.  For now, the assertion
is removed and a regression test is added to cover the case of a failure
with a detail string.

This problem exists since 2bd78eb8d51c, so backpatch all the way down
with tweaks to the regression tests output added where required.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/18070-ab9c171cbf4ebb0f@postgresql.org
Backpatch-through: 11

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bb65f3c1b25fa7a7e7afe6d4b2fd68c85dd880da

Modified Files
--------------
src/pl/plpython/expected/plpython_error.out   | 13 +++++++++++++
src/pl/plpython/expected/plpython_error_5.out | 13 +++++++++++++
src/pl/plpython/plpy_elog.c                   |  3 ---
src/pl/plpython/sql/plpython_error.sql        | 11 +++++++++++
4 files changed, 37 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Fix assertion failure with PL/Python exceptions
@ 2023-09-18 23:32 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 7+ messages in thread

From: Michael Paquier @ 2023-09-18 23:32 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix assertion failure with PL/Python exceptions

PLy_elog() was not able to handle correctly cases where a SPI called
failed, which would fill in a DETAIL string able to trigger an
assertion.  We may want to improve this infrastructure so as it is able
to provide any extra detail information provided by an error stack, but
this is left as a future improvement as it could impact existing error
stacks and any applications that depend on them.  For now, the assertion
is removed and a regression test is added to cover the case of a failure
with a detail string.

This problem exists since 2bd78eb8d51c, so backpatch all the way down
with tweaks to the regression tests output added where required.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/18070-ab9c171cbf4ebb0f@postgresql.org
Backpatch-through: 11

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/35e8ba3e54ec01fb705c31061eaeda56ba904354

Modified Files
--------------
src/pl/plpython/expected/plpython_error.out   | 13 +++++++++++++
src/pl/plpython/expected/plpython_error_5.out | 13 +++++++++++++
src/pl/plpython/plpy_elog.c                   |  3 ---
src/pl/plpython/sql/plpython_error.sql        | 11 +++++++++++
4 files changed, 37 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Fix assertion failure with PL/Python exceptions
@ 2023-09-18 23:32 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 7+ messages in thread

From: Michael Paquier @ 2023-09-18 23:32 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix assertion failure with PL/Python exceptions

PLy_elog() was not able to handle correctly cases where a SPI called
failed, which would fill in a DETAIL string able to trigger an
assertion.  We may want to improve this infrastructure so as it is able
to provide any extra detail information provided by an error stack, but
this is left as a future improvement as it could impact existing error
stacks and any applications that depend on them.  For now, the assertion
is removed and a regression test is added to cover the case of a failure
with a detail string.

This problem exists since 2bd78eb8d51c, so backpatch all the way down
with tweaks to the regression tests output added where required.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/18070-ab9c171cbf4ebb0f@postgresql.org
Backpatch-through: 11

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/99d27e55ccac335317aa12a9440a946da915decf

Modified Files
--------------
src/pl/plpython/expected/plpython_error.out   | 13 +++++++++++++
src/pl/plpython/expected/plpython_error_0.out | 13 +++++++++++++
src/pl/plpython/expected/plpython_error_5.out | 13 +++++++++++++
src/pl/plpython/plpy_elog.c                   |  3 ---
src/pl/plpython/sql/plpython_error.sql        | 11 +++++++++++
5 files changed, 50 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Fix assertion failure with PL/Python exceptions
@ 2023-09-18 23:32 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 7+ messages in thread

From: Michael Paquier @ 2023-09-18 23:32 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix assertion failure with PL/Python exceptions

PLy_elog() was not able to handle correctly cases where a SPI called
failed, which would fill in a DETAIL string able to trigger an
assertion.  We may want to improve this infrastructure so as it is able
to provide any extra detail information provided by an error stack, but
this is left as a future improvement as it could impact existing error
stacks and any applications that depend on them.  For now, the assertion
is removed and a regression test is added to cover the case of a failure
with a detail string.

This problem exists since 2bd78eb8d51c, so backpatch all the way down
with tweaks to the regression tests output added where required.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/18070-ab9c171cbf4ebb0f@postgresql.org
Backpatch-through: 11

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ddded779a77368482c22e489ef7eb0a57d205167

Modified Files
--------------
src/pl/plpython/expected/plpython_error.out   | 13 +++++++++++++
src/pl/plpython/expected/plpython_error_0.out | 13 +++++++++++++
src/pl/plpython/expected/plpython_error_5.out | 13 +++++++++++++
src/pl/plpython/plpy_elog.c                   |  3 ---
src/pl/plpython/sql/plpython_error.sql        | 11 +++++++++++
5 files changed, 50 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread


end of thread, other threads:[~2023-09-18 23:32 UTC | newest]

Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-09-18 23:32 pgsql: Fix assertion failure with PL/Python exceptions Michael Paquier <michael@paquier.xyz>
2023-09-18 23:32 pgsql: Fix assertion failure with PL/Python exceptions Michael Paquier <michael@paquier.xyz>
2023-09-18 23:32 pgsql: Fix assertion failure with PL/Python exceptions Michael Paquier <michael@paquier.xyz>
2023-09-18 23:32 pgsql: Fix assertion failure with PL/Python exceptions Michael Paquier <michael@paquier.xyz>
2023-09-18 23:32 pgsql: Fix assertion failure with PL/Python exceptions Michael Paquier <michael@paquier.xyz>
2023-09-18 23:32 pgsql: Fix assertion failure with PL/Python exceptions Michael Paquier <michael@paquier.xyz>
2023-09-18 23:32 pgsql: Fix assertion failure with PL/Python exceptions Michael Paquier <michael@paquier.xyz>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox