pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix vacuumdb to pass buffer-usage-limit with analyze-only mode 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix vacuumdb to pass buffer-usage-limit with analyze-only mode @ 2023-09-21 05:48 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: David Rowley @ 2023-09-21 05:48 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix vacuumdb to pass buffer-usage-limit with analyze-only mode ae78cae3b added the --buffer-usage-limit to vacuumdb to allow it to include the BUFFER_USAGE_LIMIT option in the VACUUM command. Unfortunately, that commit forgot to adjust the code so the option was added to the ANALYZE command when the -Z command line argument was specified. There were no issues with the -z command as that option just adds ANALYZE to the VACUUM command. In passing adjust the code to escape the --buffer-usage-limit option before passing it to the server. It seems nothing beyond a confusing error message could become this lack of escaping as VACUUM cannot be specified in a multi-command string. Reported-by: Ryoga Yoshida Author: Ryoga Yoshida, David Rowley Discussion: https://postgr.es/m/08930c0b541700a5264e5fbf3a685f5a%40oss.nttdata.com Backpatch-through: 16, where ae78cae3b was introduced. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5cfba1ad69c6d43184645419476f6cc62e5dd3c5 Modified Files -------------- src/bin/scripts/vacuumdb.c | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix vacuumdb to pass buffer-usage-limit with analyze-only mode @ 2023-09-21 05:48 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: David Rowley @ 2023-09-21 05:48 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix vacuumdb to pass buffer-usage-limit with analyze-only mode ae78cae3b added the --buffer-usage-limit to vacuumdb to allow it to include the BUFFER_USAGE_LIMIT option in the VACUUM command. Unfortunately, that commit forgot to adjust the code so the option was added to the ANALYZE command when the -Z command line argument was specified. There were no issues with the -z command as that option just adds ANALYZE to the VACUUM command. In passing adjust the code to escape the --buffer-usage-limit option before passing it to the server. It seems nothing beyond a confusing error message could become this lack of escaping as VACUUM cannot be specified in a multi-command string. Reported-by: Ryoga Yoshida Author: Ryoga Yoshida, David Rowley Discussion: https://postgr.es/m/08930c0b541700a5264e5fbf3a685f5a%40oss.nttdata.com Backpatch-through: 16, where ae78cae3b was introduced. Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f7dbdab051d08b1b728b17dbc2b18b7e4f16734c Modified Files -------------- src/bin/scripts/vacuumdb.c | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2023-09-21 05:48 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-09-21 05:48 pgsql: Fix vacuumdb to pass buffer-usage-limit with analyze-only mode David Rowley <drowley@postgresql.org> 2023-09-21 05:48 pgsql: Fix vacuumdb to pass buffer-usage-limit with analyze-only mode David Rowley <drowley@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox