pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Limit to_tsvector_byid's initial array allocation to something s 7+ messages / 1 participants [nested] [flat]
* pgsql: Limit to_tsvector_byid's initial array allocation to something s @ 2023-09-25 15:50 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2023-09-25 15:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Limit to_tsvector_byid's initial array allocation to something sane. The initial estimate of the number of distinct ParsedWords is just that: an estimate. Don't let it exceed what palloc is willing to allocate. If in fact we need more entries, we'll eventually fail trying to enlarge the array. But if we don't, this allows success on inputs that currently draw "invalid memory alloc request size". Per bug #18080 from Uwe Binder. Back-patch to all supported branches. Discussion: https://postgr.es/m/18080-d5c5e58fef8c99b7@postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/cf1c65070a89de1e810ef2c5a2036ca4a56c2fdc Modified Files -------------- src/backend/tsearch/to_tsany.c | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Limit to_tsvector_byid's initial array allocation to something s @ 2023-09-25 15:50 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2023-09-25 15:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Limit to_tsvector_byid's initial array allocation to something sane. The initial estimate of the number of distinct ParsedWords is just that: an estimate. Don't let it exceed what palloc is willing to allocate. If in fact we need more entries, we'll eventually fail trying to enlarge the array. But if we don't, this allows success on inputs that currently draw "invalid memory alloc request size". Per bug #18080 from Uwe Binder. Back-patch to all supported branches. Discussion: https://postgr.es/m/18080-d5c5e58fef8c99b7@postgresql.org Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8465efc1a0e721a070221c4aa83695422922b620 Modified Files -------------- src/backend/tsearch/to_tsany.c | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Limit to_tsvector_byid's initial array allocation to something s @ 2023-09-25 15:50 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2023-09-25 15:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Limit to_tsvector_byid's initial array allocation to something sane. The initial estimate of the number of distinct ParsedWords is just that: an estimate. Don't let it exceed what palloc is willing to allocate. If in fact we need more entries, we'll eventually fail trying to enlarge the array. But if we don't, this allows success on inputs that currently draw "invalid memory alloc request size". Per bug #18080 from Uwe Binder. Back-patch to all supported branches. Discussion: https://postgr.es/m/18080-d5c5e58fef8c99b7@postgresql.org Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/71bb73f60be71085a8f3094a64d0883cef3c0afc Modified Files -------------- src/backend/tsearch/to_tsany.c | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Limit to_tsvector_byid's initial array allocation to something s @ 2023-09-25 15:50 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2023-09-25 15:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Limit to_tsvector_byid's initial array allocation to something sane. The initial estimate of the number of distinct ParsedWords is just that: an estimate. Don't let it exceed what palloc is willing to allocate. If in fact we need more entries, we'll eventually fail trying to enlarge the array. But if we don't, this allows success on inputs that currently draw "invalid memory alloc request size". Per bug #18080 from Uwe Binder. Back-patch to all supported branches. Discussion: https://postgr.es/m/18080-d5c5e58fef8c99b7@postgresql.org Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a2799f53d519d6d7dba236ab02411cd232cea061 Modified Files -------------- src/backend/tsearch/to_tsany.c | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Limit to_tsvector_byid's initial array allocation to something s @ 2023-09-25 15:50 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2023-09-25 15:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Limit to_tsvector_byid's initial array allocation to something sane. The initial estimate of the number of distinct ParsedWords is just that: an estimate. Don't let it exceed what palloc is willing to allocate. If in fact we need more entries, we'll eventually fail trying to enlarge the array. But if we don't, this allows success on inputs that currently draw "invalid memory alloc request size". Per bug #18080 from Uwe Binder. Back-patch to all supported branches. Discussion: https://postgr.es/m/18080-d5c5e58fef8c99b7@postgresql.org Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/52a676ef4fc85f7e81bf0957d36aea53c0bfd230 Modified Files -------------- src/backend/tsearch/to_tsany.c | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Limit to_tsvector_byid's initial array allocation to something s @ 2023-09-25 15:50 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2023-09-25 15:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Limit to_tsvector_byid's initial array allocation to something sane. The initial estimate of the number of distinct ParsedWords is just that: an estimate. Don't let it exceed what palloc is willing to allocate. If in fact we need more entries, we'll eventually fail trying to enlarge the array. But if we don't, this allows success on inputs that currently draw "invalid memory alloc request size". Per bug #18080 from Uwe Binder. Back-patch to all supported branches. Discussion: https://postgr.es/m/18080-d5c5e58fef8c99b7@postgresql.org Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4a81ed29d3c956ad11354c0dc4514f5af4a0d8d7 Modified Files -------------- src/backend/tsearch/to_tsany.c | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Limit to_tsvector_byid's initial array allocation to something s @ 2023-09-25 15:50 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2023-09-25 15:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Limit to_tsvector_byid's initial array allocation to something sane. The initial estimate of the number of distinct ParsedWords is just that: an estimate. Don't let it exceed what palloc is willing to allocate. If in fact we need more entries, we'll eventually fail trying to enlarge the array. But if we don't, this allows success on inputs that currently draw "invalid memory alloc request size". Per bug #18080 from Uwe Binder. Back-patch to all supported branches. Discussion: https://postgr.es/m/18080-d5c5e58fef8c99b7@postgresql.org Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0fb91ed2b0af3fbe1889a6951b4e9f1331e70822 Modified Files -------------- src/backend/tsearch/to_tsany.c | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2023-09-25 15:50 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-09-25 15:50 pgsql: Limit to_tsvector_byid's initial array allocation to something s Tom Lane <tgl@sss.pgh.pa.us> 2023-09-25 15:50 pgsql: Limit to_tsvector_byid's initial array allocation to something s Tom Lane <tgl@sss.pgh.pa.us> 2023-09-25 15:50 pgsql: Limit to_tsvector_byid's initial array allocation to something s Tom Lane <tgl@sss.pgh.pa.us> 2023-09-25 15:50 pgsql: Limit to_tsvector_byid's initial array allocation to something s Tom Lane <tgl@sss.pgh.pa.us> 2023-09-25 15:50 pgsql: Limit to_tsvector_byid's initial array allocation to something s Tom Lane <tgl@sss.pgh.pa.us> 2023-09-25 15:50 pgsql: Limit to_tsvector_byid's initial array allocation to something s Tom Lane <tgl@sss.pgh.pa.us> 2023-09-25 15:50 pgsql: Limit to_tsvector_byid's initial array allocation to something s Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox