pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: jit: Adjust back-patch of f90b4a84 to 12 and 13.
2+ messages / 1 participants
[nested] [flat]

* pgsql: jit: Adjust back-patch of f90b4a84 to 12 and 13.
@ 2023-10-23 22:24 Thomas Munro <tmunro@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Thomas Munro @ 2023-10-23 22:24 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

jit: Adjust back-patch of f90b4a84 to 12 and 13.

While back-patching f90b4a84, I missed that branches before
REL_14_STABLE did some (accidental?) type punning in a function
parameter, and failed to adjust these two branches accordingly.  That
didn't seem to cause a problem for newer LLVM versions or non-debug
builds, but older debug builds would fail a type cross-check assertion.
Fix by supplying the correct function argument type.  In REL_14_STABLE
the same change was made by commit df99ddc7.

Per build farm animal xenodermus, which runs a debug build of LLVM 6
with jit_above_cost=0.

Discussion: https://postgr.es/m/CA%2BhUKGLQ38rgZ3bvNHXPRjsWFAg3pa%3Dtnpeq0osa%2B%3DmiFD5jAw%40mail.gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7c070e224c4abbe73eec6bb2917200379c9f8166

Modified Files
--------------
src/backend/jit/llvm/llvmjit_expr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: jit: Adjust back-patch of f90b4a84 to 12 and 13.
@ 2023-10-23 22:24 Thomas Munro <tmunro@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Thomas Munro @ 2023-10-23 22:24 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

jit: Adjust back-patch of f90b4a84 to 12 and 13.

While back-patching f90b4a84, I missed that branches before
REL_14_STABLE did some (accidental?) type punning in a function
parameter, and failed to adjust these two branches accordingly.  That
didn't seem to cause a problem for newer LLVM versions or non-debug
builds, but older debug builds would fail a type cross-check assertion.
Fix by supplying the correct function argument type.  In REL_14_STABLE
the same change was made by commit df99ddc7.

Per build farm animal xenodermus, which runs a debug build of LLVM 6
with jit_above_cost=0.

Discussion: https://postgr.es/m/CA%2BhUKGLQ38rgZ3bvNHXPRjsWFAg3pa%3Dtnpeq0osa%2B%3DmiFD5jAw%40mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9ad98627614bfd603654e1a57c386a84b8834dc5

Modified Files
--------------
src/backend/jit/llvm/llvmjit_expr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2023-10-23 22:24 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-10-23 22:24 pgsql: jit: Adjust back-patch of f90b4a84 to 12 and 13. Thomas Munro <tmunro@postgresql.org>
2023-10-23 22:24 pgsql: jit: Adjust back-patch of f90b4a84 to 12 and 13. Thomas Munro <tmunro@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox