pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Prevent duplicate RTEPermissionInfo for plain-inheritance parent
5+ messages / 3 participants
[nested] [flat]

* pgsql: Prevent duplicate RTEPermissionInfo for plain-inheritance parent
@ 2023-10-26 02:59  Amit Langote <amitlan@postgresql.org>
  0 siblings, 1 reply; 5+ messages in thread

From: Amit Langote @ 2023-10-26 02:59 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Prevent duplicate RTEPermissionInfo for plain-inheritance parents

Currently, expand_single_inheritance_child() doesn't reset
perminfoindex in a plain-inheritance parent's child RTE, because
prior to 387f9ed0a0, the executor would use the first child RTE to
locate the parent's RTEPermissionInfo.  That in turn causes
add_rte_to_flat_rtable() to create an extra RTEPermissionInfo
belonging to the parent's child RTE with the same content as the one
belonging to the parent's original ("root") RTE.

In 387f9ed0a0, we changed things so that the executor can now use the
parent's "root" RTE for locating its RTEPermissionInfo instead of the
child RTE, so the latter's perminfoindex need not be set anymore, so
make it so.

Reported-by: Tom Lane
Discussion: https://postgr.es/m/839708.1698174464@sss.pgh.pa.us
Backpatch-through: 16

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/01575ad788e3d3e67b641d43802c8b7bf126a1a3

Modified Files
--------------
src/backend/optimizer/util/inherit.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: Prevent duplicate RTEPermissionInfo for plain-inheritance parent
@ 2023-10-26 02:59  Amit Langote <amitlan@postgresql.org>
  0 siblings, 0 replies; 5+ messages in thread

From: Amit Langote @ 2023-10-26 02:59 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Prevent duplicate RTEPermissionInfo for plain-inheritance parents

Currently, expand_single_inheritance_child() doesn't reset
perminfoindex in a plain-inheritance parent's child RTE, because
prior to 387f9ed0a0, the executor would use the first child RTE to
locate the parent's RTEPermissionInfo.  That in turn causes
add_rte_to_flat_rtable() to create an extra RTEPermissionInfo
belonging to the parent's child RTE with the same content as the one
belonging to the parent's original ("root") RTE.

In 387f9ed0a0, we changed things so that the executor can now use the
parent's "root" RTE for locating its RTEPermissionInfo instead of the
child RTE, so the latter's perminfoindex need not be set anymore, so
make it so.

Reported-by: Tom Lane
Discussion: https://postgr.es/m/839708.1698174464@sss.pgh.pa.us
Backpatch-through: 16

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/178ee1d858d89f6d86f42a84bd4b8014ddfa7245

Modified Files
--------------
src/backend/optimizer/util/inherit.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: pgsql: Prevent duplicate RTEPermissionInfo for plain-inheritance parent
@ 2023-10-26 06:08  David Rowley <dgrowleyml@gmail.com>
  parent: Amit Langote <amitlan@postgresql.org>
  0 siblings, 1 reply; 5+ messages in thread

From: David Rowley @ 2023-10-26 06:08 UTC (permalink / raw)
  To: Amit Langote <amitlan@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org

On Thu, 26 Oct 2023 at 15:59, Amit Langote <amitlan@postgresql.org> wrote:
> src/backend/optimizer/util/inherit.c | 9 ++-------

Hi Amit,

I'm getting an unused variable warning from this with non-assert builds:

[697/1908] Compiling C object
src/backend/postgres_lib.a.p/optimizer_util_inherit.c.o
../src/backend/optimizer/util/inherit.c: In function
‘expand_single_inheritance_child’:
../src/backend/optimizer/util/inherit.c:460:33: warning: unused
variable ‘parentOID’ [-Wunused-variable]
  460 |         Oid                     parentOID = RelationGetRelid(parentrel);
      |                                 ^~~~~~~~~

Maybe parentOID needs a PG_USED_FOR_ASSERTS_ONLY?

David





^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: pgsql: Prevent duplicate RTEPermissionInfo for plain-inheritance parent
@ 2023-10-26 07:59  Amit Langote <amitlangote09@gmail.com>
  parent: David Rowley <dgrowleyml@gmail.com>
  0 siblings, 1 reply; 5+ messages in thread

From: Amit Langote @ 2023-10-26 07:59 UTC (permalink / raw)
  To: David Rowley <dgrowleyml@gmail.com>; +Cc: Amit Langote <amitlan@postgresql.org>; pgsql-committers@lists.postgresql.org

On Thu, Oct 26, 2023 at 3:08 PM David Rowley <dgrowleyml@gmail.com> wrote:
> On Thu, 26 Oct 2023 at 15:59, Amit Langote <amitlan@postgresql.org> wrote:
> > src/backend/optimizer/util/inherit.c | 9 ++-------
>
> Hi Amit,
>
> I'm getting an unused variable warning from this with non-assert builds:
>
> [697/1908] Compiling C object
> src/backend/postgres_lib.a.p/optimizer_util_inherit.c.o
> ../src/backend/optimizer/util/inherit.c: In function
> ‘expand_single_inheritance_child’:
> ../src/backend/optimizer/util/inherit.c:460:33: warning: unused
> variable ‘parentOID’ [-Wunused-variable]
>   460 |         Oid                     parentOID = RelationGetRelid(parentrel);
>       |                                 ^~~~~~~~~

Thanks for the heads up?

> Maybe parentOID needs a PG_USED_FOR_ASSERTS_ONLY?

Hmm, how about simply removing the variable?

-- 
Thanks, Amit Langote
EDB: http://www.enterprisedb.com





^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: pgsql: Prevent duplicate RTEPermissionInfo for plain-inheritance parent
@ 2023-10-26 08:08  Amit Langote <amitlangote09@gmail.com>
  parent: Amit Langote <amitlangote09@gmail.com>
  0 siblings, 0 replies; 5+ messages in thread

From: Amit Langote @ 2023-10-26 08:08 UTC (permalink / raw)
  To: David Rowley <dgrowleyml@gmail.com>; +Cc: Amit Langote <amitlan@postgresql.org>; pgsql-committers@lists.postgresql.org

On Thu, Oct 26, 2023 at 4:59 PM Amit Langote <amitlangote09@gmail.com> wrote:
> On Thu, Oct 26, 2023 at 3:08 PM David Rowley <dgrowleyml@gmail.com> wrote:
> > On Thu, 26 Oct 2023 at 15:59, Amit Langote <amitlan@postgresql.org> wrote:
> > > src/backend/optimizer/util/inherit.c | 9 ++-------
> >
> > Hi Amit,
> >
> > I'm getting an unused variable warning from this with non-assert builds:
> >
> > [697/1908] Compiling C object
> > src/backend/postgres_lib.a.p/optimizer_util_inherit.c.o
> > ../src/backend/optimizer/util/inherit.c: In function
> > ‘expand_single_inheritance_child’:
> > ../src/backend/optimizer/util/inherit.c:460:33: warning: unused
> > variable ‘parentOID’ [-Wunused-variable]
> >   460 |         Oid                     parentOID = RelationGetRelid(parentrel);
> >       |                                 ^~~~~~~~~
>
> Thanks for the heads up?

Oops, wasn't a question. :)

> > Maybe parentOID needs a PG_USED_FOR_ASSERTS_ONLY?
>
> Hmm, how about simply removing the variable?

Actually, using PG_USED_FOR_ASSERTS_ONLY seems fine.  I will push a fix shortly.

-- 
Thanks, Amit Langote
EDB: http://www.enterprisedb.com





^ permalink  raw  reply  [nested|flat] 5+ messages in thread


end of thread, other threads:[~2023-10-26 08:08 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-10-26 02:59 pgsql: Prevent duplicate RTEPermissionInfo for plain-inheritance parent Amit Langote <amitlan@postgresql.org>
2023-10-26 06:08 ` David Rowley <dgrowleyml@gmail.com>
2023-10-26 07:59   ` Amit Langote <amitlangote09@gmail.com>
2023-10-26 08:08     ` Amit Langote <amitlangote09@gmail.com>
2023-10-26 02:59 pgsql: Prevent duplicate RTEPermissionInfo for plain-inheritance parent Amit Langote <amitlan@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox