pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: btree_gin: Fix calculation of leftmost interval value.
7+ messages / 1 participants
[nested] [flat]

* pgsql: btree_gin: Fix calculation of leftmost interval value.
@ 2023-10-29 11:23 Dean Rasheed <dean.a.rasheed@gmail.com>
  0 siblings, 0 replies; 7+ messages in thread

From: Dean Rasheed @ 2023-10-29 11:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

btree_gin: Fix calculation of leftmost interval value.

Formerly, the value computed by leftmostvalue_interval() was a long
way short of the minimum possible interval value.  As a result, an
index scan on a GIN index on an interval column with < or <= operators
would miss large negative interval values.

Fix by setting all fields of the leftmost interval to their minimum
values, ensuring that the result is less than any other possible
interval.  Since this only affects index searches, no index rebuild is
necessary.

Back-patch to all supported branches.

Dean Rasheed, reviewed by Heikki Linnakangas.

Discussion: https://postgr.es/m/CAEZATCV80%2BgOfF8ehNUUfaKBZgZMDfCfL-g1HhWGb6kC3rpDfw%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/849172ff4883d44168f96f39d3fde96d0aa34c99

Modified Files
--------------
contrib/btree_gin/btree_gin.c           |  6 +++---
contrib/btree_gin/expected/interval.out | 16 +++++++++++-----
contrib/btree_gin/sql/interval.sql      |  4 +++-
3 files changed, 17 insertions(+), 9 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: btree_gin: Fix calculation of leftmost interval value.
@ 2023-10-29 11:23 Dean Rasheed <dean.a.rasheed@gmail.com>
  0 siblings, 0 replies; 7+ messages in thread

From: Dean Rasheed @ 2023-10-29 11:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

btree_gin: Fix calculation of leftmost interval value.

Formerly, the value computed by leftmostvalue_interval() was a long
way short of the minimum possible interval value.  As a result, an
index scan on a GIN index on an interval column with < or <= operators
would miss large negative interval values.

Fix by setting all fields of the leftmost interval to their minimum
values, ensuring that the result is less than any other possible
interval.  Since this only affects index searches, no index rebuild is
necessary.

Back-patch to all supported branches.

Dean Rasheed, reviewed by Heikki Linnakangas.

Discussion: https://postgr.es/m/CAEZATCV80%2BgOfF8ehNUUfaKBZgZMDfCfL-g1HhWGb6kC3rpDfw%40mail.gmail.com

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ab73a37e9e1e5308f4dbb81902125b484f9c5432

Modified Files
--------------
contrib/btree_gin/btree_gin.c           |  6 +++---
contrib/btree_gin/expected/interval.out | 16 +++++++++++-----
contrib/btree_gin/sql/interval.sql      |  4 +++-
3 files changed, 17 insertions(+), 9 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: btree_gin: Fix calculation of leftmost interval value.
@ 2023-10-29 11:23 Dean Rasheed <dean.a.rasheed@gmail.com>
  0 siblings, 0 replies; 7+ messages in thread

From: Dean Rasheed @ 2023-10-29 11:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

btree_gin: Fix calculation of leftmost interval value.

Formerly, the value computed by leftmostvalue_interval() was a long
way short of the minimum possible interval value.  As a result, an
index scan on a GIN index on an interval column with < or <= operators
would miss large negative interval values.

Fix by setting all fields of the leftmost interval to their minimum
values, ensuring that the result is less than any other possible
interval.  Since this only affects index searches, no index rebuild is
necessary.

Back-patch to all supported branches.

Dean Rasheed, reviewed by Heikki Linnakangas.

Discussion: https://postgr.es/m/CAEZATCV80%2BgOfF8ehNUUfaKBZgZMDfCfL-g1HhWGb6kC3rpDfw%40mail.gmail.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5f06918399f07d46c15756bea84d8d5665ebfa57

Modified Files
--------------
contrib/btree_gin/btree_gin.c           |  6 +++---
contrib/btree_gin/expected/interval.out | 16 +++++++++++-----
contrib/btree_gin/sql/interval.sql      |  4 +++-
3 files changed, 17 insertions(+), 9 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: btree_gin: Fix calculation of leftmost interval value.
@ 2023-10-29 11:23 Dean Rasheed <dean.a.rasheed@gmail.com>
  0 siblings, 0 replies; 7+ messages in thread

From: Dean Rasheed @ 2023-10-29 11:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

btree_gin: Fix calculation of leftmost interval value.

Formerly, the value computed by leftmostvalue_interval() was a long
way short of the minimum possible interval value.  As a result, an
index scan on a GIN index on an interval column with < or <= operators
would miss large negative interval values.

Fix by setting all fields of the leftmost interval to their minimum
values, ensuring that the result is less than any other possible
interval.  Since this only affects index searches, no index rebuild is
necessary.

Back-patch to all supported branches.

Dean Rasheed, reviewed by Heikki Linnakangas.

Discussion: https://postgr.es/m/CAEZATCV80%2BgOfF8ehNUUfaKBZgZMDfCfL-g1HhWGb6kC3rpDfw%40mail.gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/162b38a0683960c115954694cd7be56dec5bfe33

Modified Files
--------------
contrib/btree_gin/btree_gin.c           |  6 +++---
contrib/btree_gin/expected/interval.out | 16 +++++++++++-----
contrib/btree_gin/sql/interval.sql      |  4 +++-
3 files changed, 17 insertions(+), 9 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: btree_gin: Fix calculation of leftmost interval value.
@ 2023-10-29 11:23 Dean Rasheed <dean.a.rasheed@gmail.com>
  0 siblings, 0 replies; 7+ messages in thread

From: Dean Rasheed @ 2023-10-29 11:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

btree_gin: Fix calculation of leftmost interval value.

Formerly, the value computed by leftmostvalue_interval() was a long
way short of the minimum possible interval value.  As a result, an
index scan on a GIN index on an interval column with < or <= operators
would miss large negative interval values.

Fix by setting all fields of the leftmost interval to their minimum
values, ensuring that the result is less than any other possible
interval.  Since this only affects index searches, no index rebuild is
necessary.

Back-patch to all supported branches.

Dean Rasheed, reviewed by Heikki Linnakangas.

Discussion: https://postgr.es/m/CAEZATCV80%2BgOfF8ehNUUfaKBZgZMDfCfL-g1HhWGb6kC3rpDfw%40mail.gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/35e6a5c20d453921efa24342effb648cad3573ec

Modified Files
--------------
contrib/btree_gin/btree_gin.c           |  6 +++---
contrib/btree_gin/expected/interval.out | 16 +++++++++++-----
contrib/btree_gin/sql/interval.sql      |  4 +++-
3 files changed, 17 insertions(+), 9 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: btree_gin: Fix calculation of leftmost interval value.
@ 2023-10-29 11:23 Dean Rasheed <dean.a.rasheed@gmail.com>
  0 siblings, 0 replies; 7+ messages in thread

From: Dean Rasheed @ 2023-10-29 11:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

btree_gin: Fix calculation of leftmost interval value.

Formerly, the value computed by leftmostvalue_interval() was a long
way short of the minimum possible interval value.  As a result, an
index scan on a GIN index on an interval column with < or <= operators
would miss large negative interval values.

Fix by setting all fields of the leftmost interval to their minimum
values, ensuring that the result is less than any other possible
interval.  Since this only affects index searches, no index rebuild is
necessary.

Back-patch to all supported branches.

Dean Rasheed, reviewed by Heikki Linnakangas.

Discussion: https://postgr.es/m/CAEZATCV80%2BgOfF8ehNUUfaKBZgZMDfCfL-g1HhWGb6kC3rpDfw%40mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f7cd7b265f6f96689a42d61f1e312554e1ff9fa8

Modified Files
--------------
contrib/btree_gin/btree_gin.c           |  6 +++---
contrib/btree_gin/expected/interval.out | 16 +++++++++++-----
contrib/btree_gin/sql/interval.sql      |  4 +++-
3 files changed, 17 insertions(+), 9 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: btree_gin: Fix calculation of leftmost interval value.
@ 2023-10-29 11:23 Dean Rasheed <dean.a.rasheed@gmail.com>
  0 siblings, 0 replies; 7+ messages in thread

From: Dean Rasheed @ 2023-10-29 11:23 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

btree_gin: Fix calculation of leftmost interval value.

Formerly, the value computed by leftmostvalue_interval() was a long
way short of the minimum possible interval value.  As a result, an
index scan on a GIN index on an interval column with < or <= operators
would miss large negative interval values.

Fix by setting all fields of the leftmost interval to their minimum
values, ensuring that the result is less than any other possible
interval.  Since this only affects index searches, no index rebuild is
necessary.

Back-patch to all supported branches.

Dean Rasheed, reviewed by Heikki Linnakangas.

Discussion: https://postgr.es/m/CAEZATCV80%2BgOfF8ehNUUfaKBZgZMDfCfL-g1HhWGb6kC3rpDfw%40mail.gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c804ffb5622b5efe7bda78570aa1911073a7491d

Modified Files
--------------
contrib/btree_gin/btree_gin.c           |  6 +++---
contrib/btree_gin/expected/interval.out | 16 +++++++++++-----
contrib/btree_gin/sql/interval.sql      |  4 +++-
3 files changed, 17 insertions(+), 9 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread


end of thread, other threads:[~2023-10-29 11:23 UTC | newest]

Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-10-29 11:23 pgsql: btree_gin: Fix calculation of leftmost interval value. Dean Rasheed <dean.a.rasheed@gmail.com>
2023-10-29 11:23 pgsql: btree_gin: Fix calculation of leftmost interval value. Dean Rasheed <dean.a.rasheed@gmail.com>
2023-10-29 11:23 pgsql: btree_gin: Fix calculation of leftmost interval value. Dean Rasheed <dean.a.rasheed@gmail.com>
2023-10-29 11:23 pgsql: btree_gin: Fix calculation of leftmost interval value. Dean Rasheed <dean.a.rasheed@gmail.com>
2023-10-29 11:23 pgsql: btree_gin: Fix calculation of leftmost interval value. Dean Rasheed <dean.a.rasheed@gmail.com>
2023-10-29 11:23 pgsql: btree_gin: Fix calculation of leftmost interval value. Dean Rasheed <dean.a.rasheed@gmail.com>
2023-10-29 11:23 pgsql: btree_gin: Fix calculation of leftmost interval value. Dean Rasheed <dean.a.rasheed@gmail.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox