pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Be more wary about NULL values for GUC string variables. 7+ messages / 1 participants [nested] [flat]
* pgsql: Be more wary about NULL values for GUC string variables. @ 2023-11-02 15:53 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2023-11-02 15:53 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Be more wary about NULL values for GUC string variables. get_explain_guc_options() crashed if a string GUC marked GUC_EXPLAIN has a NULL boot_val. Nosing around found a couple of other places that seemed insufficiently cautious about NULL string values, although those are likely unreachable in practice. Add some commentary defining the expectations for NULL values of string variables, in hopes of forestalling future additions of more such bugs. Xing Guo, Aleksander Alekseev, Tom Lane Discussion: https://postgr.es/m/CACpMh+AyDx5YUpPaAgzVwC1d8zfOL4JoD-uyFDnNSa1z0EsDQQ@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/7704a1a72e879daaefa1742916e01505edd2ce47 Modified Files -------------- src/backend/utils/misc/guc.c | 16 +++++++++++++--- src/include/utils/guc_tables.h | 10 ++++++++++ 2 files changed, 23 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Be more wary about NULL values for GUC string variables. @ 2023-11-02 15:53 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2023-11-02 15:53 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Be more wary about NULL values for GUC string variables. get_explain_guc_options() crashed if a string GUC marked GUC_EXPLAIN has a NULL boot_val. Nosing around found a couple of other places that seemed insufficiently cautious about NULL string values, although those are likely unreachable in practice. Add some commentary defining the expectations for NULL values of string variables, in hopes of forestalling future additions of more such bugs. Xing Guo, Aleksander Alekseev, Tom Lane Discussion: https://postgr.es/m/CACpMh+AyDx5YUpPaAgzVwC1d8zfOL4JoD-uyFDnNSa1z0EsDQQ@mail.gmail.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/82063edd4ac366161d9afa56221c74032b332c39 Modified Files -------------- src/backend/utils/misc/guc.c | 16 +++++++++++++--- src/include/utils/guc_tables.h | 10 ++++++++++ 2 files changed, 23 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Be more wary about NULL values for GUC string variables. @ 2023-11-02 15:53 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2023-11-02 15:53 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Be more wary about NULL values for GUC string variables. get_explain_guc_options() crashed if a string GUC marked GUC_EXPLAIN has a NULL boot_val. Nosing around found a couple of other places that seemed insufficiently cautious about NULL string values, although those are likely unreachable in practice. Add some commentary defining the expectations for NULL values of string variables, in hopes of forestalling future additions of more such bugs. Xing Guo, Aleksander Alekseev, Tom Lane Discussion: https://postgr.es/m/CACpMh+AyDx5YUpPaAgzVwC1d8zfOL4JoD-uyFDnNSa1z0EsDQQ@mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ae33659d4239ac53ba502f44277e6958bcba7981 Modified Files -------------- src/backend/utils/misc/guc.c | 12 ++++++++++-- src/include/utils/guc_tables.h | 10 ++++++++++ 2 files changed, 20 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Be more wary about NULL values for GUC string variables. @ 2023-11-02 15:53 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2023-11-02 15:53 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Be more wary about NULL values for GUC string variables. get_explain_guc_options() crashed if a string GUC marked GUC_EXPLAIN has a NULL boot_val. Nosing around found a couple of other places that seemed insufficiently cautious about NULL string values, although those are likely unreachable in practice. Add some commentary defining the expectations for NULL values of string variables, in hopes of forestalling future additions of more such bugs. Xing Guo, Aleksander Alekseev, Tom Lane Discussion: https://postgr.es/m/CACpMh+AyDx5YUpPaAgzVwC1d8zfOL4JoD-uyFDnNSa1z0EsDQQ@mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/47c0f00cf90f58402c4fa9d9d605ca2fe8132687 Modified Files -------------- src/backend/utils/misc/guc.c | 12 ++++++++++-- src/include/utils/guc_tables.h | 10 ++++++++++ 2 files changed, 20 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Be more wary about NULL values for GUC string variables. @ 2023-11-02 15:53 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2023-11-02 15:53 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Be more wary about NULL values for GUC string variables. get_explain_guc_options() crashed if a string GUC marked GUC_EXPLAIN has a NULL boot_val. Nosing around found a couple of other places that seemed insufficiently cautious about NULL string values, although those are likely unreachable in practice. Add some commentary defining the expectations for NULL values of string variables, in hopes of forestalling future additions of more such bugs. Xing Guo, Aleksander Alekseev, Tom Lane Discussion: https://postgr.es/m/CACpMh+AyDx5YUpPaAgzVwC1d8zfOL4JoD-uyFDnNSa1z0EsDQQ@mail.gmail.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/137227c6de6ecdee3b354f685fdbc2354d4a4f44 Modified Files -------------- src/backend/utils/misc/guc.c | 12 ++++++++++-- src/include/utils/guc_tables.h | 10 ++++++++++ 2 files changed, 20 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Be more wary about NULL values for GUC string variables. @ 2023-11-02 15:53 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2023-11-02 15:53 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Be more wary about NULL values for GUC string variables. get_explain_guc_options() crashed if a string GUC marked GUC_EXPLAIN has a NULL boot_val. Nosing around found a couple of other places that seemed insufficiently cautious about NULL string values, although those are likely unreachable in practice. Add some commentary defining the expectations for NULL values of string variables, in hopes of forestalling future additions of more such bugs. Xing Guo, Aleksander Alekseev, Tom Lane Discussion: https://postgr.es/m/CACpMh+AyDx5YUpPaAgzVwC1d8zfOL4JoD-uyFDnNSa1z0EsDQQ@mail.gmail.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/65810fc6d0f6ccd3166713b9ec2f856be535383f Modified Files -------------- src/backend/utils/misc/guc.c | 12 ++++++++++-- src/include/utils/guc_tables.h | 10 ++++++++++ 2 files changed, 20 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Be more wary about NULL values for GUC string variables. @ 2023-11-02 15:53 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2023-11-02 15:53 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Be more wary about NULL values for GUC string variables. get_explain_guc_options() crashed if a string GUC marked GUC_EXPLAIN has a NULL boot_val. Nosing around found a couple of other places that seemed insufficiently cautious about NULL string values, although those are likely unreachable in practice. Add some commentary defining the expectations for NULL values of string variables, in hopes of forestalling future additions of more such bugs. Xing Guo, Aleksander Alekseev, Tom Lane Discussion: https://postgr.es/m/CACpMh+AyDx5YUpPaAgzVwC1d8zfOL4JoD-uyFDnNSa1z0EsDQQ@mail.gmail.com Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6e1cca5113487bb9ef4daa1bb2833c6333466410 Modified Files -------------- src/backend/utils/misc/guc.c | 3 ++- src/include/utils/guc_tables.h | 10 ++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2023-11-02 15:53 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-11-02 15:53 pgsql: Be more wary about NULL values for GUC string variables. Tom Lane <tgl@sss.pgh.pa.us> 2023-11-02 15:53 pgsql: Be more wary about NULL values for GUC string variables. Tom Lane <tgl@sss.pgh.pa.us> 2023-11-02 15:53 pgsql: Be more wary about NULL values for GUC string variables. Tom Lane <tgl@sss.pgh.pa.us> 2023-11-02 15:53 pgsql: Be more wary about NULL values for GUC string variables. Tom Lane <tgl@sss.pgh.pa.us> 2023-11-02 15:53 pgsql: Be more wary about NULL values for GUC string variables. Tom Lane <tgl@sss.pgh.pa.us> 2023-11-02 15:53 pgsql: Be more wary about NULL values for GUC string variables. Tom Lane <tgl@sss.pgh.pa.us> 2023-11-02 15:53 pgsql: Be more wary about NULL values for GUC string variables. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox