pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Register llvm_shutdown using on_proc_exit, not before_shmem_exit
3+ messages / 1 participants
[nested] [flat]

* pgsql: Register llvm_shutdown using on_proc_exit, not before_shmem_exit
@ 2023-11-17 10:49  Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 3+ messages in thread

From: Daniel Gustafsson @ 2023-11-17 10:49 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Register llvm_shutdown using on_proc_exit, not before_shmem_exit.

This seems more correct, because other before_shmem_exit calls may
expect the infrastructure that is needed to run queries and access the
database to be working, and also because this cleanup has nothing to
do with shared memory.

This is a back-patch of bab150045bd9.

There were no known user-visible consequences to this, though, apart
from what was previous fixed by commit 303640199d0 and back-patched
as commit bcbc27251d35 and commit f7013683d9bb, so bab150045bd9 was
not no back-patched at the time.

Bharath Rupireddy

Discussion: http://postgr.es/m/CALj2ACWk7j4F2v2fxxYfrroOF=AdFNPr1WsV+AGtHAFQOqm_pw@mail.gmail.com
Backpatch-through: 13, 12

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2db84c25df199db605942bde5c17bc7134e79e2b

Modified Files
--------------
src/backend/jit/llvm/llvmjit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Register llvm_shutdown using on_proc_exit, not before_shmem_exit
@ 2023-11-17 10:52  Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 3+ messages in thread

From: Daniel Gustafsson @ 2023-11-17 10:52 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Register llvm_shutdown using on_proc_exit, not before_shmem_exit.

This seems more correct, because other before_shmem_exit calls may
expect the infrastructure that is needed to run queries and access the
database to be working, and also because this cleanup has nothing to
do with shared memory.

This is a back-patch of bab150045bd9.

There were no known user-visible consequences to this, though, apart
from what was previous fixed by commit 303640199d0 and back-patched
as commit bcbc27251d35 and commit f7013683d9bb, so bab150045bd9 was
not no back-patched at the time.

Bharath Rupireddy

Discussion: http://postgr.es/m/CALj2ACWk7j4F2v2fxxYfrroOF=AdFNPr1WsV+AGtHAFQOqm_pw@mail.gmail.com
Backpatch-through: 13, 12

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c980eeddccac3f9d7030948569f8d13b6ee1e127

Modified Files
--------------
src/backend/jit/llvm/llvmjit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2023-11-17 10:52 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-11-17 10:49 pgsql: Register llvm_shutdown using on_proc_exit, not before_shmem_exit Daniel Gustafsson <dgustafsson@postgresql.org>
2023-11-17 10:52 pgsql: Register llvm_shutdown using on_proc_exit, not before_shmem_exit Daniel Gustafsson <dgustafsson@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox