pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Remove test for pg_stat_reset_shared() in stats.sql
3+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2023-11-28 f36b63623d Remove more statements from stats.sql
* pgsql: Remove test for pg_stat_reset_shared() in stats.sql
@ 2023-11-28 04:21 Michael Paquier <michael@paquier.xyz>
2023-11-28 04:51 ` Re: pgsql: Remove test for pg_stat_reset_shared() in stats.sql Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Michael Paquier @ 2023-11-28 04:21 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Remove test for pg_stat_reset_shared() in stats.sql
Some buildfarm members have been failing a test related to pg_stat_io,
as an effect of 23c8c0c8f472 that has switched pg_stat_reset_shared()
from being a no-op to reset all shared stats types.
This extra reset has the effect to make pg_stat_io's counters low enough
that little concurrent activity is enough to cause a failure. Another
thing I have considered is to move this sequence at the end of
stats.sql, but there are other instabilities, one being pg_stat_wal.
Knowing that there are already tests for the reset of each individual
shared stats target, this test has limited value, so let's remove it to
minimize the number of resets done for each shared stats type. This
should hopefully improve the stability of the whole.
Discussion: https://postgr.es/m/3500949.1700935734@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a9a8108411e49c81316a9aba848a7f9ad3d3e939
Modified Files
--------------
src/test/regress/expected/stats.out | 44 -------------------------------------
src/test/regress/sql/stats.sql | 10 ---------
2 files changed, 54 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Remove test for pg_stat_reset_shared() in stats.sql
2023-11-28 04:21 pgsql: Remove test for pg_stat_reset_shared() in stats.sql Michael Paquier <michael@paquier.xyz>
@ 2023-11-28 04:51 ` Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
2023-11-28 04:54 ` Re: pgsql: Remove test for pg_stat_reset_shared() in stats.sql Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 3+ messages in thread
From: Bharath Rupireddy @ 2023-11-28 04:51 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-committers@lists.postgresql.org
On Tue, Nov 28, 2023 at 9:51 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> Remove test for pg_stat_reset_shared() in stats.sql
>
> Some buildfarm members have been failing a test related to pg_stat_io,
> as an effect of 23c8c0c8f472 that has switched pg_stat_reset_shared()
> from being a no-op to reset all shared stats types.
>
> This extra reset has the effect to make pg_stat_io's counters low enough
> that little concurrent activity is enough to cause a failure. Another
> thing I have considered is to move this sequence at the end of
> stats.sql, but there are other instabilities, one being pg_stat_wal.
>
> Knowing that there are already tests for the reset of each individual
> shared stats target, this test has limited value, so let's remove it to
> minimize the number of resets done for each shared stats type. This
> should hopefully improve the stability of the whole.
>
> Discussion: https://postgr.es/m/3500949.1700935734@sss.pgh.pa.us
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/a9a8108411e49c81316a9aba848a7f9ad3d3e939
>
> Modified Files
> --------------
> src/test/regress/expected/stats.out | 44 -------------------------------------
> src/test/regress/sql/stats.sql | 10 ---------
> 2 files changed, 54 deletions(-)
Is there any reason for not removing [1] unneeded statements from
stats.sql like the attached?
[1] https://www.postgresql.org/message-id/CALj2ACWtgPMg38JTO-AWrdLp4duFzR3iBq39Xt%2Bhn2%2BS2yzG7w%40mail...
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Attachments:
v1-0001-Remove-extraneous-statements-from-stats.sql-test.patch (application/octet-stream, 5.2K) download
From c67a498b8604798fb976dff2672d63af06240c66 Mon Sep 17 00:00:00 2001
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: Tue, 28 Nov 2023 04:47:32 +0000
Subject: [PATCH v1] Remove extraneous statements from stats.sql test
With commit a9a8108411e4, some of the statements that are
capturing stats reset timestamps after pg_stat_reset_shared()
have become unused. So, this commit removes those statements.
---
src/test/regress/expected/stats.out | 6 ------
src/test/regress/sql/stats.sql | 6 ------
2 files changed, 12 deletions(-)
diff --git a/src/test/regress/expected/stats.out b/src/test/regress/expected/stats.out
index 87d881c3f9..346e10a3d2 100644
--- a/src/test/regress/expected/stats.out
+++ b/src/test/regress/expected/stats.out
@@ -914,7 +914,6 @@ SELECT stats_reset > :'archiver_reset_ts'::timestamptz FROM pg_stat_archiver;
t
(1 row)
-SELECT stats_reset AS archiver_reset_ts FROM pg_stat_archiver \gset
-- Test that reset_shared with bgwriter specified as the stats type works
SELECT stats_reset AS bgwriter_reset_ts FROM pg_stat_bgwriter \gset
SELECT pg_stat_reset_shared('bgwriter');
@@ -929,7 +928,6 @@ SELECT stats_reset > :'bgwriter_reset_ts'::timestamptz FROM pg_stat_bgwriter;
t
(1 row)
-SELECT stats_reset AS bgwriter_reset_ts FROM pg_stat_bgwriter \gset
-- Test that reset_shared with checkpointer specified as the stats type works
SELECT stats_reset AS checkpointer_reset_ts FROM pg_stat_checkpointer \gset
SELECT pg_stat_reset_shared('checkpointer');
@@ -944,7 +942,6 @@ SELECT stats_reset > :'checkpointer_reset_ts'::timestamptz FROM pg_stat_checkpoi
t
(1 row)
-SELECT stats_reset AS checkpointer_reset_ts FROM pg_stat_checkpointer \gset
-- Test that reset_shared with recovery_prefetch specified as the stats type works
SELECT stats_reset AS recovery_prefetch_reset_ts FROM pg_stat_recovery_prefetch \gset
SELECT pg_stat_reset_shared('recovery_prefetch');
@@ -959,7 +956,6 @@ SELECT stats_reset > :'recovery_prefetch_reset_ts'::timestamptz FROM pg_stat_rec
t
(1 row)
-SELECT stats_reset AS recovery_prefetch_reset_ts FROM pg_stat_recovery_prefetch \gset
-- Test that reset_shared with slru specified as the stats type works
SELECT max(stats_reset) AS slru_reset_ts FROM pg_stat_slru \gset
SELECT pg_stat_reset_shared('slru');
@@ -974,7 +970,6 @@ SELECT max(stats_reset) > :'slru_reset_ts'::timestamptz FROM pg_stat_slru;
t
(1 row)
-SELECT max(stats_reset) AS slru_reset_ts FROM pg_stat_slru \gset
-- Test that reset_shared with wal specified as the stats type works
SELECT stats_reset AS wal_reset_ts FROM pg_stat_wal \gset
SELECT pg_stat_reset_shared('wal');
@@ -989,7 +984,6 @@ SELECT stats_reset > :'wal_reset_ts'::timestamptz FROM pg_stat_wal;
t
(1 row)
-SELECT stats_reset AS wal_reset_ts FROM pg_stat_wal \gset
-- Test error case for reset_shared with unknown stats type
SELECT pg_stat_reset_shared('unknown');
ERROR: unrecognized reset target: "unknown"
diff --git a/src/test/regress/sql/stats.sql b/src/test/regress/sql/stats.sql
index d867fb406f..e3b4ca96e8 100644
--- a/src/test/regress/sql/stats.sql
+++ b/src/test/regress/sql/stats.sql
@@ -462,37 +462,31 @@ SELECT stats_reset > :'slru_notify_reset_ts'::timestamptz FROM pg_stat_slru WHER
SELECT stats_reset AS archiver_reset_ts FROM pg_stat_archiver \gset
SELECT pg_stat_reset_shared('archiver');
SELECT stats_reset > :'archiver_reset_ts'::timestamptz FROM pg_stat_archiver;
-SELECT stats_reset AS archiver_reset_ts FROM pg_stat_archiver \gset
-- Test that reset_shared with bgwriter specified as the stats type works
SELECT stats_reset AS bgwriter_reset_ts FROM pg_stat_bgwriter \gset
SELECT pg_stat_reset_shared('bgwriter');
SELECT stats_reset > :'bgwriter_reset_ts'::timestamptz FROM pg_stat_bgwriter;
-SELECT stats_reset AS bgwriter_reset_ts FROM pg_stat_bgwriter \gset
-- Test that reset_shared with checkpointer specified as the stats type works
SELECT stats_reset AS checkpointer_reset_ts FROM pg_stat_checkpointer \gset
SELECT pg_stat_reset_shared('checkpointer');
SELECT stats_reset > :'checkpointer_reset_ts'::timestamptz FROM pg_stat_checkpointer;
-SELECT stats_reset AS checkpointer_reset_ts FROM pg_stat_checkpointer \gset
-- Test that reset_shared with recovery_prefetch specified as the stats type works
SELECT stats_reset AS recovery_prefetch_reset_ts FROM pg_stat_recovery_prefetch \gset
SELECT pg_stat_reset_shared('recovery_prefetch');
SELECT stats_reset > :'recovery_prefetch_reset_ts'::timestamptz FROM pg_stat_recovery_prefetch;
-SELECT stats_reset AS recovery_prefetch_reset_ts FROM pg_stat_recovery_prefetch \gset
-- Test that reset_shared with slru specified as the stats type works
SELECT max(stats_reset) AS slru_reset_ts FROM pg_stat_slru \gset
SELECT pg_stat_reset_shared('slru');
SELECT max(stats_reset) > :'slru_reset_ts'::timestamptz FROM pg_stat_slru;
-SELECT max(stats_reset) AS slru_reset_ts FROM pg_stat_slru \gset
-- Test that reset_shared with wal specified as the stats type works
SELECT stats_reset AS wal_reset_ts FROM pg_stat_wal \gset
SELECT pg_stat_reset_shared('wal');
SELECT stats_reset > :'wal_reset_ts'::timestamptz FROM pg_stat_wal;
-SELECT stats_reset AS wal_reset_ts FROM pg_stat_wal \gset
-- Test error case for reset_shared with unknown stats type
SELECT pg_stat_reset_shared('unknown');
--
2.34.1
* Re: pgsql: Remove test for pg_stat_reset_shared() in stats.sql
2023-11-28 04:21 pgsql: Remove test for pg_stat_reset_shared() in stats.sql Michael Paquier <michael@paquier.xyz>
2023-11-28 04:51 ` Re: pgsql: Remove test for pg_stat_reset_shared() in stats.sql Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
@ 2023-11-28 04:54 ` Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 3+ messages in thread
From: Michael Paquier @ 2023-11-28 04:54 UTC (permalink / raw)
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>; +Cc: pgsql-committers@lists.postgresql.org
On Tue, Nov 28, 2023 at 10:21:33AM +0530, Bharath Rupireddy wrote:
> Is there any reason for not removing [1] unneeded statements from
> stats.sql like the attached?
Ugh, thanks. I have somewhat missed that.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2023-11-28 04:54 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-11-28 04:21 pgsql: Remove test for pg_stat_reset_shared() in stats.sql Michael Paquier <michael@paquier.xyz>
2023-11-28 04:51 ` Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
2023-11-28 04:54 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox