pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix assertions with RI triggers in heap_update and heap_delete. 6+ messages / 1 participants [nested] [flat]
* pgsql: Fix assertions with RI triggers in heap_update and heap_delete. @ 2023-11-28 10:38 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2023-11-28 10:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix assertions with RI triggers in heap_update and heap_delete. If the tuple being updated is not visible to the crosscheck snapshot, we return TM_Updated but the assertions would not hold in that case. Move them to before the cross-check. Fixes bug #17893. Backpatch to all supported versions. Author: Alexander Lakhin Backpatch-through: 12 Discussion: https://www.postgresql.org/message-id/17893-35847009eec517b5%40postgresql.org Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/59c62a21f2439e425abae5a2e9dd1d53371226ea Modified Files -------------- src/backend/access/heap/heapam.c | 41 +++++++++++++++++++++++----------------- src/include/access/tableam.h | 4 ++-- 2 files changed, 26 insertions(+), 19 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix assertions with RI triggers in heap_update and heap_delete. @ 2023-11-28 10:38 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2023-11-28 10:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix assertions with RI triggers in heap_update and heap_delete. If the tuple being updated is not visible to the crosscheck snapshot, we return TM_Updated but the assertions would not hold in that case. Move them to before the cross-check. Fixes bug #17893. Backpatch to all supported versions. Author: Alexander Lakhin Backpatch-through: 12 Discussion: https://www.postgresql.org/message-id/17893-35847009eec517b5%40postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/60f227316c0ebf5f4f8296f11cedc9360e9cb8ae Modified Files -------------- src/backend/access/heap/heapam.c | 41 +++++++++++++++++------------ src/include/access/tableam.h | 4 +-- src/test/isolation/expected/fk-snapshot.out | 22 ++++++++++++++++ src/test/isolation/specs/fk-snapshot.spec | 17 +++++++++++- 4 files changed, 64 insertions(+), 20 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix assertions with RI triggers in heap_update and heap_delete. @ 2023-11-28 10:38 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2023-11-28 10:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix assertions with RI triggers in heap_update and heap_delete. If the tuple being updated is not visible to the crosscheck snapshot, we return TM_Updated but the assertions would not hold in that case. Move them to before the cross-check. Fixes bug #17893. Backpatch to all supported versions. Author: Alexander Lakhin Backpatch-through: 12 Discussion: https://www.postgresql.org/message-id/17893-35847009eec517b5%40postgresql.org Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9fee3232a1d3661981c3cbf87227bfd02ee36c7b Modified Files -------------- src/backend/access/heap/heapam.c | 41 +++++++++++++++++------------ src/include/access/tableam.h | 4 +-- src/test/isolation/expected/fk-snapshot.out | 22 ++++++++++++++++ src/test/isolation/specs/fk-snapshot.spec | 17 +++++++++++- 4 files changed, 64 insertions(+), 20 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix assertions with RI triggers in heap_update and heap_delete. @ 2023-11-28 10:38 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2023-11-28 10:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix assertions with RI triggers in heap_update and heap_delete. If the tuple being updated is not visible to the crosscheck snapshot, we return TM_Updated but the assertions would not hold in that case. Move them to before the cross-check. Fixes bug #17893. Backpatch to all supported versions. Author: Alexander Lakhin Backpatch-through: 12 Discussion: https://www.postgresql.org/message-id/17893-35847009eec517b5%40postgresql.org Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e434d3620a91f6f4511de32aaad70c1830949797 Modified Files -------------- src/backend/access/heap/heapam.c | 41 +++++++++++++++++++++++----------------- src/include/access/tableam.h | 4 ++-- 2 files changed, 26 insertions(+), 19 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix assertions with RI triggers in heap_update and heap_delete. @ 2023-11-28 10:38 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2023-11-28 10:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix assertions with RI triggers in heap_update and heap_delete. If the tuple being updated is not visible to the crosscheck snapshot, we return TM_Updated but the assertions would not hold in that case. Move them to before the cross-check. Fixes bug #17893. Backpatch to all supported versions. Author: Alexander Lakhin Backpatch-through: 12 Discussion: https://www.postgresql.org/message-id/17893-35847009eec517b5%40postgresql.org Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b8a606e21b0619ac378558bdd258c54aee7cb4ed Modified Files -------------- src/backend/access/heap/heapam.c | 41 +++++++++++++++++++++++----------------- src/include/access/tableam.h | 4 ++-- 2 files changed, 26 insertions(+), 19 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix assertions with RI triggers in heap_update and heap_delete. @ 2023-11-28 10:38 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 6+ messages in thread From: Heikki Linnakangas @ 2023-11-28 10:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix assertions with RI triggers in heap_update and heap_delete. If the tuple being updated is not visible to the crosscheck snapshot, we return TM_Updated but the assertions would not hold in that case. Move them to before the cross-check. Fixes bug #17893. Backpatch to all supported versions. Author: Alexander Lakhin Backpatch-through: 12 Discussion: https://www.postgresql.org/message-id/17893-35847009eec517b5%40postgresql.org Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2873fbfe0d6500a45a316d2d42414a432a96e9f1 Modified Files -------------- src/backend/access/heap/heapam.c | 41 +++++++++++++++++------------ src/include/access/tableam.h | 4 +-- src/test/isolation/expected/fk-snapshot.out | 22 ++++++++++++++++ src/test/isolation/specs/fk-snapshot.spec | 17 +++++++++++- 4 files changed, 64 insertions(+), 20 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2023-11-28 10:38 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-11-28 10:38 pgsql: Fix assertions with RI triggers in heap_update and heap_delete. Heikki Linnakangas <heikki.linnakangas@iki.fi> 2023-11-28 10:38 pgsql: Fix assertions with RI triggers in heap_update and heap_delete. Heikki Linnakangas <heikki.linnakangas@iki.fi> 2023-11-28 10:38 pgsql: Fix assertions with RI triggers in heap_update and heap_delete. Heikki Linnakangas <heikki.linnakangas@iki.fi> 2023-11-28 10:38 pgsql: Fix assertions with RI triggers in heap_update and heap_delete. Heikki Linnakangas <heikki.linnakangas@iki.fi> 2023-11-28 10:38 pgsql: Fix assertions with RI triggers in heap_update and heap_delete. Heikki Linnakangas <heikki.linnakangas@iki.fi> 2023-11-28 10:38 pgsql: Fix assertions with RI triggers in heap_update and heap_delete. Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox