pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Use BIO_{get,set}_app_data instead of BIO_{get,set}_data.
6+ messages / 1 participants
[nested] [flat]
* pgsql: Use BIO_{get,set}_app_data instead of BIO_{get,set}_data.
@ 2023-11-28 17:34 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lane @ 2023-11-28 17:34 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Use BIO_{get,set}_app_data instead of BIO_{get,set}_data.
We should have done it this way all along, but we accidentally got
away with using the wrong BIO field up until OpenSSL 3.2. There,
the library's BIO routines that we rely on use the "data" field
for their own purposes, and our conflicting use causes assorted
weird behaviors up to and including core dumps when SSL connections
are attempted. Switch to using the approved field for the purpose,
i.e. app_data.
While at it, remove our configure probes for BIO_get_data as well
as the fallback implementation. BIO_{get,set}_app_data have been
there since long before any OpenSSL version that we still support,
even in the back branches.
Also, update src/test/ssl/t/001_ssltests.pl to allow for a minor
change in an error message spelling that evidently came in with 3.2.
Tristan Partin and Bo Andreson. Back-patch to all supported branches.
Discussion: https://postgr.es/m/CAN55FZ1eDDYsYaL7mv+oSLUij2h_u6hvD4Qmv-7PK7jkji0uyQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c82207a548db47623a2bfa2447babdaa630302b9
Modified Files
--------------
configure | 2 +-
configure.ac | 2 +-
meson.build | 1 -
src/backend/libpq/be-secure-openssl.c | 11 +++--------
src/include/pg_config.h.in | 3 ---
src/interfaces/libpq/fe-secure-openssl.c | 11 +++--------
src/test/ssl/t/001_ssltests.pl | 6 +++---
src/tools/msvc/Solution.pm | 2 --
8 files changed, 11 insertions(+), 27 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Use BIO_{get,set}_app_data instead of BIO_{get,set}_data.
@ 2023-11-28 17:34 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lane @ 2023-11-28 17:34 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Use BIO_{get,set}_app_data instead of BIO_{get,set}_data.
We should have done it this way all along, but we accidentally got
away with using the wrong BIO field up until OpenSSL 3.2. There,
the library's BIO routines that we rely on use the "data" field
for their own purposes, and our conflicting use causes assorted
weird behaviors up to and including core dumps when SSL connections
are attempted. Switch to using the approved field for the purpose,
i.e. app_data.
While at it, remove our configure probes for BIO_get_data as well
as the fallback implementation. BIO_{get,set}_app_data have been
there since long before any OpenSSL version that we still support,
even in the back branches.
Also, update src/test/ssl/t/001_ssltests.pl to allow for a minor
change in an error message spelling that evidently came in with 3.2.
Tristan Partin and Bo Andreson. Back-patch to all supported branches.
Discussion: https://postgr.es/m/CAN55FZ1eDDYsYaL7mv+oSLUij2h_u6hvD4Qmv-7PK7jkji0uyQ@mail.gmail.com
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/efa8f606402c3d7ca361932418cbcc2600b6c059
Modified Files
--------------
configure | 2 +-
configure.ac | 2 +-
meson.build | 1 -
src/backend/libpq/be-secure-openssl.c | 11 +++--------
src/include/pg_config.h.in | 3 ---
src/interfaces/libpq/fe-secure-openssl.c | 11 +++--------
src/test/ssl/t/001_ssltests.pl | 6 +++---
src/tools/msvc/Solution.pm | 2 --
8 files changed, 11 insertions(+), 27 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Use BIO_{get,set}_app_data instead of BIO_{get,set}_data.
@ 2023-11-28 17:34 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lane @ 2023-11-28 17:34 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Use BIO_{get,set}_app_data instead of BIO_{get,set}_data.
We should have done it this way all along, but we accidentally got
away with using the wrong BIO field up until OpenSSL 3.2. There,
the library's BIO routines that we rely on use the "data" field
for their own purposes, and our conflicting use causes assorted
weird behaviors up to and including core dumps when SSL connections
are attempted. Switch to using the approved field for the purpose,
i.e. app_data.
While at it, remove our configure probes for BIO_get_data as well
as the fallback implementation. BIO_{get,set}_app_data have been
there since long before any OpenSSL version that we still support,
even in the back branches.
Also, update src/test/ssl/t/001_ssltests.pl to allow for a minor
change in an error message spelling that evidently came in with 3.2.
Tristan Partin and Bo Andreson. Back-patch to all supported branches.
Discussion: https://postgr.es/m/CAN55FZ1eDDYsYaL7mv+oSLUij2h_u6hvD4Qmv-7PK7jkji0uyQ@mail.gmail.com
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/5dd30bb54bfec14e5677aff3e306edec79c204ef
Modified Files
--------------
configure | 2 +-
configure.ac | 2 +-
src/backend/libpq/be-secure-openssl.c | 11 +++--------
src/include/pg_config.h.in | 3 ---
src/interfaces/libpq/fe-secure-openssl.c | 11 +++--------
src/test/ssl/t/001_ssltests.pl | 4 ++--
src/tools/msvc/Solution.pm | 2 --
7 files changed, 10 insertions(+), 25 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Use BIO_{get,set}_app_data instead of BIO_{get,set}_data.
@ 2023-11-28 17:34 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lane @ 2023-11-28 17:34 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Use BIO_{get,set}_app_data instead of BIO_{get,set}_data.
We should have done it this way all along, but we accidentally got
away with using the wrong BIO field up until OpenSSL 3.2. There,
the library's BIO routines that we rely on use the "data" field
for their own purposes, and our conflicting use causes assorted
weird behaviors up to and including core dumps when SSL connections
are attempted. Switch to using the approved field for the purpose,
i.e. app_data.
While at it, remove our configure probes for BIO_get_data as well
as the fallback implementation. BIO_{get,set}_app_data have been
there since long before any OpenSSL version that we still support,
even in the back branches.
Also, update src/test/ssl/t/001_ssltests.pl to allow for a minor
change in an error message spelling that evidently came in with 3.2.
Tristan Partin and Bo Andreson. Back-patch to all supported branches.
Discussion: https://postgr.es/m/CAN55FZ1eDDYsYaL7mv+oSLUij2h_u6hvD4Qmv-7PK7jkji0uyQ@mail.gmail.com
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/b2b1f12882fb561c7d474b834044dd8ed570bfea
Modified Files
--------------
configure | 2 +-
configure.ac | 2 +-
src/backend/libpq/be-secure-openssl.c | 11 +++--------
src/include/pg_config.h.in | 3 ---
src/interfaces/libpq/fe-secure-openssl.c | 11 +++--------
src/test/ssl/t/001_ssltests.pl | 4 ++--
src/tools/msvc/Solution.pm | 2 --
7 files changed, 10 insertions(+), 25 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Use BIO_{get,set}_app_data instead of BIO_{get,set}_data.
@ 2023-11-28 17:34 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lane @ 2023-11-28 17:34 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Use BIO_{get,set}_app_data instead of BIO_{get,set}_data.
We should have done it this way all along, but we accidentally got
away with using the wrong BIO field up until OpenSSL 3.2. There,
the library's BIO routines that we rely on use the "data" field
for their own purposes, and our conflicting use causes assorted
weird behaviors up to and including core dumps when SSL connections
are attempted. Switch to using the approved field for the purpose,
i.e. app_data.
While at it, remove our configure probes for BIO_get_data as well
as the fallback implementation. BIO_{get,set}_app_data have been
there since long before any OpenSSL version that we still support,
even in the back branches.
Also, update src/test/ssl/t/001_ssltests.pl to allow for a minor
change in an error message spelling that evidently came in with 3.2.
Tristan Partin and Bo Andreson. Back-patch to all supported branches.
Discussion: https://postgr.es/m/CAN55FZ1eDDYsYaL7mv+oSLUij2h_u6hvD4Qmv-7PK7jkji0uyQ@mail.gmail.com
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/efb80468271932ad17557afa977db56bfe3e8bc5
Modified Files
--------------
configure | 2 +-
configure.in | 2 +-
src/backend/libpq/be-secure-openssl.c | 11 +++--------
src/include/pg_config.h.in | 3 ---
src/interfaces/libpq/fe-secure-openssl.c | 11 +++--------
src/tools/msvc/Solution.pm | 2 --
6 files changed, 8 insertions(+), 23 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Use BIO_{get,set}_app_data instead of BIO_{get,set}_data.
@ 2023-11-28 17:34 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lane @ 2023-11-28 17:34 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Use BIO_{get,set}_app_data instead of BIO_{get,set}_data.
We should have done it this way all along, but we accidentally got
away with using the wrong BIO field up until OpenSSL 3.2. There,
the library's BIO routines that we rely on use the "data" field
for their own purposes, and our conflicting use causes assorted
weird behaviors up to and including core dumps when SSL connections
are attempted. Switch to using the approved field for the purpose,
i.e. app_data.
While at it, remove our configure probes for BIO_get_data as well
as the fallback implementation. BIO_{get,set}_app_data have been
there since long before any OpenSSL version that we still support,
even in the back branches.
Also, update src/test/ssl/t/001_ssltests.pl to allow for a minor
change in an error message spelling that evidently came in with 3.2.
Tristan Partin and Bo Andreson. Back-patch to all supported branches.
Discussion: https://postgr.es/m/CAN55FZ1eDDYsYaL7mv+oSLUij2h_u6hvD4Qmv-7PK7jkji0uyQ@mail.gmail.com
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/0bd682246a619fd8eb9b538f1af61afb991b06b4
Modified Files
--------------
configure | 2 +-
configure.in | 2 +-
src/backend/libpq/be-secure-openssl.c | 11 +++--------
src/include/pg_config.h.in | 3 ---
src/include/pg_config.h.win32 | 3 ---
src/interfaces/libpq/fe-secure-openssl.c | 11 +++--------
src/tools/msvc/Solution.pm | 1 -
7 files changed, 8 insertions(+), 25 deletions(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2023-11-28 17:34 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-11-28 17:34 pgsql: Use BIO_{get,set}_app_data instead of BIO_{get,set}_data. Tom Lane <tgl@sss.pgh.pa.us>
2023-11-28 17:34 pgsql: Use BIO_{get,set}_app_data instead of BIO_{get,set}_data. Tom Lane <tgl@sss.pgh.pa.us>
2023-11-28 17:34 pgsql: Use BIO_{get,set}_app_data instead of BIO_{get,set}_data. Tom Lane <tgl@sss.pgh.pa.us>
2023-11-28 17:34 pgsql: Use BIO_{get,set}_app_data instead of BIO_{get,set}_data. Tom Lane <tgl@sss.pgh.pa.us>
2023-11-28 17:34 pgsql: Use BIO_{get,set}_app_data instead of BIO_{get,set}_data. Tom Lane <tgl@sss.pgh.pa.us>
2023-11-28 17:34 pgsql: Use BIO_{get,set}_app_data instead of BIO_{get,set}_data. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox