pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix incorrect error message for IDENTIFY_SYSTEM 6+ messages / 1 participants [nested] [flat]
* pgsql: Fix incorrect error message for IDENTIFY_SYSTEM @ 2023-12-05 13:35 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Daniel Gustafsson @ 2023-12-05 13:35 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect error message for IDENTIFY_SYSTEM Commit 5a991ef8692e accidentally reversed the order of the tuples and fields parameters, making the error message incorrectly refer to 3 tuples with 1 field when IDENTIFY_SYSTEM returns 1 tuple and 3 or 4 fields. Fix by changing the order of the parameters. This also adds a comment describing why we check for < 3 when postgres since 9.4 has been sending 4 fields. Backpatch all the way since the bug is almost a decade old. Author: Tomonari Katsumata <t.katsumata1122@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Bug: #18224 Backpatch-through: v12 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/98e675ed7af95cb65a594ce730d42390e0118dcb Modified Files -------------- src/backend/replication/libpqwalreceiver/libpqwalreceiver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix incorrect error message for IDENTIFY_SYSTEM @ 2023-12-05 13:36 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Daniel Gustafsson @ 2023-12-05 13:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect error message for IDENTIFY_SYSTEM Commit 5a991ef8692e accidentally reversed the order of the tuples and fields parameters, making the error message incorrectly refer to 3 tuples with 1 field when IDENTIFY_SYSTEM returns 1 tuple and 3 or 4 fields. Fix by changing the order of the parameters. This also adds a comment describing why we check for < 3 when postgres since 9.4 has been sending 4 fields. Backpatch all the way since the bug is almost a decade old. Author: Tomonari Katsumata <t.katsumata1122@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Bug: #18224 Backpatch-through: v12 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8da1fb13bdb14b7a3f3ecad2d4b1530fd00227da Modified Files -------------- src/backend/replication/libpqwalreceiver/libpqwalreceiver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix incorrect error message for IDENTIFY_SYSTEM @ 2023-12-05 13:37 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Daniel Gustafsson @ 2023-12-05 13:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect error message for IDENTIFY_SYSTEM Commit 5a991ef8692e accidentally reversed the order of the tuples and fields parameters, making the error message incorrectly refer to 3 tuples with 1 field when IDENTIFY_SYSTEM returns 1 tuple and 3 or 4 fields. Fix by changing the order of the parameters. This also adds a comment describing why we check for < 3 when postgres since 9.4 has been sending 4 fields. Backpatch all the way since the bug is almost a decade old. Author: Tomonari Katsumata <t.katsumata1122@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Bug: #18224 Backpatch-through: v12 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bc0a368dc5bc2bef957ede025e7f81f74c7aa58f Modified Files -------------- src/backend/replication/libpqwalreceiver/libpqwalreceiver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix incorrect error message for IDENTIFY_SYSTEM @ 2023-12-05 13:37 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Daniel Gustafsson @ 2023-12-05 13:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect error message for IDENTIFY_SYSTEM Commit 5a991ef8692e accidentally reversed the order of the tuples and fields parameters, making the error message incorrectly refer to 3 tuples with 1 field when IDENTIFY_SYSTEM returns 1 tuple and 3 or 4 fields. Fix by changing the order of the parameters. This also adds a comment describing why we check for < 3 when postgres since 9.4 has been sending 4 fields. Backpatch all the way since the bug is almost a decade old. Author: Tomonari Katsumata <t.katsumata1122@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Bug: #18224 Backpatch-through: v12 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/376eaa45a2b8a2aed45b26e5fc889d2cb70ec6a7 Modified Files -------------- src/backend/replication/libpqwalreceiver/libpqwalreceiver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix incorrect error message for IDENTIFY_SYSTEM @ 2023-12-05 13:38 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Daniel Gustafsson @ 2023-12-05 13:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect error message for IDENTIFY_SYSTEM Commit 5a991ef8692e accidentally reversed the order of the tuples and fields parameters, making the error message incorrectly refer to 3 tuples with 1 field when IDENTIFY_SYSTEM returns 1 tuple and 3 or 4 fields. Fix by changing the order of the parameters. This also adds a comment describing why we check for < 3 when postgres since 9.4 has been sending 4 fields. Backpatch all the way since the bug is almost a decade old. Author: Tomonari Katsumata <t.katsumata1122@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Bug: #18224 Backpatch-through: v12 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1ce2986795eb6ac4de32da835087ea1d486fbfa3 Modified Files -------------- src/backend/replication/libpqwalreceiver/libpqwalreceiver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix incorrect error message for IDENTIFY_SYSTEM @ 2023-12-05 13:38 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Daniel Gustafsson @ 2023-12-05 13:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect error message for IDENTIFY_SYSTEM Commit 5a991ef8692e accidentally reversed the order of the tuples and fields parameters, making the error message incorrectly refer to 3 tuples with 1 field when IDENTIFY_SYSTEM returns 1 tuple and 3 or 4 fields. Fix by changing the order of the parameters. This also adds a comment describing why we check for < 3 when postgres since 9.4 has been sending 4 fields. Backpatch all the way since the bug is almost a decade old. Author: Tomonari Katsumata <t.katsumata1122@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Bug: #18224 Backpatch-through: v12 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b608afe980a5dfe91d76148900179d52d4db5e64 Modified Files -------------- src/backend/replication/libpqwalreceiver/libpqwalreceiver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2023-12-05 13:38 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-12-05 13:35 pgsql: Fix incorrect error message for IDENTIFY_SYSTEM Daniel Gustafsson <dgustafsson@postgresql.org> 2023-12-05 13:36 pgsql: Fix incorrect error message for IDENTIFY_SYSTEM Daniel Gustafsson <dgustafsson@postgresql.org> 2023-12-05 13:37 pgsql: Fix incorrect error message for IDENTIFY_SYSTEM Daniel Gustafsson <dgustafsson@postgresql.org> 2023-12-05 13:37 pgsql: Fix incorrect error message for IDENTIFY_SYSTEM Daniel Gustafsson <dgustafsson@postgresql.org> 2023-12-05 13:38 pgsql: Fix incorrect error message for IDENTIFY_SYSTEM Daniel Gustafsson <dgustafsson@postgresql.org> 2023-12-05 13:38 pgsql: Fix incorrect error message for IDENTIFY_SYSTEM Daniel Gustafsson <dgustafsson@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox