pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Apply filters to dump files all the time in 002_pg_upgrade.pl 3+ messages / 1 participants [nested] [flat]
* pgsql: Apply filters to dump files all the time in 002_pg_upgrade.pl @ 2023-12-06 01:01 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2023-12-06 01:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Apply filters to dump files all the time in 002_pg_upgrade.pl This commit removes the restriction that would not apply filters to the dumps used for comparison in the TAP test of pg_upgrade when using the same base version for the old and new nodes. The previous logic would fail on Windows if loading a dump while using the same set of binaries for the old and new nodes, as the library dependencies updated in the old dump would append CRLFs to the dump file as it is treated as a text file. The dump filtering logic replaces all CRLFs (\r\n) by LFs (\n), which is able to prevent this issue. When the old and new versions of the binaries are the same, AdjustUpgrade removes all blank lines, removes version-based comments generated by pg_dump and replaces CRLFs by LFs. Reported-by: Alexander Lakhin Discussion: https://postgr.es/m/60d434b9-53d9-9ea1-819b-efebdcf44e41@gmail.com Backpatch-through: 15 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/bfc677c3bc31658957f601886352901fdd8c2811 Modified Files -------------- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Apply filters to dump files all the time in 002_pg_upgrade.pl @ 2023-12-06 01:01 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2023-12-06 01:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Apply filters to dump files all the time in 002_pg_upgrade.pl This commit removes the restriction that would not apply filters to the dumps used for comparison in the TAP test of pg_upgrade when using the same base version for the old and new nodes. The previous logic would fail on Windows if loading a dump while using the same set of binaries for the old and new nodes, as the library dependencies updated in the old dump would append CRLFs to the dump file as it is treated as a text file. The dump filtering logic replaces all CRLFs (\r\n) by LFs (\n), which is able to prevent this issue. When the old and new versions of the binaries are the same, AdjustUpgrade removes all blank lines, removes version-based comments generated by pg_dump and replaces CRLFs by LFs. Reported-by: Alexander Lakhin Discussion: https://postgr.es/m/60d434b9-53d9-9ea1-819b-efebdcf44e41@gmail.com Backpatch-through: 15 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a499c08dca5e0162e210cc8a411698e2808a04da Modified Files -------------- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Apply filters to dump files all the time in 002_pg_upgrade.pl @ 2023-12-06 01:01 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2023-12-06 01:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Apply filters to dump files all the time in 002_pg_upgrade.pl This commit removes the restriction that would not apply filters to the dumps used for comparison in the TAP test of pg_upgrade when using the same base version for the old and new nodes. The previous logic would fail on Windows if loading a dump while using the same set of binaries for the old and new nodes, as the library dependencies updated in the old dump would append CRLFs to the dump file as it is treated as a text file. The dump filtering logic replaces all CRLFs (\r\n) by LFs (\n), which is able to prevent this issue. When the old and new versions of the binaries are the same, AdjustUpgrade removes all blank lines, removes version-based comments generated by pg_dump and replaces CRLFs by LFs. Reported-by: Alexander Lakhin Discussion: https://postgr.es/m/60d434b9-53d9-9ea1-819b-efebdcf44e41@gmail.com Backpatch-through: 15 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f0b53daa2c761e5349a91ebe1162c1ce87a8b33f Modified Files -------------- src/bin/pg_upgrade/t/002_pg_upgrade.pl | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2023-12-06 01:01 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-12-06 01:01 pgsql: Apply filters to dump files all the time in 002_pg_upgrade.pl Michael Paquier <michael@paquier.xyz> 2023-12-06 01:01 pgsql: Apply filters to dump files all the time in 002_pg_upgrade.pl Michael Paquier <michael@paquier.xyz> 2023-12-06 01:01 pgsql: Apply filters to dump files all the time in 002_pg_upgrade.pl Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox