pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: pageinspect: Fix failure with hash_bitmap_info() for partitioned 6+ messages / 1 participants [nested] [flat]
* pgsql: pageinspect: Fix failure with hash_bitmap_info() for partitioned @ 2023-12-19 09:20 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2023-12-19 09:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pageinspect: Fix failure with hash_bitmap_info() for partitioned indexes This function reads directly a page from a relation, relying on index_open() to open the index to read from. Unfortunately, this would crash when using partitioned indexes, as these can be opened with index_open() but they have no physical pages. Alexander has fixed the module, while I have written the test. Author: Alexander Lakhin, Michael Paquier Discussion: https://postgr.es/m/18246-f4d9ff7cb3af77e6@postgresql.org Backpatch-through: 12 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/20847013642127e75ee4fe3ddb8228a1fb4b652f Modified Files -------------- contrib/pageinspect/expected/hash.out | 5 +++++ contrib/pageinspect/hashfuncs.c | 6 ++++-- contrib/pageinspect/sql/hash.sql | 5 +++++ 3 files changed, 14 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pageinspect: Fix failure with hash_bitmap_info() for partitioned @ 2023-12-19 09:20 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2023-12-19 09:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pageinspect: Fix failure with hash_bitmap_info() for partitioned indexes This function reads directly a page from a relation, relying on index_open() to open the index to read from. Unfortunately, this would crash when using partitioned indexes, as these can be opened with index_open() but they have no physical pages. Alexander has fixed the module, while I have written the test. Author: Alexander Lakhin, Michael Paquier Discussion: https://postgr.es/m/18246-f4d9ff7cb3af77e6@postgresql.org Backpatch-through: 12 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7f68b14629c1ef6cf8cb60d47b76b3b570454622 Modified Files -------------- contrib/pageinspect/expected/hash.out | 5 +++++ contrib/pageinspect/hashfuncs.c | 6 ++++-- contrib/pageinspect/sql/hash.sql | 5 +++++ 3 files changed, 14 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pageinspect: Fix failure with hash_bitmap_info() for partitioned @ 2023-12-19 09:20 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2023-12-19 09:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pageinspect: Fix failure with hash_bitmap_info() for partitioned indexes This function reads directly a page from a relation, relying on index_open() to open the index to read from. Unfortunately, this would crash when using partitioned indexes, as these can be opened with index_open() but they have no physical pages. Alexander has fixed the module, while I have written the test. Author: Alexander Lakhin, Michael Paquier Discussion: https://postgr.es/m/18246-f4d9ff7cb3af77e6@postgresql.org Backpatch-through: 12 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2e08440d61ea1a783d98c05a834bb52736de5dd9 Modified Files -------------- contrib/pageinspect/expected/hash.out | 5 +++++ contrib/pageinspect/hashfuncs.c | 6 ++++-- contrib/pageinspect/sql/hash.sql | 5 +++++ 3 files changed, 14 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pageinspect: Fix failure with hash_bitmap_info() for partitioned @ 2023-12-19 09:20 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2023-12-19 09:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pageinspect: Fix failure with hash_bitmap_info() for partitioned indexes This function reads directly a page from a relation, relying on index_open() to open the index to read from. Unfortunately, this would crash when using partitioned indexes, as these can be opened with index_open() but they have no physical pages. Alexander has fixed the module, while I have written the test. Author: Alexander Lakhin, Michael Paquier Discussion: https://postgr.es/m/18246-f4d9ff7cb3af77e6@postgresql.org Backpatch-through: 12 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bfbe4a146e37dd57bcd6eb3d7abfa6d6668da4f9 Modified Files -------------- contrib/pageinspect/expected/hash.out | 5 +++++ contrib/pageinspect/hashfuncs.c | 6 ++++-- contrib/pageinspect/sql/hash.sql | 5 +++++ 3 files changed, 14 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pageinspect: Fix failure with hash_bitmap_info() for partitioned @ 2023-12-19 09:20 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2023-12-19 09:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pageinspect: Fix failure with hash_bitmap_info() for partitioned indexes This function reads directly a page from a relation, relying on index_open() to open the index to read from. Unfortunately, this would crash when using partitioned indexes, as these can be opened with index_open() but they have no physical pages. Alexander has fixed the module, while I have written the test. Author: Alexander Lakhin, Michael Paquier Discussion: https://postgr.es/m/18246-f4d9ff7cb3af77e6@postgresql.org Backpatch-through: 12 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/586c6a091f85e3ee8a2d0c6a1595593874b44ba7 Modified Files -------------- contrib/pageinspect/expected/hash.out | 5 +++++ contrib/pageinspect/hashfuncs.c | 6 ++++-- contrib/pageinspect/sql/hash.sql | 5 +++++ 3 files changed, 14 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pageinspect: Fix failure with hash_bitmap_info() for partitioned @ 2023-12-19 09:20 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 6+ messages in thread From: Michael Paquier @ 2023-12-19 09:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pageinspect: Fix failure with hash_bitmap_info() for partitioned indexes This function reads directly a page from a relation, relying on index_open() to open the index to read from. Unfortunately, this would crash when using partitioned indexes, as these can be opened with index_open() but they have no physical pages. Alexander has fixed the module, while I have written the test. Author: Alexander Lakhin, Michael Paquier Discussion: https://postgr.es/m/18246-f4d9ff7cb3af77e6@postgresql.org Backpatch-through: 12 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f610d4f119b5761475dff65266ec29c8e9cae509 Modified Files -------------- contrib/pageinspect/expected/hash.out | 5 +++++ contrib/pageinspect/hashfuncs.c | 6 ++++-- contrib/pageinspect/sql/hash.sql | 5 +++++ 3 files changed, 14 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2023-12-19 09:20 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-12-19 09:20 pgsql: pageinspect: Fix failure with hash_bitmap_info() for partitioned Michael Paquier <michael@paquier.xyz> 2023-12-19 09:20 pgsql: pageinspect: Fix failure with hash_bitmap_info() for partitioned Michael Paquier <michael@paquier.xyz> 2023-12-19 09:20 pgsql: pageinspect: Fix failure with hash_bitmap_info() for partitioned Michael Paquier <michael@paquier.xyz> 2023-12-19 09:20 pgsql: pageinspect: Fix failure with hash_bitmap_info() for partitioned Michael Paquier <michael@paquier.xyz> 2023-12-19 09:20 pgsql: pageinspect: Fix failure with hash_bitmap_info() for partitioned Michael Paquier <michael@paquier.xyz> 2023-12-19 09:20 pgsql: pageinspect: Fix failure with hash_bitmap_info() for partitioned Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox