pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Avoid trying to fetch metapage of an SPGist partitioned index. 6+ messages / 1 participants [nested] [flat]
* pgsql: Avoid trying to fetch metapage of an SPGist partitioned index. @ 2023-12-21 17:43 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2023-12-21 17:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid trying to fetch metapage of an SPGist partitioned index. This is necessary when spgcanreturn() is invoked on a partitioned index, and the failure might be reachable in other scenarios as well. The rest of what spgGetCache() does is perfectly sensible for a partitioned index, so we should allow it to go through. I think the main takeaway from this is that we lack sufficient test coverage for non-btree partitioned indexes. Therefore, I added simple test cases for brin and gin as well as spgist (hash and gist AMs were covered already in indexing.sql). Per bug #18256 from Alexander Lakhin. Although the known test case only fails since v16 (3c569049b), I've got no faith at all that there aren't other ways to reach this problem; so back-patch to all supported branches. Discussion: https://postgr.es/m/18256-0b0e1b6e4a620f1b@postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/903737c5bf9431c2f983c87ac211082418341805 Modified Files -------------- src/backend/access/spgist/spgutils.c | 29 +++++++++++++++---------- src/test/regress/expected/indexing.out | 39 ++++++++++++++++++++++++++++++++++ src/test/regress/sql/indexing.sql | 20 +++++++++++++++++ 3 files changed, 77 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Avoid trying to fetch metapage of an SPGist partitioned index. @ 2023-12-21 17:43 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2023-12-21 17:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid trying to fetch metapage of an SPGist partitioned index. This is necessary when spgcanreturn() is invoked on a partitioned index, and the failure might be reachable in other scenarios as well. The rest of what spgGetCache() does is perfectly sensible for a partitioned index, so we should allow it to go through. I think the main takeaway from this is that we lack sufficient test coverage for non-btree partitioned indexes. Therefore, I added simple test cases for brin and gin as well as spgist (hash and gist AMs were covered already in indexing.sql). Per bug #18256 from Alexander Lakhin. Although the known test case only fails since v16 (3c569049b), I've got no faith at all that there aren't other ways to reach this problem; so back-patch to all supported branches. Discussion: https://postgr.es/m/18256-0b0e1b6e4a620f1b@postgresql.org Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0977bd64e294bba50efc354479ebe3925cffa0ef Modified Files -------------- src/backend/access/spgist/spgutils.c | 29 +++++++++++++++---------- src/test/regress/expected/indexing.out | 39 ++++++++++++++++++++++++++++++++++ src/test/regress/sql/indexing.sql | 20 +++++++++++++++++ 3 files changed, 77 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Avoid trying to fetch metapage of an SPGist partitioned index. @ 2023-12-21 17:43 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2023-12-21 17:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid trying to fetch metapage of an SPGist partitioned index. This is necessary when spgcanreturn() is invoked on a partitioned index, and the failure might be reachable in other scenarios as well. The rest of what spgGetCache() does is perfectly sensible for a partitioned index, so we should allow it to go through. I think the main takeaway from this is that we lack sufficient test coverage for non-btree partitioned indexes. Therefore, I added simple test cases for brin and gin as well as spgist (hash and gist AMs were covered already in indexing.sql). Per bug #18256 from Alexander Lakhin. Although the known test case only fails since v16 (3c569049b), I've got no faith at all that there aren't other ways to reach this problem; so back-patch to all supported branches. Discussion: https://postgr.es/m/18256-0b0e1b6e4a620f1b@postgresql.org Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ab04c1901d0d55039330bc02f9f4e1024b2a95dc Modified Files -------------- src/backend/access/spgist/spgutils.c | 29 +++++++++++++++---------- src/test/regress/expected/indexing.out | 39 ++++++++++++++++++++++++++++++++++ src/test/regress/sql/indexing.sql | 20 +++++++++++++++++ 3 files changed, 77 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Avoid trying to fetch metapage of an SPGist partitioned index. @ 2023-12-21 17:43 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2023-12-21 17:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid trying to fetch metapage of an SPGist partitioned index. This is necessary when spgcanreturn() is invoked on a partitioned index, and the failure might be reachable in other scenarios as well. The rest of what spgGetCache() does is perfectly sensible for a partitioned index, so we should allow it to go through. I think the main takeaway from this is that we lack sufficient test coverage for non-btree partitioned indexes. Therefore, I added simple test cases for brin and gin as well as spgist (hash and gist AMs were covered already in indexing.sql). Per bug #18256 from Alexander Lakhin. Although the known test case only fails since v16 (3c569049b), I've got no faith at all that there aren't other ways to reach this problem; so back-patch to all supported branches. Discussion: https://postgr.es/m/18256-0b0e1b6e4a620f1b@postgresql.org Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/375f441bd19c0e747affbaa8a40203428411f5df Modified Files -------------- src/backend/access/spgist/spgutils.c | 29 +++++++++++++++---------- src/test/regress/expected/indexing.out | 39 ++++++++++++++++++++++++++++++++++ src/test/regress/sql/indexing.sql | 20 +++++++++++++++++ 3 files changed, 77 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Avoid trying to fetch metapage of an SPGist partitioned index. @ 2023-12-21 17:43 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2023-12-21 17:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid trying to fetch metapage of an SPGist partitioned index. This is necessary when spgcanreturn() is invoked on a partitioned index, and the failure might be reachable in other scenarios as well. The rest of what spgGetCache() does is perfectly sensible for a partitioned index, so we should allow it to go through. I think the main takeaway from this is that we lack sufficient test coverage for non-btree partitioned indexes. Therefore, I added simple test cases for brin and gin as well as spgist (hash and gist AMs were covered already in indexing.sql). Per bug #18256 from Alexander Lakhin. Although the known test case only fails since v16 (3c569049b), I've got no faith at all that there aren't other ways to reach this problem; so back-patch to all supported branches. Discussion: https://postgr.es/m/18256-0b0e1b6e4a620f1b@postgresql.org Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/cc3865150b8ae3d1951f78cf6bb7af1bc63b688d Modified Files -------------- src/backend/access/spgist/spgutils.c | 29 +++++++++++++++---------- src/test/regress/expected/indexing.out | 39 ++++++++++++++++++++++++++++++++++ src/test/regress/sql/indexing.sql | 20 +++++++++++++++++ 3 files changed, 77 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Avoid trying to fetch metapage of an SPGist partitioned index. @ 2023-12-21 17:43 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2023-12-21 17:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid trying to fetch metapage of an SPGist partitioned index. This is necessary when spgcanreturn() is invoked on a partitioned index, and the failure might be reachable in other scenarios as well. The rest of what spgGetCache() does is perfectly sensible for a partitioned index, so we should allow it to go through. I think the main takeaway from this is that we lack sufficient test coverage for non-btree partitioned indexes. Therefore, I added simple test cases for brin and gin as well as spgist (hash and gist AMs were covered already in indexing.sql). Per bug #18256 from Alexander Lakhin. Although the known test case only fails since v16 (3c569049b), I've got no faith at all that there aren't other ways to reach this problem; so back-patch to all supported branches. Discussion: https://postgr.es/m/18256-0b0e1b6e4a620f1b@postgresql.org Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1771ec9a82900665226022e77ad5f8a86d27a1be Modified Files -------------- src/backend/access/spgist/spgutils.c | 29 +++++++++++++++---------- src/test/regress/expected/indexing.out | 39 ++++++++++++++++++++++++++++++++++ src/test/regress/sql/indexing.sql | 20 +++++++++++++++++ 3 files changed, 77 insertions(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2023-12-21 17:43 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-12-21 17:43 pgsql: Avoid trying to fetch metapage of an SPGist partitioned index. Tom Lane <tgl@sss.pgh.pa.us> 2023-12-21 17:43 pgsql: Avoid trying to fetch metapage of an SPGist partitioned index. Tom Lane <tgl@sss.pgh.pa.us> 2023-12-21 17:43 pgsql: Avoid trying to fetch metapage of an SPGist partitioned index. Tom Lane <tgl@sss.pgh.pa.us> 2023-12-21 17:43 pgsql: Avoid trying to fetch metapage of an SPGist partitioned index. Tom Lane <tgl@sss.pgh.pa.us> 2023-12-21 17:43 pgsql: Avoid trying to fetch metapage of an SPGist partitioned index. Tom Lane <tgl@sss.pgh.pa.us> 2023-12-21 17:43 pgsql: Avoid trying to fetch metapage of an SPGist partitioned index. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox