pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Restore initdb's old behavior of always setting the lc_xxx GUCs. 2+ messages / 1 participants [nested] [flat]
* pgsql: Restore initdb's old behavior of always setting the lc_xxx GUCs. @ 2024-01-10 23:09 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2024-01-10 23:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Restore initdb's old behavior of always setting the lc_xxx GUCs. In commit 3e51b278d I (tgl) caused initdb to leave lc_messages and other lc_xxx GUCs commented-out in the installed postgresql.conf file if they were going to be set to 'C'. This was a hack for cosmetic purposes, and it was buggy because lc_messages' wired-in default is not 'C' but '' (empty string). That led to --no-locale not having the expected effect, since the postmaster would then obtain lc_messages from its startup environment. Let's just revert to the prior behavior of always de-commenting the lc_xxx entries; the argument for changing that longstanding behavior was weak in the first place. Also, fix postgresql.conf.sample's erroneous claim that the default value of lc_messages is 'C'. I suspect that was what misled me into making this mistake in the first place. Report and patch by Kyotaro Horiguchi. Back-patch to v16 where the problem was introduced. Discussion: https://postgr.es/m/20231122.162700.1995154567625541112.horikyota.ntt@gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/3d185cfc09c32b1f250adfbb62c0c7a3f96c5af2 Modified Files -------------- src/backend/utils/misc/postgresql.conf.sample | 2 +- src/bin/initdb/initdb.c | 24 ++++++++---------------- 2 files changed, 9 insertions(+), 17 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Restore initdb's old behavior of always setting the lc_xxx GUCs. @ 2024-01-10 23:09 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2024-01-10 23:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Restore initdb's old behavior of always setting the lc_xxx GUCs. In commit 3e51b278d I (tgl) caused initdb to leave lc_messages and other lc_xxx GUCs commented-out in the installed postgresql.conf file if they were going to be set to 'C'. This was a hack for cosmetic purposes, and it was buggy because lc_messages' wired-in default is not 'C' but '' (empty string). That led to --no-locale not having the expected effect, since the postmaster would then obtain lc_messages from its startup environment. Let's just revert to the prior behavior of always de-commenting the lc_xxx entries; the argument for changing that longstanding behavior was weak in the first place. Also, fix postgresql.conf.sample's erroneous claim that the default value of lc_messages is 'C'. I suspect that was what misled me into making this mistake in the first place. Report and patch by Kyotaro Horiguchi. Back-patch to v16 where the problem was introduced. Discussion: https://postgr.es/m/20231122.162700.1995154567625541112.horikyota.ntt@gmail.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ba33775fd0302befddfc5102c51e0e9fb1f282d3 Modified Files -------------- src/backend/utils/misc/postgresql.conf.sample | 2 +- src/bin/initdb/initdb.c | 24 ++++++++---------------- 2 files changed, 9 insertions(+), 17 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-01-10 23:09 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-01-10 23:09 pgsql: Restore initdb's old behavior of always setting the lc_xxx GUCs. Tom Lane <tgl@sss.pgh.pa.us> 2024-01-10 23:09 pgsql: Restore initdb's old behavior of always setting the lc_xxx GUCs. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox